Add timezone() function for convenient timezone creation#1314
Open
muhamedfazalps wants to merge 1 commit into
Open
Add timezone() function for convenient timezone creation#1314muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
Add a top-level arrow.timezone() function that wraps TzinfoParser.parse()
to provide a convenient interface for creating timezone objects from
strings. This allows users to write arrow.now(tz=arrow.timezone("US/Pacific"))
instead of having to use datetime.timezone or ZoneInfo directly.
Fixes arrow-py#912
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 10 10
Lines 2315 2318 +3
Branches 358 358
===========================================
+ Hits 2315 2317 +2
- Misses 0 1 +1 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a top-level arrow.timezone() function that wraps TzinfoParser.parse() to provide a convenient interface for creating timezone objects from strings. This allows users to write
arrow.now(tz=arrow.timezone("US/Pacific"))instead of having to use datetime.timezone or ZoneInfo directly.Fixes #912