Skip to content

Commit e2c9e70

Browse files
committed
Merge branch 'sc/ots_ops' of https://github.com/art-daq/artdaq-daqinterface into sc/ots_ops
2 parents cf07eb4 + da8b6f3 commit e2c9e70

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

rc/control/daqinterface.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,9 @@ def _timing_trace_init(self):
727727
self._timing_trace_depth = 0
728728

729729
def timing_trace(self, event, stage, elapsed_s=None, extra_fields=None):
730-
if not self.timing_trace_is_enabled():
730+
if not self.timing_trace_is_enabled() or getattr(
731+
self, "_timing_trace_failed", False
732+
):
731733
return
732734

733735
self._timing_trace_init()
@@ -3757,7 +3759,10 @@ def do_config(self, subconfigs_for_run=[]):
37573759
self.timing_trace_end(
37583760
"do_config_resolve_fhicl",
37593761
resolve_fhicl_start,
3760-
{"result": "update_fhicl_exception", "label": self.procinfos[i_proc].label},
3762+
{
3763+
"result": "update_fhicl_exception",
3764+
"label": self.procinfos[i_proc].label,
3765+
},
37613766
)
37623767
self.timing_trace_end(
37633768
"do_config_total", do_config_start, {"result": "failure"}
@@ -3979,9 +3984,7 @@ def do_config(self, subconfigs_for_run=[]):
39793984
)
39803985

39813986
self.print_log("i", "\n%s: CONFIG transition complete" % (date_and_time()))
3982-
self.timing_trace_end(
3983-
"do_config_total", do_config_start, {"result": "success"}
3984-
)
3987+
self.timing_trace_end("do_config_total", do_config_start, {"result": "success"})
39853988
return "done"
39863989

39873990
def do_start_running(self, run_number=None):

rc/control/manage_processes_direct.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ def launch_procs_on_host(
158158
out, _ = proc.communicate()
159159
status = proc.returncode
160160

161-
162161
self.print_log("d", "out: %s " % out, executing_commands_debug_level)
163162
self.print_log("d", "status: %s " % status, executing_commands_debug_level)
164163

rc/control/utilities.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ def construct_checked_command(cmds):
439439

440440
checked_cmds.append(cmd)
441441

442-
443442
if not re.search(r"\s*&\s*$", cmd):
444443
check_cmd = (
445444
'if [[ "$?" != "0" ]]; then echo %s: Nonzero return value from the following command: "%s" >> /tmp/daqinterface_checked_command_failures_%s.log; exit 1; fi '

0 commit comments

Comments
 (0)