Добавить packagedef в состав пакета#183
Open
ovcharenko-di wants to merge 15 commits into
Open
Conversation
ovcharenko-di
force-pushed
the
fix/packagedef
branch
6 times, most recently
from
da61d4f to
33b65e3
Compare
ovcharenko-di
force-pushed
the
fix/packagedef
branch
from
fd3fe25 to
61dcbbb
Compare
Author
|
@artbear нужно ревью |
Contributor
pr влит |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182
Помимо исправления ошибки с packagedef, внесено несколько изменений, направленных на унификацию поведения в Windows и Linux. Проверялось на oscript 2.0.0.
Тесты для
default(то есть для oscript 1.9.2) будут падать, потому что в 2.0.0 при вызовеoscriptизменился вывод. Должны падать только те тесты, которые этот вывод анализируют. Только ради зеленых тестов поднимать версию среды до 2.0.0 мне не захотелось.До момента, когда в
autumn-library/workflowsне будет принят мой PR, устанавливающий по умолчанию локальru_RU, также будут падать еще 2-3 теста.