Skip to content

Commit 0710313

Browse files
arul28claude
arul28
and
claude
authored
Huge Ade Mobile Pass (#320)
* ship: prepare lane for review Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ship: iteration 3 — address coderabbit + greptile review comments Addresses 20 actionable comments across TS (3) and iOS Swift (17): - ade-cli/adeRpcServer: decouple auto-title meta from goal - ade-cli/syncRemoteCommandService: validate confidenceThreshold 0..1 - desktop/kvDb: PK arity check runs before byte-typed PK accept - iOS Database: empty title skips title only, not whole update - iOS SyncService: contain activeProjectId remap; scope cached model catalog; fast-fail sendTestPush offline; indentation normalize - iOS Views Cto: clear stale budget/linearStatus/coreMemory on refresh failure - iOS Views Lanes: don't disable Push during sync-status loading - iOS Views PRs: neutral/skipped checks counted; 44pt touch targets; case-sensitive branch match; validate linkedLaneId against availableLanes - iOS Views Work: one-write terminal submit; don't skip idle transcript reconcile - iOS Tests: explicit SyncService.shared binding in deep-link test Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 4f38c5e commit 0710313

123 files changed

Lines changed: 8978 additions & 1856 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎apps/ade-cli/src/adeRpcServer.test.ts‎

Lines changed: 97 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ function createRuntime() {
219219
},
220220
sessionService: {
221221
get: vi.fn(),
222+
updateMeta: vi.fn(),
222223
readTranscriptTail: vi.fn(() => "")
223224
},
224225
sessionDeltaService: {
@@ -2446,6 +2447,8 @@ describe("adeRpcServer", () => {
24462447
provider: "codex",
24472448
permissionMode: "edit",
24482449
initialInput: "fix failing tests",
2450+
modelId: "openai/gpt-5.5",
2451+
reasoningEffort: "xhigh",
24492452
cols: 90,
24502453
rows: 24,
24512454
});
@@ -2454,7 +2457,7 @@ describe("adeRpcServer", () => {
24542457
expect(fixture.runtime.ptyService.create).toHaveBeenCalledWith(
24552458
expect.objectContaining({
24562459
laneId: "lane-1",
2457-
title: "Codex",
2460+
title: "Fix failing tests",
24582461
toolType: "codex",
24592462
cols: 90,
24602463
rows: 24,
@@ -2465,7 +2468,15 @@ describe("adeRpcServer", () => {
24652468
}),
24662469
}),
24672470
);
2468-
expect(fixture.runtime.ptyService.writeBySessionId).toHaveBeenCalledWith("session-1", "fix failing tests\r");
2471+
const createCall = fixture.runtime.ptyService.create.mock.calls.at(-1)?.[0];
2472+
expect(createCall?.args).toEqual(expect.arrayContaining(["--model", "gpt-5.5", "-c", "model_reasoning_effort=\"xhigh\""]));
2473+
expect(createCall?.args.at(-1)).toContain("fix failing tests");
2474+
expect(fixture.runtime.ptyService.writeBySessionId).not.toHaveBeenCalled();
2475+
expect(fixture.runtime.sessionService.updateMeta).toHaveBeenCalledWith(expect.objectContaining({
2476+
sessionId: "session-1",
2477+
goal: "fix failing tests",
2478+
title: "Fix failing tests",
2479+
}));
24692480
expect(response.structuredContent).toMatchObject({
24702481
provider: "codex",
24712482
laneId: "lane-1",
@@ -2503,8 +2514,61 @@ describe("adeRpcServer", () => {
25032514
expect.objectContaining({
25042515
cols: 400,
25052516
rows: 200,
2517+
startupCommand: expect.stringContaining("codex --no-alt-screen --sandbox workspace-write --ask-for-approval on-request"),
2518+
}),
2519+
);
2520+
expect(response.structuredContent.startupCommand).not.toContain("--full-auto");
2521+
});
2522+
2523+
it("starts shell CLI sessions without reading user shell startup files", async () => {
2524+
const fixture = createRuntime();
2525+
const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
2526+
2527+
const response = await withEnv({ SHELL: "/bin/zsh" }, async () => {
2528+
await initialize(handler, { role: "orchestrator" });
2529+
return await callTool(handler, "start_cli_session", {
2530+
laneId: "lane-1",
2531+
provider: "shell",
2532+
});
2533+
});
2534+
2535+
expect(response?.isError).toBeUndefined();
2536+
expect(fixture.runtime.ptyService.create).toHaveBeenCalledWith(
2537+
expect.objectContaining({
2538+
laneId: "lane-1",
2539+
title: "Shell",
2540+
toolType: "shell",
2541+
command: "/bin/zsh",
2542+
args: ["-f"],
2543+
env: { ZDOTDIR: "/var/empty" },
2544+
}),
2545+
);
2546+
});
2547+
2548+
it("starts Codex spawn_agent with current default permission flags", async () => {
2549+
const fixture = createRuntime();
2550+
const binDir = fs.mkdtempSync(path.join(os.tmpdir(), "ade-cli-spawn-bin-"));
2551+
createFakePathExecutable(binDir, "codex");
2552+
const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
2553+
2554+
const response = await withEnv({ PATH: `${binDir}${path.delimiter}${process.env.PATH ?? ""}`, SHELL: "/bin/sh" }, async () => {
2555+
await initialize(handler, { role: "orchestrator" });
2556+
return await callTool(handler, "spawn_agent", {
2557+
laneId: "lane-1",
2558+
provider: "codex",
2559+
prompt: "Check the mobile CLI path",
2560+
});
2561+
});
2562+
2563+
expect(response?.isError).toBeUndefined();
2564+
expect(fixture.runtime.ptyService.create).toHaveBeenCalledWith(
2565+
expect.objectContaining({
2566+
command: expect.stringMatching(/codex$/),
2567+
args: expect.arrayContaining(["--sandbox", "workspace-write", "--ask-for-approval", "on-request"]),
2568+
startupCommand: expect.stringContaining("codex --sandbox workspace-write --ask-for-approval on-request"),
25062569
}),
25072570
);
2571+
expect(response.structuredContent.startupCommand).not.toContain("--full-auto");
25082572
});
25092573

25102574
it("passes selected models to fresh Claude Code terminal launches", async () => {
@@ -2547,6 +2611,35 @@ describe("adeRpcServer", () => {
25472611
expect(response.structuredContent.model).toBe("anthropic/claude-opus-4-7-1m");
25482612
});
25492613

2614+
it("passes Claude auto permission mode to fresh Claude Code terminal launches", async () => {
2615+
const fixture = createRuntime();
2616+
fixture.runtime.sessionService.get.mockReturnValue({
2617+
id: "session-1",
2618+
laneId: "lane-1",
2619+
ptyId: "pty-1",
2620+
tracked: true,
2621+
toolType: "claude",
2622+
title: "Claude Code",
2623+
status: "running",
2624+
resumeCommand: null,
2625+
resumeMetadata: null,
2626+
});
2627+
const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
2628+
2629+
await initialize(handler, { role: "orchestrator" });
2630+
const response = await callTool(handler, "start_cli_session", {
2631+
laneId: "lane-1",
2632+
provider: "claude",
2633+
permissionMode: "auto",
2634+
});
2635+
2636+
expect(response?.isError).toBeUndefined();
2637+
const createCall = fixture.runtime.ptyService.create.mock.calls[0]?.[0] as { args?: string[]; startupCommand?: string };
2638+
expect(createCall.args).toEqual(expect.arrayContaining(["--permission-mode", "auto"]));
2639+
expect(createCall.startupCommand).toContain("--permission-mode auto");
2640+
expect(response.structuredContent.permissionMode).toBe("auto");
2641+
});
2642+
25502643
it("confirms Claude Code initial input after startup", async () => {
25512644
vi.useFakeTimers();
25522645
try {
@@ -2596,7 +2689,7 @@ describe("adeRpcServer", () => {
25962689
await initialize(handler, { role: "orchestrator" });
25972690
const response = await callTool(handler, "start_cli_session", {
25982691
laneId: "lane-1",
2599-
provider: "codex",
2692+
provider: "cursor",
26002693
initialInput: "fix failing tests",
26012694
});
26022695

@@ -2661,7 +2754,7 @@ describe("adeRpcServer", () => {
26612754

26622755
expect(response.isError).toBe(true);
26632756
expect(JSON.stringify(response.error ?? response.structuredContent ?? {})).toContain(
2664-
"permissionMode must be one of default, plan, edit, full-auto, or config-toml",
2757+
"permissionMode must be one of default, auto, plan, edit, full-auto, or config-toml",
26652758
);
26662759
expect(fixture.runtime.ptyService.create).not.toHaveBeenCalled();
26672760
});

‎apps/ade-cli/src/adeRpcServer.ts‎

Lines changed: 57 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,12 @@ import type { LinearConnectionStatus } from "../../desktop/src/shared/types/line
5656
import { resolveAdeLayout } from "../../desktop/src/shared/adeLayout";
5757
import {
5858
buildTrackedCliLaunchCommand,
59+
deriveTrackedCliInitialInputSessionMeta,
5960
isLaunchProfile,
6061
isTrackedCliPermissionMode,
6162
LAUNCH_PROFILE_TITLE,
6263
LAUNCH_PROFILE_TOOL_TYPE,
64+
resolveCleanShellLaunchFields,
6365
validateLaunchProfilePermissionMode,
6466
type CliProvider,
6567
type LaunchProfile,
@@ -225,7 +227,7 @@ const TOOL_SPECS: ToolSpec[] = [
225227
runId: { type: "string" },
226228
stepId: { type: "string" },
227229
attemptId: { type: "string" },
228-
permissionMode: { type: "string", enum: ["default", "plan", "edit", "full-auto", "config-toml"], default: "default" },
230+
permissionMode: { type: "string", enum: ["default", "auto", "plan", "edit", "full-auto", "config-toml"], default: "default" },
229231
toolWhitelist: { type: "array", items: { type: "string" }, maxItems: 24 },
230232
maxPromptChars: { type: "number", minimum: 256, maximum: 12000 },
231233
contextFilePath: { type: "string" },
@@ -322,13 +324,14 @@ const TOOL_SPECS: ToolSpec[] = [
322324
properties: {
323325
laneId: { type: "string", minLength: 1 },
324326
provider: { type: "string", enum: ["claude", "codex", "cursor", "droid", "opencode", "shell"] },
325-
permissionMode: { type: "string", enum: ["default", "plan", "edit", "full-auto", "config-toml"], default: "default" },
327+
permissionMode: { type: "string", enum: ["default", "auto", "plan", "edit", "full-auto", "config-toml"], default: "default" },
326328
title: { type: "string" },
327329
initialInput: { type: "string" },
328330
cols: { type: "number", minimum: 20, maximum: 400, default: 120 },
329331
rows: { type: "number", minimum: 4, maximum: 200, default: 36 },
330332
model: { type: "string" },
331333
modelId: { type: "string" },
334+
reasoningEffort: { type: "string" },
332335
cwd: { type: "string" },
333336
chatSessionId: { type: "string" },
334337
tracked: { type: "boolean", default: true }
@@ -1738,7 +1741,7 @@ const CTO_OPERATOR_TOOL_SPECS: ToolSpec[] = [
17381741
laneId: { type: "string" },
17391742
modelId: { type: "string" },
17401743
reasoningEffort: { type: "string" },
1741-
permissionMode: { type: "string", enum: ["default", "plan", "edit", "full-auto", "config-toml"] },
1744+
permissionMode: { type: "string", enum: ["default", "auto", "plan", "edit", "full-auto", "config-toml"] },
17421745
droidPermissionMode: { type: "string", enum: ["read-only", "auto-low", "auto-medium", "auto-high"] },
17431746
title: { type: "string" },
17441747
initialPrompt: { type: "string" },
@@ -2491,7 +2494,7 @@ function parseCliSessionPermissionMode(value: unknown): AgentChatPermissionMode
24912494
if (isTrackedCliPermissionMode(mode)) return mode;
24922495
throw new JsonRpcError(
24932496
JsonRpcErrorCode.invalidParams,
2494-
"permissionMode must be one of default, plan, edit, full-auto, or config-toml",
2497+
"permissionMode must be one of default, auto, plan, edit, full-auto, or config-toml",
24952498
);
24962499
}
24972500

@@ -3201,11 +3204,11 @@ function sha256Text(value: string): string {
32013204
return createHash("sha256").update(value).digest("hex");
32023205
}
32033206

3204-
type SpawnPermissionMode = "default" | "plan" | "edit" | "full-auto" | "config-toml";
3207+
type SpawnPermissionMode = "default" | "auto" | "plan" | "edit" | "full-auto" | "config-toml";
32053208

32063209
function parseSpawnPermissionMode(value: unknown): SpawnPermissionMode {
32073210
const normalized = asTrimmedString(value).toLowerCase();
3208-
if (normalized === "plan" || normalized === "edit" || normalized === "full-auto" || normalized === "config-toml") return normalized;
3211+
if (normalized === "auto" || normalized === "plan" || normalized === "edit" || normalized === "full-auto" || normalized === "config-toml") return normalized;
32093212
return "default";
32103213
}
32113214

@@ -5171,16 +5174,37 @@ async function runTool(args: {
51715174
}
51725175
const cols = clampInteger(toolArgs.cols, DEFAULT_PTY_COLS, 20, 400);
51735176
const rows = clampInteger(toolArgs.rows, DEFAULT_PTY_ROWS, 4, 200);
5174-
const title = asOptionalTrimmedString(toolArgs.title) ?? LAUNCH_PROFILE_TITLE[provider];
51755177
const initialInput = asOptionalTrimmedString(toolArgs.initialInput)?.slice(0, 20_000) ?? null;
51765178
const model = asOptionalTrimmedString(toolArgs.model) ?? asOptionalTrimmedString(toolArgs.modelId);
5179+
const reasoningEffort = asOptionalTrimmedString(toolArgs.reasoningEffort);
5180+
const initialInputMeta = deriveTrackedCliInitialInputSessionMeta({
5181+
provider,
5182+
title: asOptionalTrimmedString(toolArgs.title),
5183+
initialInput,
5184+
});
5185+
const title = initialInputMeta.title || LAUNCH_PROFILE_TITLE[provider];
51775186
const ptyService = runtime.ptyService;
51785187
const preassignedSessionId = provider === "claude" ? randomUUID() : undefined;
51795188
const laneWorktreePath = resolveLaneWorktreePath(runtime, laneId);
51805189

51815190
const launchFields: { startupCommand?: string; command?: string; args?: string[]; env?: Record<string, string> } = (() => {
5191+
if (provider === "shell") {
5192+
return resolveCleanShellLaunchFields({
5193+
platform: process.platform,
5194+
shell: process.env.SHELL,
5195+
comSpec: process.env.ComSpec,
5196+
});
5197+
}
51825198
if (!isCliProvider(provider)) return {};
5183-
return buildTrackedCliLaunchCommand({ provider, permissionMode, sessionId: preassignedSessionId, model, laneWorktreePath });
5199+
return buildTrackedCliLaunchCommand({
5200+
provider,
5201+
permissionMode,
5202+
sessionId: preassignedSessionId,
5203+
model,
5204+
reasoningEffort,
5205+
initialPrompt: provider === "codex" ? initialInput : null,
5206+
laneWorktreePath,
5207+
});
51845208
})();
51855209

51865210
const created = await ptyService.create({
@@ -5198,7 +5222,9 @@ async function runTool(args: {
51985222
});
51995223

52005224
let initialInputWritten = false;
5201-
if (initialInput && isCliProvider(provider)) {
5225+
if (initialInput && provider === "codex") {
5226+
initialInputWritten = true;
5227+
} else if (initialInput && isCliProvider(provider)) {
52025228
initialInputWritten = ptyService.writeBySessionId(created.sessionId, `${initialInput}\r`);
52035229
if (!initialInputWritten) {
52045230
try {
@@ -5225,6 +5251,19 @@ async function runTool(args: {
52255251
}
52265252
}
52275253

5254+
const autoTitleApplied = Boolean(initialInputMeta.promptTitle) && title === initialInputMeta.promptTitle;
5255+
if (initialInputMeta.goal || autoTitleApplied) {
5256+
const session = runtime.sessionService.get(created.sessionId) as TerminalSessionSummary | null;
5257+
const metaPatch: Parameters<typeof runtime.sessionService.updateMeta>[0] = {
5258+
sessionId: created.sessionId,
5259+
...(initialInputMeta.goal && !session?.goal?.trim().length ? { goal: initialInputMeta.goal } : {}),
5260+
...(autoTitleApplied ? { title: initialInputMeta.promptTitle!, manuallyNamed: false } : {}),
5261+
};
5262+
if (metaPatch.goal !== undefined || metaPatch.title !== undefined || metaPatch.manuallyNamed !== undefined) {
5263+
runtime.sessionService.updateMeta(metaPatch);
5264+
}
5265+
}
5266+
52285267
const session = runtime.sessionService.get(created.sessionId) as TerminalSessionSummary | null;
52295268
const enrichedSession = session ? ptyService.enrichSessions([session])[0] ?? session : session;
52305269
return {
@@ -6855,6 +6894,12 @@ async function runTool(args: {
68556894
"permissionMode config-toml is only supported for Codex spawn_agent sessions.",
68566895
);
68576896
}
6897+
if (provider === "codex" && permissionMode === "auto") {
6898+
throw new JsonRpcError(
6899+
JsonRpcErrorCode.invalidParams,
6900+
"permissionMode auto is only supported for Claude spawn_agent sessions.",
6901+
);
6902+
}
68586903
const maxPromptChars = Math.max(256, Math.min(12000, Math.floor(asNumber(toolArgs.maxPromptChars, 2800))));
68596904
const prompt = asOptionalTrimmedString(toolArgs.prompt);
68606905
const runId = asOptionalTrimmedString(toolArgs.runId);
@@ -6934,6 +6979,9 @@ async function runTool(args: {
69346979
case "edit":
69356980
claudePermission = "acceptEdits";
69366981
break;
6982+
case "auto":
6983+
claudePermission = "auto";
6984+
break;
69376985
default:
69386986
claudePermission = "default";
69396987
}

‎apps/ade-cli/src/bootstrap.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import { createMemoryService } from "../../desktop/src/main/services/memory/memo
4747
import { createCtoStateService } from "../../desktop/src/main/services/cto/ctoStateService";
4848
import { createWorkerAgentService } from "../../desktop/src/main/services/cto/workerAgentService";
4949
import { createWorkerBudgetService } from "../../desktop/src/main/services/cto/workerBudgetService";
50-
import type { createWorkerRevisionService } from "../../desktop/src/main/services/cto/workerRevisionService";
50+
import { createWorkerRevisionService } from "../../desktop/src/main/services/cto/workerRevisionService";
5151
import type { createWorkerHeartbeatService } from "../../desktop/src/main/services/cto/workerHeartbeatService";
5252
import type { createWorkerTaskSessionService } from "../../desktop/src/main/services/cto/workerTaskSessionService";
5353
import type { createLinearCredentialService } from "../../desktop/src/main/services/cto/linearCredentialService";
@@ -708,6 +708,11 @@ export async function createAdeRuntime(args: {
708708
workerAgentService,
709709
projectConfigService,
710710
});
711+
const workerRevisionService = createWorkerRevisionService({
712+
db,
713+
projectId,
714+
workerAgentService,
715+
});
711716
const missionBudgetService = createMissionBudgetService({
712717
db,
713718
logger,
@@ -1077,6 +1082,7 @@ export async function createAdeRuntime(args: {
10771082
agentChatService,
10781083
workerAgentService,
10791084
workerBudgetService,
1085+
workerRevisionService,
10801086
workerHeartbeatService: headlessLinearServices.workerHeartbeatService,
10811087
ctoStateService,
10821088
flowPolicyService: headlessLinearServices.flowPolicyService,
@@ -1158,6 +1164,7 @@ export async function createAdeRuntime(args: {
11581164
workerAgentService,
11591165
adeProjectService,
11601166
workerBudgetService,
1167+
workerRevisionService,
11611168
githubService: headlessLinearServices.githubService as never,
11621169
workerTaskSessionService: headlessLinearServices.workerTaskSessionService,
11631170
workerHeartbeatService: headlessLinearServices.workerHeartbeatService,

‎apps/ade-cli/src/cli.test.ts‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2237,6 +2237,28 @@ describe("ADE CLI", () => {
22372237
});
22382238
});
22392239

2240+
it("accepts Claude auto permission mode for provider CLI launches", () => {
2241+
const plan = buildCliPlan([
2242+
"shell",
2243+
"start-cli",
2244+
"claude",
2245+
"--lane",
2246+
"lane-1",
2247+
"--permission-mode",
2248+
"auto",
2249+
]);
2250+
expect(plan.kind).toBe("execute");
2251+
if (plan.kind !== "execute") return;
2252+
expect(plan.steps[0]?.params).toMatchObject({
2253+
name: "start_cli_session",
2254+
arguments: {
2255+
laneId: "lane-1",
2256+
provider: "claude",
2257+
permissionMode: "auto",
2258+
},
2259+
});
2260+
});
2261+
22402262
it("accepts --provider on shell start as the CLI-session launcher", () => {
22412263
const plan = buildCliPlan([
22422264
"shell",

0 commit comments

Comments
 (0)