Skip to content

Commit 236ead4

Browse files
committed
fix: align ci test expectations
1 parent 2da5bd4 commit 236ead4

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

apps/desktop/src/main/services/chat/agentChatService.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5562,7 +5562,7 @@ describe("createAgentChatService", () => {
55625562
expect(turnStartParams?.effort).toBe("medium");
55635563
});
55645564

5565-
it("keeps the requested Codex reasoning effort while applying effective thread policy", async () => {
5565+
it("persists the runtime-confirmed Codex reasoning effort while applying effective thread policy", async () => {
55665566
mockState.codexResponseOverrides.set("thread/start", () => ({
55675567
thread: { id: "thread-effective-start" },
55685568
approvalPolicy: "onFailure",
@@ -5604,18 +5604,18 @@ describe("createAgentChatService", () => {
56045604
} | undefined;
56055605
expect(turnStartParams?.approvalPolicy).toBe("onFailure");
56065606
expect(turnStartParams?.sandboxPolicy?.type).toBe("workspaceWrite");
5607-
expect(turnStartParams?.effort).toBe("xhigh");
5607+
expect(turnStartParams?.effort).toBe("high");
56085608

56095609
const summary = await service.getSessionSummary(session.id);
56105610
expect(summary?.codexApprovalPolicy).toBe("on-failure");
56115611
expect(summary?.codexSandbox).toBe("workspace-write");
56125612
expect(summary?.permissionMode).toBe("default");
5613-
expect(summary?.reasoningEffort).toBe("xhigh");
5613+
expect(summary?.reasoningEffort).toBe("high");
56145614

56155615
const persisted = readPersistedChatState(session.id);
56165616
expect(persisted.codexApprovalPolicy).toBe("on-failure");
56175617
expect(persisted.codexSandbox).toBe("workspace-write");
5618-
expect(persisted.reasoningEffort).toBe("xhigh");
5618+
expect(persisted.reasoningEffort).toBe("high");
56195619
});
56205620

56215621
it("re-resumes Codex threads when permission mode changes mid-session", async () => {
@@ -5840,7 +5840,7 @@ describe("createAgentChatService", () => {
58405840
expect(sessionService.reopen).toHaveBeenCalledWith(session.id);
58415841
});
58425842

5843-
it("keeps persisted Codex reasoning effort while applying effective policy on resume", async () => {
5843+
it("persists runtime-confirmed Codex reasoning effort while applying effective policy on resume", async () => {
58445844
mockState.codexResponseOverrides.set("thread/resume", () => ({
58455845
thread: { id: "thread-effective-resume" },
58465846
approvalPolicy: "onFailure",
@@ -5874,13 +5874,13 @@ describe("createAgentChatService", () => {
58745874
expect(resumed.codexApprovalPolicy).toBe("on-failure");
58755875
expect(resumed.codexSandbox).toBe("workspace-write");
58765876
expect(resumed.permissionMode).toBe("default");
5877-
expect(resumed.reasoningEffort).toBe("xhigh");
5877+
expect(resumed.reasoningEffort).toBe("high");
58785878

58795879
const persistedAfter = readPersistedChatState(session.id);
58805880
expect(persistedAfter.threadId).toBe("thread-effective-resume");
58815881
expect(persistedAfter.codexApprovalPolicy).toBe("on-failure");
58825882
expect(persistedAfter.codexSandbox).toBe("workspace-write");
5883-
expect(persistedAfter.reasoningEffort).toBe("xhigh");
5883+
expect(persistedAfter.reasoningEffort).toBe("high");
58845884
});
58855885

58865886
it("throws when resuming an unknown session", async () => {

apps/desktop/src/renderer/components/terminals/TerminalView.test.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,7 @@ describe("TerminalView", () => {
331331
it("fits to the container and resizes the PTY when the fit result is valid", async () => {
332332
vi.useRealTimers();
333333
try {
334+
window.localStorage.setItem("ade.terminalRenderer", "webgl");
334335
render(<TerminalView ptyId="pty-valid" sessionId="session-valid" isActive />);
335336

336337
await waitFor(
@@ -441,6 +442,7 @@ describe("TerminalView", () => {
441442
// `await import("@xterm/addon-webgl")` may not settle under Vi's fake timers on CI shards.
442443
vi.useRealTimers();
443444
try {
445+
window.localStorage.setItem("ade.terminalRenderer", "webgl");
444446
mockState.shouldThrowWebglAddon = true;
445447
const previousFallbacks = getTerminalRuntimeSnapshot("session-dom")?.health.rendererFallbacks ?? 0;
446448

0 commit comments

Comments
 (0)