Skip to content

Commit 33f3343

Browse files
committed
fix: align ci test expectations
1 parent 6835eee commit 33f3343

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

apps/desktop/src/main/services/chat/agentChatService.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5587,7 +5587,7 @@ describe("createAgentChatService", () => {
55875587
expect(turnStartParams?.effort).toBe("medium");
55885588
});
55895589

5590-
it("keeps the requested Codex reasoning effort while applying effective thread policy", async () => {
5590+
it("persists the runtime-confirmed Codex reasoning effort while applying effective thread policy", async () => {
55915591
mockState.codexResponseOverrides.set("thread/start", () => ({
55925592
thread: { id: "thread-effective-start" },
55935593
approvalPolicy: "onFailure",
@@ -5629,18 +5629,18 @@ describe("createAgentChatService", () => {
56295629
} | undefined;
56305630
expect(turnStartParams?.approvalPolicy).toBe("onFailure");
56315631
expect(turnStartParams?.sandboxPolicy?.type).toBe("workspaceWrite");
5632-
expect(turnStartParams?.effort).toBe("xhigh");
5632+
expect(turnStartParams?.effort).toBe("high");
56335633

56345634
const summary = await service.getSessionSummary(session.id);
56355635
expect(summary?.codexApprovalPolicy).toBe("on-failure");
56365636
expect(summary?.codexSandbox).toBe("workspace-write");
56375637
expect(summary?.permissionMode).toBe("default");
5638-
expect(summary?.reasoningEffort).toBe("xhigh");
5638+
expect(summary?.reasoningEffort).toBe("high");
56395639

56405640
const persisted = readPersistedChatState(session.id);
56415641
expect(persisted.codexApprovalPolicy).toBe("on-failure");
56425642
expect(persisted.codexSandbox).toBe("workspace-write");
5643-
expect(persisted.reasoningEffort).toBe("xhigh");
5643+
expect(persisted.reasoningEffort).toBe("high");
56445644
});
56455645

56465646
it("re-resumes Codex threads when permission mode changes mid-session", async () => {
@@ -5865,7 +5865,7 @@ describe("createAgentChatService", () => {
58655865
expect(sessionService.reopen).toHaveBeenCalledWith(session.id);
58665866
});
58675867

5868-
it("keeps persisted Codex reasoning effort while applying effective policy on resume", async () => {
5868+
it("persists runtime-confirmed Codex reasoning effort while applying effective policy on resume", async () => {
58695869
mockState.codexResponseOverrides.set("thread/resume", () => ({
58705870
thread: { id: "thread-effective-resume" },
58715871
approvalPolicy: "onFailure",
@@ -5899,13 +5899,13 @@ describe("createAgentChatService", () => {
58995899
expect(resumed.codexApprovalPolicy).toBe("on-failure");
59005900
expect(resumed.codexSandbox).toBe("workspace-write");
59015901
expect(resumed.permissionMode).toBe("default");
5902-
expect(resumed.reasoningEffort).toBe("xhigh");
5902+
expect(resumed.reasoningEffort).toBe("high");
59035903

59045904
const persistedAfter = readPersistedChatState(session.id);
59055905
expect(persistedAfter.threadId).toBe("thread-effective-resume");
59065906
expect(persistedAfter.codexApprovalPolicy).toBe("on-failure");
59075907
expect(persistedAfter.codexSandbox).toBe("workspace-write");
5908-
expect(persistedAfter.reasoningEffort).toBe("xhigh");
5908+
expect(persistedAfter.reasoningEffort).toBe("high");
59095909
});
59105910

59115911
it("throws when resuming an unknown session", async () => {

apps/desktop/src/renderer/components/terminals/TerminalView.test.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,7 @@ describe("TerminalView", () => {
331331
it("fits to the container and resizes the PTY when the fit result is valid", async () => {
332332
vi.useRealTimers();
333333
try {
334+
window.localStorage.setItem("ade.terminalRenderer", "webgl");
334335
render(<TerminalView ptyId="pty-valid" sessionId="session-valid" isActive />);
335336

336337
await waitFor(
@@ -441,6 +442,7 @@ describe("TerminalView", () => {
441442
// `await import("@xterm/addon-webgl")` may not settle under Vi's fake timers on CI shards.
442443
vi.useRealTimers();
443444
try {
445+
window.localStorage.setItem("ade.terminalRenderer", "webgl");
444446
mockState.shouldThrowWebglAddon = true;
445447
const previousFallbacks = getTerminalRuntimeSnapshot("session-dom")?.health.rendererFallbacks ?? 0;
446448

0 commit comments

Comments
 (0)