Fix ADE pressure and session recovery

* Fix ADE pressure and session recovery

* Address PR review feedback

* Fix autoreview follow-ups

* Address runtime stop review notes

* Keep already-gone runtimes stopped

* Fix runtime mismatch and lane config saves

* Fix usage retry and live PTY disposal guards

* Fix TerminalView renderer test portability

* Fix lane behavior source toggle save

Author: arul28

apps/ade-cli/src/adeRpcServer.test.ts

@@ -289,7 +289,7 @@ function createRuntime() {
         resumed: true,
         reusedExistingRuntime: false,
       })),
-      dispose: vi.fn(),
+      dispose: vi.fn(() => ({ disposed: true, reason: "disposed" })),
       writeBySessionId: vi.fn((sessionId: string, data: string): boolean => {
         void sessionId;
         void data;
@@ -990,7 +990,7 @@ describe("adeRpcServer", () => {
       id: 7,
       method: "pty.dispose",
       params: { args: { ptyId: "pty-1", sessionId: "session-1" } },
-    })).resolves.toBeNull();
+    })).resolves.toEqual({ disposed: true, reason: "disposed" });
     expect(runtime.ptyService.dispose).toHaveBeenCalledWith({ ptyId: "pty-1", sessionId: "session-1" });
 
     const listed = await handler({

apps/ade-cli/src/adeRpcServer.ts

@@ -5448,8 +5448,7 @@ export function createAdeRpcRequestHandler(args: {
       }
       if (method === "pty.dispose") {
         ensurePtyTargetAuthorized(runtime, session, method, ptyArgs);
-        runtime.ptyService.dispose(ptyArgs as Parameters<typeof runtime.ptyService.dispose>[0]);
-        return null;
+        return runtime.ptyService.dispose(ptyArgs as Parameters<typeof runtime.ptyService.dispose>[0]);
       }
       if (method === "pty.list") {
         return { sessions: listAuthorizedPtySessions(runtime, session, method, ptyArgs) };

apps/ade-cli/src/headlessLinearServices.ts

@@ -1899,7 +1899,7 @@ export function createHeadlessLinearServices(
         "PTY-backed run commands are unavailable in headless Linear services.",
       );
     },
-    dispose: () => {},
+    dispose: () => ({ disposed: false as const, reason: "missing" as const }),
     onData: () => () => {},
     onExit: () => () => {},
   };

apps/desktop/src/main/services/config/projectConfigService.ts

@@ -152,6 +152,10 @@ function asComputeBackend(value: unknown): "local" | "vps" | "daytona" | undefin
   return COMPUTE_BACKEND_SCHEMA.parse(value);
 }
 
+function asNewLaneBaseSource(value: unknown): "local" | "remote" | undefined {
+  return value === "local" || value === "remote" ? value : undefined;
+}
+
 function coerceOrchestratorHookConfig(value: unknown): { command: string; timeoutMs?: number } | null {
   if (typeof value === "string") {
     const command = value.trim();
@@ -2009,10 +2013,15 @@ function coerceConfigFile(value: unknown): ProjectConfigFile {
 
   const github = coerceGithubConfig(value.github);
 
-  const git =
-    isRecord(value.git) && asBool(value.git.autoRebaseOnHeadChange) != null
-      ? { autoRebaseOnHeadChange: asBool(value.git.autoRebaseOnHeadChange) }
-      : undefined;
+  const git = (() => {
+    if (!isRecord(value.git)) return undefined;
+    const autoRebaseOnHeadChange = asBool(value.git.autoRebaseOnHeadChange);
+    const newLaneBaseSource = asNewLaneBaseSource(value.git.newLaneBaseSource);
+    const out: NonNullable<ProjectConfigFile["git"]> = {};
+    if (autoRebaseOnHeadChange != null) out.autoRebaseOnHeadChange = autoRebaseOnHeadChange;
+    if (newLaneBaseSource) out.newLaneBaseSource = newLaneBaseSource;
+    return Object.keys(out).length ? out : undefined;
+  })();
 
   const providersRaw = isRecord(value.providers)
     ? { ...(value.providers as Record<string, unknown>) }
@@ -2515,7 +2524,8 @@ function resolveEffectiveConfig(shared: ProjectConfigFile, local: ProjectConfigF
     providerMode,
     ...(mergedGithub ? { github: mergedGithub } : {}),
     git: {
-      autoRebaseOnHeadChange: mergedGit?.autoRebaseOnHeadChange ?? false
+      autoRebaseOnHeadChange: mergedGit?.autoRebaseOnHeadChange ?? false,
+      newLaneBaseSource: mergedGit?.newLaneBaseSource ?? "remote",
     },
     ...(effectiveAi ? { ai: effectiveAi } : {}),
     ...(mergedProviders ? { providers: mergedProviders } : {}),

apps/desktop/src/main/services/git/gitOperationsService.test.ts

@@ -1569,10 +1569,10 @@ describe("gitOperationsService.listBranches annotations", () => {
     }
   });
 
-  it("dedupes a remote ref when its local counterpart already exists", async () => {
+  it("dedupes a remote ref when its local counterpart tracks it", async () => {
     mockGit.runGitOrThrow.mockResolvedValue(
       [
-        "refs/heads/feature/dup\tfeature/dup\t*\t",
+        "refs/heads/feature/dup\tfeature/dup\t*\torigin/feature/dup",
         "refs/remotes/origin/feature/dup\torigin/feature/dup\t \t",
       ].join("\n"),
     );
@@ -1583,6 +1583,20 @@ describe("gitOperationsService.listBranches annotations", () => {
     expect(branches.find((b) => b.name === "origin/feature/dup")).toBeUndefined();
   });
 
+  it("keeps a remote counterpart when the local branch has no upstream", async () => {
+    mockGit.runGitOrThrow.mockResolvedValue(
+      [
+        "refs/heads/feature/untracked\tfeature/untracked\t*\t",
+        "refs/remotes/origin/feature/untracked\torigin/feature/untracked\t \t",
+      ].join("\n"),
+    );
+    const { service } = makeServiceWithLanes({});
+
+    const branches = await service.listBranches({ laneId: "lane-1" });
+    expect(branches.find((b) => b.name === "feature/untracked")).toBeDefined();
+    expect(branches.find((b) => b.name === "origin/feature/untracked")).toBeDefined();
+  });
+
   it("filters refs/remotes/.../HEAD entries out of the result", async () => {
     mockGit.runGitOrThrow.mockResolvedValue(
       [

apps/desktop/src/main/services/git/gitOperationsService.ts

@@ -1679,7 +1679,9 @@ export function createGitOperationsService({
       const localNames = new Set(localBranches.keys());
       const dedupedRemotes = remoteBranches.filter((branch) => {
         const localCandidate = localBranchNameFromRemoteRef(branch.name);
-        return !localNames.has(localCandidate);
+        if (!localNames.has(localCandidate)) return true;
+        const local = localBranches.get(localCandidate);
+        return local?.upstream !== branch.name;
       });
 
       const sortedLocals = Array.from(localBranches.values()).sort((a, b) => {

apps/desktop/src/main/services/ipc/registerIpc.ts

@@ -389,6 +389,7 @@ import type {
   RecentProjectSummary,
   PtyCreateArgs,
   PtyCreateResult,
+  PtyDisposeResult,
   PtyResumeSessionArgs,
   PtyResumeSessionResult,
   PtySendToSessionArgs,
@@ -6062,10 +6063,20 @@ export function registerIpc({
         });
       }
     }
-    return ptyService.enrichSessions([session])[0] ?? {
+    let enriched = ptyService.enrichSessions([session])[0] ?? {
       ...session,
       runtimeState: ptyService.getRuntimeState(session.id, session.status)
     };
+    if (enriched.status === "running" && isChatToolType(enriched.toolType)) {
+      try {
+        const chat = await ctx.agentChatService?.getSessionSummary(enriched.id);
+        if (chat) enriched = projectChatOntoSession(enriched, chat);
+      } catch {
+        // Detail reads should still return the persisted session if chat state
+        // hydration fails during runtime restart/recovery.
+      }
+    }
+    return enriched;
   });
 
   ipcMain.handle(IPC.sessionsDelete, async (_event, arg: DeleteSessionArgs): Promise<void> => {
@@ -7566,8 +7577,8 @@ export function registerIpc({
     requirePtyService().resize(arg);
   });
 
-  ipcMain.handle(IPC.ptyDispose, async (_event, arg: { ptyId: string; sessionId?: string }): Promise<void> => {
-    requirePtyService().dispose(arg);
+  ipcMain.handle(IPC.ptyDispose, async (_event, arg: { ptyId: string; sessionId?: string }): Promise<PtyDisposeResult> => {
+    return requirePtyService().dispose(arg);
   });
 
   ipcMain.handle(IPC.terminalList, async (_event, arg) =>

apps/desktop/src/main/services/lanes/laneTemplateService.test.ts

@@ -34,7 +34,7 @@ function makeEffective(overrides: Partial<EffectiveProjectConfig> = {}): Effecti
     testSuites: [],
     laneOverlayPolicies: [],
     automations: [],
-    git: { autoRebaseOnHeadChange: false },
+    git: { autoRebaseOnHeadChange: false, newLaneBaseSource: "remote" },
     ...overrides,
   };
 }

apps/desktop/src/main/services/pty/ptyService.test.ts

@@ -3669,7 +3669,7 @@ describe("ptyService", () => {
       });
     });
 
-    it("does not end persisted agent chat rows just because there is no PTY", () => {
+    it("keeps persisted agent chat rows resumable but idle when there is no PTY", () => {
       const { service } = createHarness();
       const enriched = service.enrichSessions([{
         id: "chat-session",
@@ -3682,7 +3682,7 @@ describe("ptyService", () => {
       expect(enriched[0]).toMatchObject({
         id: "chat-session",
         status: "running",
-        runtimeState: "running",
+        runtimeState: "idle",
       });
     });
 
@@ -3730,6 +3730,19 @@ describe("ptyService", () => {
       );
     });
 
+    it("does not kill a live PTY when the supplied session id belongs to another session", async () => {
+      const { service, mockPty, sessionService, broadcastExit } = createHarness();
+      const first = await service.create({ laneId: "lane-1", title: "first", cols: 80, rows: 24 });
+      const second = await service.create({ laneId: "lane-1", title: "second", cols: 80, rows: 24 });
+
+      const result = service.dispose({ ptyId: second.ptyId, sessionId: first.sessionId });
+
+      expect(result).toEqual({ disposed: false, reason: "session-mismatch" });
+      expect(mockPty.kill).not.toHaveBeenCalled();
+      expect(sessionService.end).not.toHaveBeenCalled();
+      expect(broadcastExit).not.toHaveBeenCalled();
+    });
+
     it("handles disposing an already-disposed PTY gracefully", async () => {
       const { service } = createHarness();
       const { ptyId } = await service.create({ laneId: "lane-1", title: "d", cols: 80, rows: 24 });

apps/desktop/src/main/services/pty/ptyService.ts

@@ -24,6 +24,7 @@ import type {
   PtyExitEvent,
   PtyCreateArgs,
   PtyCreateResult,
+  PtyDisposeResult,
   PtyResumeSessionArgs,
   PtyResumeSessionResult,
   PtySendToSessionArgs,
@@ -4690,6 +4691,10 @@ export function createPtyService({
         const runningWithoutReachablePty = !live
           && row.status === "running"
           && !isPersistedChatToolType(row.toolType ?? null);
+        const idlePersistedChatRuntime = !live
+          && row.status === "running"
+          && isPersistedChatToolType(row.toolType ?? null)
+          && computeRuntimeState(row.id, row.status) === "running";
         const isDetachedFromThisRuntime = ownedByLivePeer || runningWithoutReachablePty;
         const fallbackStatus = live ? "running" : row.status;
         return {
@@ -4707,22 +4712,26 @@ export function createPtyService({
                   status: "detached" as const,
                 }
               : {}),
-          runtimeState: isDetachedFromThisRuntime ? "exited" : computeRuntimeState(row.id, fallbackStatus),
+          runtimeState: isDetachedFromThisRuntime
+            ? "exited"
+            : idlePersistedChatRuntime
+              ? "idle"
+              : computeRuntimeState(row.id, fallbackStatus),
           chatSessionId: live
             ? terminalChatSessions.get(row.id) ?? live[1].chatSessionId ?? row.chatSessionId ?? null
             : terminalChatSessions.get(row.id) ?? row.chatSessionId ?? null,
         };
       });
     },
 
-    dispose({ ptyId, sessionId }: { ptyId: string; sessionId?: string }): void {
+    dispose({ ptyId, sessionId }: { ptyId: string; sessionId?: string }): PtyDisposeResult {
       const entry = ptys.get(ptyId);
       if (!entry) {
-        if (!sessionId) return;
+        if (!sessionId) return { disposed: false, reason: "missing" };
         const session = sessionService.get(sessionId);
-        if (!session) return;
-        if (session.status && session.status !== "running") return;
-        if (session.ptyId && session.ptyId !== ptyId) return;
+        if (!session) return { disposed: false, reason: "missing" };
+        if (session.status && session.status !== "running") return { disposed: false, reason: "not-running" };
+        if (session.ptyId && session.ptyId !== ptyId) return { disposed: false, reason: "session-mismatch" };
         if (
           ownerPid != null
           && session.ownerPid != null
@@ -4735,7 +4744,7 @@ export function createPtyService({
             ownerPid: session.ownerPid,
             currentPid: ownerPid,
           });
-          return;
+          return { disposed: false, reason: "owned-by-peer" };
         }
         // The renderer can outlive the pty map (for example after app restart). Allow closing by session id
         // so stale sessions do not get stuck in a "running" state forever.
@@ -4766,9 +4775,12 @@ export function createPtyService({
           }
         }
         logger.warn("pty.dispose_orphaned", { ptyId, sessionId });
-        return;
+        return { disposed: true, reason: "orphaned" };
       }
-      if (entry.disposed) return;
+      if (sessionId && entry.sessionId !== sessionId) {
+        return { disposed: false, reason: "session-mismatch" };
+      }
+      if (entry.disposed) return { disposed: false, reason: "already-disposed" };
       entry.disposed = true;
       if (entry.aiTitleTimer) {
         clearTimeout(entry.aiTitleTimer);
@@ -4808,14 +4820,15 @@ export function createPtyService({
       ptys.delete(ptyId);
 
       if (!entry.tracked) {
-        return;
+        return { disposed: true, reason: "disposed" };
       }
 
       try {
         onSessionEnded?.({ laneId: entry.laneId, sessionId: entry.sessionId, exitCode: null });
       } catch {
         // ignore
       }
+      return { disposed: true, reason: "disposed" };
     },
 
     disposeAll(): void {