ship: iter 2 — fix 3 capy-ai bugs, unblock test-desktop(5)

- Wrap 5 CreatePrModal test render sites in MemoryRouter so the
  useNavigate() call added in the overhaul no longer trips React
  Router's invariant. This is the direct cause of the test-desktop(5)
  CI failure and the bug in capy-ai #3133285481.
- In parsePrsRouteState, let hash workflow= win over search workflow=
  so BrowserRouter mock-mode URLs like
  ?tab=workflows&workflow=queue#/prs?...&workflow=rebase resolve to
  the hash's workflow. Adds a reproduction test (capy-ai #3133285495).
- In useWorkSessions' URL-filter effect, hold off caching
  appliedUrlFilterKeyRef when laneId is specified but lanes haven't
  loaded yet, so a later lanes-populated render can still apply the
  lane filter instead of early-returning (capy-ai #3133331539).

Verified locally: desktop tsc clean; 47 affected tests pass across
CreatePrModal, prsRouteState, useWorkSessions, PrsContext.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: arul28

apps/desktop/src/renderer/components/prs/CreatePrModal.test.tsx

@@ -4,8 +4,13 @@ import React from "react";
 import { cleanup, fireEvent, render, screen, waitFor, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { MemoryRouter } from "react-router-dom";
 import type { LaneSummary } from "../../../shared/types";
 
+function renderWithRouter(ui: React.ReactElement) {
+  return render(<MemoryRouter>{ui}</MemoryRouter>);
+}
+
 function makeLane(overrides: Partial<LaneSummary> = {}): LaneSummary {
   return {
     id: "lane-1",
@@ -117,7 +122,7 @@ describe("CreatePrModal queue workflow", () => {
 
   it("adds selected lanes to the queue order and removes them from the queue builder", async () => {
     const user = userEvent.setup();
-    render(<CreatePrModal open onOpenChange={vi.fn()} />);
+    renderWithRouter(<CreatePrModal open onOpenChange={vi.fn()} />);
 
     await user.click(screen.getAllByRole("button", { name: /queue workflow/i })[0]!);
     await user.click(screen.getByRole("checkbox", { name: /01 queue lane/i }));
@@ -136,7 +141,7 @@ describe("CreatePrModal queue workflow", () => {
 
   it("uses the dragged queue order when creating queue PRs", async () => {
     const user = userEvent.setup();
-    render(<CreatePrModal open onOpenChange={vi.fn()} />);
+    renderWithRouter(<CreatePrModal open onOpenChange={vi.fn()} />);
 
     await user.click(screen.getAllByRole("button", { name: /queue workflow/i })[0]!);
     await user.click(screen.getByRole("checkbox", { name: /01 queue lane/i }));
@@ -165,7 +170,7 @@ describe("CreatePrModal queue workflow", () => {
 
   it("lets single-PR creation target a different branch than Primary's current branch", async () => {
     const user = userEvent.setup();
-    render(<CreatePrModal open onOpenChange={vi.fn()} />);
+    renderWithRouter(<CreatePrModal open onOpenChange={vi.fn()} />);
 
     // Select source lane
     const comboboxes = screen.getAllByRole("combobox");
@@ -191,7 +196,7 @@ describe("CreatePrModal queue workflow", () => {
 
   it("warns when the PR target branch differs from the lane base branch", async () => {
     const user = userEvent.setup();
-    render(<CreatePrModal open onOpenChange={vi.fn()} />);
+    renderWithRouter(<CreatePrModal open onOpenChange={vi.fn()} />);
 
     // Select source lane
     const comboboxes = screen.getAllByRole("combobox");
@@ -210,7 +215,7 @@ describe("CreatePrModal queue workflow", () => {
 
   it("lets queue creation target a different branch than Primary's current branch", async () => {
     const user = userEvent.setup();
-    render(<CreatePrModal open onOpenChange={vi.fn()} />);
+    renderWithRouter(<CreatePrModal open onOpenChange={vi.fn()} />);
 
     await user.click(screen.getAllByRole("button", { name: /queue workflow/i })[0]!);
     await user.click(screen.getByRole("checkbox", { name: /01 queue lane/i }));

apps/desktop/src/renderer/components/prs/prsRouteState.test.ts

@@ -140,4 +140,19 @@ describe("resolvePrsActiveTab", () => {
     expect(resolved.isWorkflowRoute).toBe(false);
     expect(resolved.activeTab).toBe("normal");
   });
+
+  it("prefers the hash workflow over a stale outer search workflow (BrowserRouter mock mode)", () => {
+    // Outer URL like `/?tab=workflows&workflow=queue#/prs?tab=workflows&workflow=rebase`
+    // In BrowserRouter mock mode the outer search is stale; the inner hash is the
+    // current in-app location and must win.
+    const parsed = parsePrsRouteState({
+      search: "?tab=workflows&workflow=queue",
+      hash: "#/prs?tab=workflows&workflow=rebase",
+    });
+    expect(parsed.workflowTab).toBe("rebase");
+    const resolved = resolvePrsActiveTab(parsed);
+    expect(resolved.isWorkflowRoute).toBe(true);
+    expect(resolved.effectiveWorkflow).toBe("rebase");
+    expect(resolved.activeTab).toBe("rebase");
+  });
 });

apps/desktop/src/renderer/components/prs/prsRouteState.ts

@@ -48,9 +48,19 @@ export function parsePrsRouteState(args: { search?: string | null; hash?: string
   const pick = (key: string): string | null =>
     parseOptionalId(searchParams.get(key)) ?? parseOptionalId(hashParams.get(key));
 
+  // Workflow precedence: when both search and hash carry a workflow value, the
+  // hash is authoritative. In BrowserRouter mock mode (e.g. when the outer
+  // location is `?tab=workflows&workflow=queue#/prs?...&workflow=rebase`), the
+  // inner hash is the current in-app location; the outer search may be stale
+  // and must not mask it. Still fall back to search when hash has no workflow.
+  const hashWorkflowRaw = hashParams.get("workflow");
+  const searchWorkflowRaw = searchParams.get("workflow");
+  const hashWorkflow = parseWorkflowTab(hashWorkflowRaw);
+  const workflowTab = hashWorkflow ?? parseWorkflowTab(searchWorkflowRaw);
+
   return {
     tab: parseTab(searchParams.get("tab") ?? hashParams.get("tab")),
-    workflowTab: parseWorkflowTab(searchParams.get("workflow") ?? hashParams.get("workflow")),
+    workflowTab,
     laneId: pick("laneId"),
     prId: pick("prId"),
     queueGroupId: pick("queueGroupId"),

apps/desktop/src/renderer/components/terminals/useWorkSessions.ts

@@ -623,7 +623,18 @@ export function useWorkSessions() {
     const laneExists = laneParam && lanes.some((lane) => lane.id === laneParam);
     const status = mapUrlStatusFilter(statusParam);
     if (!laneExists && !status) return;
-    appliedUrlFilterKeyRef.current = urlKey;
+    // When the URL specifies a laneId but lanes haven't populated yet (e.g. on
+    // project open/switch the store resets lanes to [] then repopulates async),
+    // we can't tell whether the lane is missing-for-good or just-not-yet-loaded.
+    // In that case, apply any status hint but don't cache the URL signature —
+    // come back once lanes populate so the lane portion can apply too. We only
+    // mark the key applied when the lane portion was definitively applied, or
+    // when lanes are loaded (non-empty) so "not found" is an authoritative
+    // negative signal.
+    const laneDeterminable = !laneParam || laneExists || lanes.length > 0;
+    if (laneDeterminable) {
+      appliedUrlFilterKeyRef.current = urlKey;
+    }
     setProjectViewState((prev) => ({
       ...prev,
       laneFilter: laneExists ? laneParam : prev.laneFilter,