Files tab: remove view-only mode, fix remote workspace-id staleness (#780)

The Files tab went read-only when remote-connected: editability was gated
on a tab's workspaceId (host-DB lane UUIDs) resolving against the listed
workspaces, but restored sessions and module caches keyed only by project
root path carried the local machine's stale UUIDs.

- Remove the canEdit/canMutate view-only concept entirely: code tabs are
  always editable and saveable; non-code viewers stay naturally read-only.
- Key the workspaces/root-tree module caches by binding identity
  (local vs remote:<targetId>) so local and remote sessions for the same
  path no longer pollute each other.
- Retry listWorkspaces with capped backoff instead of silently swallowing
  failures.
- Remap stale tab workspace ids to the freshly listed workspaces (by lane,
  then primary), recomputing composite tab ids, deduping collisions, and
  migrating dirty/reload state; external-workspace tabs untouched.
- Add monacoModelRegistry.rekey so live buffers, undo stacks, and dirty
  state follow remapped tab ids (dirty buffer wins on collision).

Wire fields isReadOnlyByDefault/mobileReadOnly are intentionally unchanged
(iOS decodes them strictly); host-side write actions were already
allowlisted.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: arul28

apps/desktop/src/renderer/components/files/FilesExplorer.test.tsx

@@ -51,22 +51,8 @@ function renderExplorer(overrides: Partial<FilesExplorerProps> = {}) {
 }
 
 describe("FilesExplorer mutating controls", () => {
-  it("disables create controls for read-only workspaces", () => {
-    const props = renderExplorer({ canMutate: false });
-
-    const newFile = screen.getByLabelText("New file") as HTMLButtonElement;
-    const newFolder = screen.getByLabelText("New folder") as HTMLButtonElement;
-    expect(newFile.disabled).toBe(true);
-    expect(newFolder.disabled).toBe(true);
-
-    fireEvent.click(newFile);
-    fireEvent.click(newFolder);
-    expect(props.onCreateFile).not.toHaveBeenCalled();
-    expect(props.onCreateDirectory).not.toHaveBeenCalled();
-  });
-
-  it("keeps create controls active for mutable workspaces", () => {
-    const props = renderExplorer({ canMutate: true });
+  it("keeps create controls active", () => {
+    const props = renderExplorer();
 
     const newFile = screen.getByLabelText("New file") as HTMLButtonElement;
     const newFolder = screen.getByLabelText("New folder") as HTMLButtonElement;

apps/desktop/src/renderer/components/files/FilesExplorer.tsx

@@ -81,7 +81,6 @@ export type FilesExplorerProps = {
   onContextMenu: (event: FilesExplorerContextMenuEvent) => void;
   onRenamePath: (sourcePath: string, destinationPath: string) => Promise<void>;
   onInlineRenameSettled: () => void;
-  canMutate?: boolean;
   compact?: boolean;
 };
 
@@ -192,7 +191,6 @@ export function FilesExplorer({
   onContextMenu,
   onRenamePath,
   onInlineRenameSettled,
-  canMutate = true,
   compact = false,
 }: FilesExplorerProps) {
   const scrollRef = useRef<HTMLDivElement | null>(null);
@@ -310,7 +308,6 @@ export function FilesExplorer({
               type="button"
               title="New file"
               aria-label="New file"
-              disabled={!canMutate}
               style={{ ...outlineButton({ height: 24, padding: "0 6px", fontSize: 10 }) }}
               onClick={() => onCreateFile(activeContextDir)}
               onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}
@@ -324,7 +321,6 @@ export function FilesExplorer({
               type="button"
               title="New folder"
               aria-label="New folder"
-              disabled={!canMutate}
               style={{ ...outlineButton({ height: 24, padding: "0 6px", fontSize: 10 }) }}
               onClick={() => onCreateDirectory(activeContextDir)}
               onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}
@@ -387,7 +383,6 @@ export function FilesExplorer({
               type="button"
               title="New file"
               aria-label="New file"
-              disabled={!canMutate}
               style={{ ...outlineButton({ height: 28, padding: "0 7px", fontSize: 10 }) }}
               onClick={() => onCreateFile(activeContextDir)}
               onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}
@@ -401,7 +396,6 @@ export function FilesExplorer({
               type="button"
               title="New folder"
               aria-label="New folder"
-              disabled={!canMutate}
               style={{ ...outlineButton({ height: 28, padding: "0 7px", fontSize: 10 }) }}
               onClick={() => onCreateDirectory(activeContextDir)}
               onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}
@@ -490,7 +484,6 @@ export function FilesExplorer({
             type="button"
             title="New file"
             aria-label="New file"
-            disabled={!canMutate}
             style={{ ...outlineButton({ height: 24, padding: "0 6px", fontSize: 10 }) }}
             onClick={() => onCreateFile(activeContextDir)}
             onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}
@@ -504,7 +497,6 @@ export function FilesExplorer({
             type="button"
             title="New folder"
             aria-label="New folder"
-            disabled={!canMutate}
             style={{ ...outlineButton({ height: 24, padding: "0 6px", fontSize: 10 }) }}
             onClick={() => onCreateDirectory(activeContextDir)}
             onMouseEnter={(event) => { event.currentTarget.style.borderColor = COLORS.accent; event.currentTarget.style.color = COLORS.accent; }}

apps/desktop/src/renderer/components/files/monacoModelRegistry.test.ts

@@ -165,6 +165,62 @@ describe("monacoModelRegistry", () => {
     expect(registry.isDirty("a")).toBe(true);
   });
 
+  it("rekey moves the live buffer, dirty state, and identity to the new key", () => {
+    const { monaco, createdCount } = createFakeMonaco();
+    const registry = createMonacoModelRegistry();
+
+    const model = registry.getOrCreate(monaco, "stale-ws::src/a.ts", "draft", "typescript") as any;
+    model.__edit();
+    registry.rekey("stale-ws::src/a.ts", "host-ws::src/a.ts");
+
+    expect(registry.has("stale-ws::src/a.ts")).toBe(false);
+    expect(registry.getValue("host-ws::src/a.ts")).toBe("draft");
+    expect(registry.isDirty("host-ws::src/a.ts")).toBe(true);
+    // Reopening under the new key reuses the moved model — no rebuild from disk.
+    const reopened = registry.getOrCreate(monaco, "host-ws::src/a.ts", "disk content", "typescript");
+    expect(reopened).toBe(model);
+    expect(createdCount()).toBe(1);
+    expect(model.dispose).not.toHaveBeenCalled();
+  });
+
+  it("rekey collision keeps the dirty buffer and disposes the clean one", () => {
+    const { monaco } = createFakeMonaco();
+    const registry = createMonacoModelRegistry();
+
+    // Dirty incoming, clean existing → incoming wins.
+    const dirtyIncoming = registry.getOrCreate(monaco, "old-a", "edited", "plaintext") as any;
+    dirtyIncoming.__edit();
+    const cleanExisting = registry.getOrCreate(monaco, "new-a", "disk", "plaintext") as any;
+    registry.rekey("old-a", "new-a");
+    expect(cleanExisting.dispose).toHaveBeenCalledTimes(1);
+    expect(registry.getValue("new-a")).toBe("edited");
+    expect(registry.isDirty("new-a")).toBe(true);
+
+    // Dirty existing → existing wins, incoming disposed.
+    const cleanIncoming = registry.getOrCreate(monaco, "old-b", "stale", "plaintext") as any;
+    const dirtyExisting = registry.getOrCreate(monaco, "new-b", "kept edit", "plaintext") as any;
+    dirtyExisting.__edit();
+    registry.rekey("old-b", "new-b");
+    expect(cleanIncoming.dispose).toHaveBeenCalledTimes(1);
+    expect(dirtyExisting.dispose).not.toHaveBeenCalled();
+    expect(registry.getValue("new-b")).toBe("kept edit");
+    expect(registry.has("old-b")).toBe(false);
+  });
+
+  it("rekey is a no-op for identical or unknown keys", () => {
+    const { monaco } = createFakeMonaco();
+    const registry = createMonacoModelRegistry();
+
+    const model = registry.getOrCreate(monaco, "a", "x", "plaintext") as any;
+    registry.rekey("a", "a");
+    registry.rekey("missing", "b");
+
+    expect(registry.has("a")).toBe(true);
+    expect(registry.has("b")).toBe(false);
+    expect(registry.getValue("a")).toBe("x");
+    expect(model.dispose).not.toHaveBeenCalled();
+  });
+
   it("recreates a model whose underlying instance was disposed externally", () => {
     const { monaco, createdCount } = createFakeMonaco();
     const registry = createMonacoModelRegistry();

apps/desktop/src/renderer/components/files/monacoModelRegistry.ts

@@ -108,6 +108,34 @@ export function createMonacoModelRegistry() {
       return Boolean(entry && !entry.model.isDisposed());
     },
 
+    /**
+     * Move a cached model to a new key (tab-id remap). The live buffer, undo
+     * stack, and dirty baseline follow the new key. When the new key already
+     * holds a live model — the remap collision case, where the stale tab was
+     * dropped in favor of an authoritative one — the old entry is disposed.
+     */
+    rekey(oldKey: string, newKey: string): void {
+      if (oldKey === newKey) return;
+      const entry = models.get(oldKey);
+      if (!entry) return;
+      models.delete(oldKey);
+      const existing = models.get(newKey);
+      if (existing && !existing.model.isDisposed()) {
+        // Collision: keep whichever buffer holds unsaved edits.
+        const entryDirty = !entry.model.isDisposed()
+          && entry.model.getAlternativeVersionId() !== entry.baseVersionId;
+        const existingDirty = existing.model.getAlternativeVersionId() !== existing.baseVersionId;
+        if (entryDirty && !existingDirty) {
+          safeDispose(existing.model);
+          models.set(newKey, entry);
+        } else {
+          safeDispose(entry.model);
+        }
+        return;
+      }
+      models.set(newKey, entry);
+    },
+
     dispose(modelKey: string): void {
       const entry = models.get(modelKey);
       if (!entry) return;

apps/desktop/src/renderer/components/files/v2/EditorGroup.test.tsx

@@ -57,7 +57,6 @@ const baseProps: EditorGroupProps = {
     workspaceId: "workspace-1",
     rootPath: "/repo",
     laneId: "lane-1",
-    canEdit: true,
     canRevealInFinder: true,
   }),
   theme: "dark",
@@ -107,6 +106,7 @@ describe("EditorGroup", () => {
     render(<EditorGroup {...baseProps} />);
     expect(screen.getByRole("tab", { name: /file\.ts/i })).toBeTruthy();
     expect(screen.getByTestId("viewer-button")).toBeTruthy();
+    expect(screen.getByTitle("Save (⌘S)")).toBeTruthy();
   });
 
   it("marks the visible fallback tab active when lane scope hides the stored active tab", () => {

apps/desktop/src/renderer/components/files/v2/EditorGroup.tsx

@@ -128,7 +128,7 @@ export function EditorGroup(props: EditorGroupProps) {
       });
       return;
     }
-    if (!activeContext.canEdit || activeTab.viewerKind !== "code") return;
+    if (activeTab.viewerKind !== "code") return;
     const text = registry.getValue(activeTab.id);
     if (text == null) return;
     void window.ade.files
@@ -143,7 +143,7 @@ export function EditorGroup(props: EditorGroupProps) {
   }, [activeContext, activeTab, onDirtyChange, onError, registry]);
 
   useEffect(() => {
-    if (!props.isActiveGroup || !activeTab || !activeContext?.canEdit || activeTab.viewerKind !== "code") return;
+    if (!props.isActiveGroup || !activeTab || activeTab.viewerKind !== "code") return;
     const onKey = (event: KeyboardEvent) => {
       const mod = event.metaKey || event.ctrlKey;
       if (!mod || event.shiftKey || event.altKey || (event.key !== "s" && event.key !== "S")) return;
@@ -156,7 +156,7 @@ export function EditorGroup(props: EditorGroupProps) {
     };
     window.addEventListener("keydown", onKey);
     return () => window.removeEventListener("keydown", onKey);
-  }, [activeContext?.canEdit, activeTab, props.isActiveGroup, saveActive]);
+  }, [activeTab, props.isActiveGroup, saveActive]);
 
   return (
     <div
@@ -215,7 +215,7 @@ export function EditorGroup(props: EditorGroupProps) {
                 })}
               </div>
             ) : null}
-            {activeTab.viewerKind === "code" && activeContext.canEdit ? (
+            {activeTab.viewerKind === "code" ? (
               <button type="button" onClick={saveActive} title="Save (⌘S)" className="rounded p-1 hover:bg-white/5" style={{ color: COLORS.textMuted }}>
                 <FloppyDisk size={14} />
               </button>
@@ -235,7 +235,6 @@ export function EditorGroup(props: EditorGroupProps) {
             workspaceId={activeContext.workspaceId}
             rootPath={activeContext.rootPath}
             tab={activeTab}
-            canEdit={activeContext.canEdit}
             theme={props.theme}
             registry={props.registry}
             reloadToken={props.reloadTokensByTabId[activeTab.id] ?? 0}

apps/desktop/src/renderer/components/files/v2/EditorGroups.tsx

@@ -15,7 +15,6 @@ export type TabWorkspaceContext = {
   workspaceId: string;
   rootPath: string;
   laneId: string | null;
-  canEdit: boolean;
   canRevealInFinder: boolean;
 };