ship: iteration 3 — address coderabbit + greptile review comments

Addresses 20 actionable comments across TS (3) and iOS Swift (17):
- ade-cli/adeRpcServer: decouple auto-title meta from goal
- ade-cli/syncRemoteCommandService: validate confidenceThreshold 0..1
- desktop/kvDb: PK arity check runs before byte-typed PK accept
- iOS Database: empty title skips title only, not whole update
- iOS SyncService: contain activeProjectId remap; scope cached model catalog; fast-fail sendTestPush offline; indentation normalize
- iOS Views Cto: clear stale budget/linearStatus/coreMemory on refresh failure
- iOS Views Lanes: don't disable Push during sync-status loading
- iOS Views PRs: neutral/skipped checks counted; 44pt touch targets; case-sensitive branch match; validate linkedLaneId against availableLanes
- iOS Views Work: one-write terminal submit; don't skip idle transcript reconcile
- iOS Tests: explicit SyncService.shared binding in deep-link test

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: arul28

apps/ade-cli/src/adeRpcServer.ts

@@ -5251,15 +5251,17 @@ async function runTool(args: {
       }
     }
 
-    if (initialInputMeta.goal) {
+    const autoTitleApplied = Boolean(initialInputMeta.promptTitle) && title === initialInputMeta.promptTitle;
+    if (initialInputMeta.goal || autoTitleApplied) {
       const session = runtime.sessionService.get(created.sessionId) as TerminalSessionSummary | null;
-      runtime.sessionService.updateMeta({
+      const metaPatch: Parameters<typeof runtime.sessionService.updateMeta>[0] = {
         sessionId: created.sessionId,
-        ...(session?.goal?.trim().length ? {} : { goal: initialInputMeta.goal }),
-        ...(initialInputMeta.promptTitle && title === initialInputMeta.promptTitle
-          ? { title: initialInputMeta.promptTitle, manuallyNamed: false }
-          : {}),
-      });
+        ...(initialInputMeta.goal && !session?.goal?.trim().length ? { goal: initialInputMeta.goal } : {}),
+        ...(autoTitleApplied ? { title: initialInputMeta.promptTitle!, manuallyNamed: false } : {}),
+      };
+      if (metaPatch.goal !== undefined || metaPatch.title !== undefined || metaPatch.manuallyNamed !== undefined) {
+        runtime.sessionService.updateMeta(metaPatch);
+      }
     }
 
     const session = runtime.sessionService.get(created.sessionId) as TerminalSessionSummary | null;

apps/ade-cli/src/services/sync/syncRemoteCommandService.ts

@@ -233,6 +233,13 @@ function asOptionalNumber(value: unknown): number | undefined {
   return typeof value === "number" && Number.isFinite(value) ? value : undefined;
 }
 
+function asConfidenceThreshold(value: unknown): number | undefined {
+  const numeric = asOptionalNumber(value);
+  if (numeric == null) return undefined;
+  if (numeric < 0 || numeric > 1) return undefined;
+  return numeric;
+}
+
 function asStringArray(value: unknown): string[] {
   if (!Array.isArray(value)) return [];
   return value.map((entry) => asTrimmedString(entry)).filter((entry): entry is string => Boolean(entry));
@@ -1274,7 +1281,7 @@ function parseLandQueueNextArgs(value: Record<string, unknown>): LandQueueNextAr
     method,
     ...(typeof value.archiveLane === "boolean" ? { archiveLane: value.archiveLane } : {}),
     ...(typeof value.autoResolve === "boolean" ? { autoResolve: value.autoResolve } : {}),
-    ...(asOptionalNumber(value.confidenceThreshold) != null ? { confidenceThreshold: asOptionalNumber(value.confidenceThreshold)! } : {}),
+    ...(asConfidenceThreshold(value.confidenceThreshold) != null ? { confidenceThreshold: asConfidenceThreshold(value.confidenceThreshold)! } : {}),
   };
 }
 
@@ -1288,7 +1295,7 @@ function parseStartQueueAutomationArgs(value: Record<string, unknown>): StartQue
   const resolverModel = asTrimmedString(value.resolverModel);
   const reasoningEffort = asTrimmedString(value.reasoningEffort);
   const permissionMode = asTrimmedString(value.permissionMode);
-  const confidenceThreshold = asOptionalNumber(value.confidenceThreshold);
+  const confidenceThreshold = asConfidenceThreshold(value.confidenceThreshold);
   const originLabel = asTrimmedString(value.originLabel);
   return {
     groupId: requireString(value.groupId, "prs.startQueueAutomation requires groupId."),
@@ -1330,7 +1337,7 @@ function parseResumeQueueAutomationArgs(value: Record<string, unknown>): ResumeQ
     ...(typeof value.archiveLane === "boolean" ? { archiveLane: value.archiveLane } : {}),
     ...(typeof value.autoResolve === "boolean" ? { autoResolve: value.autoResolve } : {}),
     ...(typeof value.ciGating === "boolean" ? { ciGating: value.ciGating } : {}),
-    ...(asOptionalNumber(value.confidenceThreshold) != null ? { confidenceThreshold: asOptionalNumber(value.confidenceThreshold)! } : {}),
+    ...(asConfidenceThreshold(value.confidenceThreshold) != null ? { confidenceThreshold: asConfidenceThreshold(value.confidenceThreshold)! } : {}),
     ...(asTrimmedString(value.originLabel) ? { originLabel: asTrimmedString(value.originLabel)! } : {}),
   };
 }

apps/desktop/src/main/services/state/kvDb.ts

@@ -736,26 +736,28 @@ function packedCrsqlPrimaryKey(value: SyncScalar): SyncScalar | null {
 }
 
 function normalizeIncomingCrsqlChange(db: DatabaseSyncType, change: CrsqlChangeRow): CrsqlChangeRow {
-  if (isSyncScalarBytes(change.pk)) {
-    const packedPk = packedCrsqlPrimaryKey(change.pk);
-    if (packedPk) return change;
-    throw new Error(`Unsupported incoming CRSQL primary key for ${change.table}.${change.cid}: invalid packed key.`);
-  }
-
   const tableInfo = allRows<{ pk: number }>(
     db,
     `pragma table_info('${change.table.replace(/'/g, "''")}')`
   );
   const primaryKeyColumns = tableInfo.filter((column) => Number(column.pk) > 0);
-  if (primaryKeyColumns.length === 1) {
+  if (primaryKeyColumns.length !== 1) {
+    const shape = primaryKeyColumns.length === 0
+      ? "no primary key"
+      : `${primaryKeyColumns.length} primary key columns`;
+    throw new Error(`Unsupported incoming CRSQL primary key for ${change.table}.${change.cid}: ${shape}.`);
+  }
+
+  if (isSyncScalarBytes(change.pk)) {
     const packedPk = packedCrsqlPrimaryKey(change.pk);
-    if (packedPk) return { ...change, pk: packedPk };
+    if (packedPk) return change;
+    throw new Error(`Unsupported incoming CRSQL primary key for ${change.table}.${change.cid}: invalid packed key.`);
   }
 
-  const shape = primaryKeyColumns.length === 0
-    ? "no primary key"
-    : `${primaryKeyColumns.length} primary key columns`;
-  throw new Error(`Unsupported incoming CRSQL primary key for ${change.table}.${change.cid}: ${shape}.`);
+  const packedPk = packedCrsqlPrimaryKey(change.pk);
+  if (packedPk) return { ...change, pk: packedPk };
+
+  throw new Error(`Unsupported incoming CRSQL primary key for ${change.table}.${change.cid}: unsupported scalar shape.`);
 }
 
 function rebuildUnifiedMemoriesFts(db: DatabaseSyncType): void {

apps/ios/ADE/Services/Database.swift

@@ -1568,10 +1568,13 @@ final class DatabaseService {
 
     if let title {
       let trimmedTitle = title.trimmingCharacters(in: .whitespacesAndNewlines)
-      guard !trimmedTitle.isEmpty else { return }
-      assignments.append("title = ?")
-      binders.append { statement, index in
-        try self.bindText(trimmedTitle, to: statement, index: index)
+      // Skip just the title write when it's blank — other field updates
+      // (pinned, manually_named) must still apply on the same call.
+      if !trimmedTitle.isEmpty {
+        assignments.append("title = ?")
+        binders.append { statement, index in
+          try self.bindText(trimmedTitle, to: statement, index: index)
+        }
       }
     }
 

apps/ios/ADE/Services/SyncService.swift

@@ -1652,21 +1652,28 @@ final class SyncService: ObservableObject {
 
   private func normalizeActiveProjectSelection(allowSingleProjectFallback: Bool) {
     let projectIds = Set(projects.map(\.id))
+
+    // Keep a still-valid active project before considering any remote-catalog
+    // remap. If the cached row is in `projects`, we must not override it with
+    // a different id from `remoteProjectCatalog` — `refreshProjectCatalog`
+    // intentionally preserves the existing selection when it keeps a cached
+    // row for the same root.
+    if let activeProjectId, projectIds.contains(activeProjectId) {
+      database.setActiveProjectId(activeProjectId)
+      return
+    }
+
     if let activeProjectId,
        let activeProjectRootPath,
        let remoteProject = deduplicatedRemoteProjectCatalog().first(where: { project in
          project.id != activeProjectId
            && normalizedProjectRoot(project.rootPath) == activeProjectRootPath
-       }) {
+       }),
+       projectIds.contains(remoteProject.id) {
       setActiveProjectId(remoteProject.id, rootPath: remoteProject.rootPath)
       return
     }
 
-    if let activeProjectId, projectIds.contains(activeProjectId) {
-      database.setActiveProjectId(activeProjectId)
-      return
-    }
-
     if let activeProjectId,
        let activeProjectRootPath,
        let matchingProject = projects.first(where: { normalizedProjectRoot($0.rootPath) == activeProjectRootPath }) {
@@ -3751,7 +3758,25 @@ final class SyncService: ObservableObject {
 
   @MainActor
   func cachedChatModelCatalog() -> AgentChatModelCatalog? {
-    guard let cached = chatModelCatalogCache.values.sorted(by: { $0.fetchedAt > $1.fetchedAt }).first else { return nil }
+    // Scope the fallback lookup to the current host/project. `chatModelsCacheKey`
+    // mixes host + project root into every key it writes, so returning the newest
+    // entry from *any* cache row could leak a different host's catalog into the
+    // active session. Match the key prefix instead and only consider entries that
+    // belong to the same host/project scope.
+    let scopePrefix = chatModelsCacheKey(provider: "")
+    let scopedEntries = chatModelCatalogCache
+      .filter { key, _ in
+        // Strip the provider component from the stored key and compare scopes.
+        // Both `scopePrefix` and the stored key use `\u{1f}` separators between
+        // provider, host, and project root; everything after the first separator
+        // is the host+project portion we care about.
+        guard let sepIndex = scopePrefix.firstIndex(of: "\u{1f}"),
+              let storedSepIndex = key.firstIndex(of: "\u{1f}")
+        else { return false }
+        return scopePrefix[sepIndex...] == key[storedSepIndex...]
+      }
+      .values
+    guard let cached = scopedEntries.sorted(by: { $0.fetchedAt > $1.fetchedAt }).first else { return nil }
     guard Date().timeIntervalSince(cached.fetchedAt) < chatModelsCacheTTL else { return nil }
     return cached.catalog
   }
@@ -7383,6 +7408,12 @@ extension SyncService {
   /// which token kind (alert vs activity) to target based on what it last saw
   /// from us.
   func sendTestPush() async -> SyncSendTestPushResult {
+    // Fail fast when the socket is offline. Without this guard, `sendEnvelope`
+    // silently drops the frame and `awaitResponse` would sit until timeout,
+    // making the test-push button look unresponsive.
+    guard canSendLiveRequests() else {
+      return SyncSendTestPushResult(ok: false, message: "The paired machine is offline.")
+    }
     let requestId = makeRequestId()
     do {
       let raw = try await awaitResponse(
@@ -7609,15 +7640,15 @@ extension SyncService {
         laneName: session.laneName.isEmpty ? nil : session.laneName,
         title: session.title.isEmpty ? session.goal : session.title,
         status: isFailedStatus ? "failed" : (isRunningRuntime ? "running" : (isIdleRuntime ? "idle" : status)),
-	        awaitingInput: isAwaiting,
-	        lastActivityAt: lastActivity,
-	        elapsedSeconds: elapsed,
-	        preview: session.lastOutputPreview,
+        awaitingInput: isAwaiting,
+        lastActivityAt: lastActivity,
+        elapsedSeconds: elapsed,
+        preview: session.lastOutputPreview,
         pendingInputItemId: isAwaiting ? (session.pendingInputItemId ?? pendingInputItemIdForSnapshot(sessionId: session.id)) : nil,
-	        progress: nil,
-	        phase: nil,
-	        toolCalls: 0
-	      )
+        progress: nil,
+        phase: nil,
+        toolCalls: 0
+      )
 
       allAgents.append(snap)
 
@@ -7672,17 +7703,17 @@ extension SyncService {
       )
     }
 
-	    scheduleWorkspaceSnapshotWrite()
-	  }
+    scheduleWorkspaceSnapshotWrite()
+  }
 
-	  private func pendingInputItemIdForSnapshot(sessionId: String) -> String? {
-	    let events = chatEventEnvelopesBySession[sessionId] ?? []
-	    guard !events.isEmpty else { return nil }
-	    let transcript = makeWorkChatTranscript(from: events)
-	    return derivePendingWorkInputs(from: transcript).last?.itemId
-	  }
+  private func pendingInputItemIdForSnapshot(sessionId: String) -> String? {
+    let events = chatEventEnvelopesBySession[sessionId] ?? []
+    guard !events.isEmpty else { return nil }
+    let transcript = makeWorkChatTranscript(from: events)
+    return derivePendingWorkInputs(from: transcript).last?.itemId
+  }
 
-	  /// Debounced writer for the App Group `WorkspaceSnapshot`. Bounces for 2s
+  /// Debounced writer for the App Group `WorkspaceSnapshot`. Bounces for 2s
   /// so bursty sync traffic collapses into a single widget-timeline reload.
   private func scheduleWorkspaceSnapshotWrite() {
     snapshotDebouncerTask?.cancel()

apps/ios/ADE/Views/Cto/CtoSettingsScreen.swift

@@ -348,9 +348,15 @@ struct CtoSettingsScreen: View {
 
     if let value = try? await syncService.fetchCtoBudget() {
       self.budget = value
+    } else {
+      // Drop stale budget rather than render outdated numbers under a fresh load.
+      self.budget = nil
     }
     if let value = try? await syncService.fetchLinearConnectionStatus() {
       self.linearStatus = value
+    } else {
+      // Same reasoning — a failed refresh should not preserve the previous integration state.
+      self.linearStatus = nil
     }
   }
 }

apps/ios/ADE/Views/Cto/CtoWorkerDetailScreen.swift

@@ -531,6 +531,9 @@ struct CtoWorkerDetailScreen: View {
       coreMemory = mem
       memoryLoadError = nil
     case .failure(let err):
+      // Clear the previous snapshot so the unavailable error renders alone instead of
+      // showing stale memory content under a fresh failure banner.
+      coreMemory = nil
       memoryLoadError = err.localizedDescription
     }
     if case .success(let fetched) = runsResult { runs = fetched }

apps/ios/ADE/Views/Lanes/LaneDetailContentSections.swift

@@ -70,7 +70,10 @@ struct LaneDetailHeaderCard<Footer: View>: View {
     let hasUpstream = syncStatus?.hasUpstream ?? true
     let diverged = syncStatus?.diverged ?? false
     let shouldPull = hasUpstream && remoteBehind > 0 && !diverged
-    let shouldPush = !hasUpstream || remoteAhead > 0
+    // While detail is still loading (syncStatus nil) we don't know the ahead count yet, so
+    // keep Push enabled instead of disabling an already-ahead lane until the fetch lands.
+    let syncStatusLoaded = syncStatus != nil
+    let shouldPush = !syncStatusLoaded || !hasUpstream || remoteAhead > 0
 
     HStack(spacing: 8) {
       Image(systemName: "arrow.triangle.2.circlepath")

apps/ios/ADE/Views/PRs/PrDetailChecksTab.swift

@@ -14,7 +14,9 @@ func prChecksSummaryStats(checks: [PrCheck], overallChecksStatus: String?) -> Pr
     case .success: pass += 1
     case .failure: fail += 1
     case .pending: pending += 1
-    case .neutral: break
+    // Neutral/skipped checks are non-failing outcomes; bucket them with pass so the
+    // stat strip's total always equals the sum of pass + fail + pending.
+    case .neutral: pass += 1
     }
   }
   if !checks.isEmpty {

apps/ios/ADE/Views/PRs/PrDetailFilesTab.swift

@@ -397,6 +397,8 @@ private struct PrFileRowLabel: View {
 
   private func prFileInlineAction(symbol: String, label: String, action: @escaping () -> Void) -> some View {
     Button(action: action) {
+      // Visual chip stays compact (24pt circle) but the outer frame expands the tap target
+      // to Apple's HIG-minimum 44pt so these inline actions don't punish thumb taps in the row.
       ZStack {
         Circle()
           .fill(Color.white.opacity(0.06))
@@ -407,6 +409,8 @@ private struct PrFileRowLabel: View {
           .foregroundStyle(ADEColor.textSecondary)
       }
       .frame(width: 24, height: 24)
+      .frame(width: 44, height: 44)
+      .contentShape(Rectangle())
     }
     .buttonStyle(.plain)
     .accessibilityLabel(label)