|
| 1 | +import fs from "node:fs"; |
| 2 | +import net from "node:net"; |
| 3 | +import os from "node:os"; |
| 4 | +import path from "node:path"; |
| 5 | +import { afterEach, beforeEach, describe, expect, it } from "vitest"; |
| 6 | + |
| 7 | +import { |
| 8 | + startJsonRpcServer, |
| 9 | + type JsonRpcRequest, |
| 10 | + type JsonRpcTransport, |
| 11 | +} from "../../jsonrpc"; |
| 12 | +import { createBuiltInBrowserDesktopBridgeClient } from "./desktopBridgeClient"; |
| 13 | + |
| 14 | +function silentLogger() { |
| 15 | + return { |
| 16 | + debug: () => {}, |
| 17 | + info: () => {}, |
| 18 | + warn: () => {}, |
| 19 | + error: () => {}, |
| 20 | + }; |
| 21 | +} |
| 22 | + |
| 23 | +type ServerHandle = { |
| 24 | + socketPath: string; |
| 25 | + close: () => Promise<void>; |
| 26 | +}; |
| 27 | + |
| 28 | +async function startBridgeServer( |
| 29 | + handler: (request: JsonRpcRequest) => Promise<unknown>, |
| 30 | +): Promise<ServerHandle> { |
| 31 | + const socketPath = path.join( |
| 32 | + fs.mkdtempSync(path.join(os.tmpdir(), "ade-bridge-test-")), |
| 33 | + "bridge.sock", |
| 34 | + ); |
| 35 | + const stopHandles = new Set<() => void>(); |
| 36 | + const sockets = new Set<net.Socket>(); |
| 37 | + const server = net.createServer((conn) => { |
| 38 | + sockets.add(conn); |
| 39 | + const transport: JsonRpcTransport = { |
| 40 | + onData: (callback) => conn.on("data", callback), |
| 41 | + write: (data) => conn.write(data), |
| 42 | + close: () => { |
| 43 | + if (!conn.destroyed) conn.destroy(); |
| 44 | + }, |
| 45 | + }; |
| 46 | + const stop = startJsonRpcServer(handler, transport, { nonFatal: true }); |
| 47 | + stopHandles.add(stop); |
| 48 | + conn.on("close", () => { |
| 49 | + sockets.delete(conn); |
| 50 | + stopHandles.delete(stop); |
| 51 | + stop(); |
| 52 | + }); |
| 53 | + conn.on("error", () => {}); |
| 54 | + }); |
| 55 | + await new Promise<void>((resolve, reject) => { |
| 56 | + server.once("error", reject); |
| 57 | + server.listen(socketPath, () => resolve()); |
| 58 | + }); |
| 59 | + return { |
| 60 | + socketPath, |
| 61 | + close: () => |
| 62 | + new Promise<void>((resolve) => { |
| 63 | + for (const s of sockets) { |
| 64 | + try { |
| 65 | + s.destroy(); |
| 66 | + } catch { |
| 67 | + // ignore |
| 68 | + } |
| 69 | + } |
| 70 | + for (const stop of stopHandles) { |
| 71 | + try { |
| 72 | + stop(); |
| 73 | + } catch { |
| 74 | + // ignore |
| 75 | + } |
| 76 | + } |
| 77 | + server.close(() => { |
| 78 | + try { |
| 79 | + fs.unlinkSync(socketPath); |
| 80 | + } catch { |
| 81 | + // ignore |
| 82 | + } |
| 83 | + resolve(); |
| 84 | + }); |
| 85 | + }), |
| 86 | + }; |
| 87 | +} |
| 88 | + |
| 89 | +describe("createBuiltInBrowserDesktopBridgeClient", () => { |
| 90 | + let server: ServerHandle | null = null; |
| 91 | + |
| 92 | + afterEach(async () => { |
| 93 | + if (server) { |
| 94 | + await server.close(); |
| 95 | + server = null; |
| 96 | + } |
| 97 | + }); |
| 98 | + |
| 99 | + it("forwards method + params and resolves the JSON-RPC response", async () => { |
| 100 | + const seen: JsonRpcRequest[] = []; |
| 101 | + server = await startBridgeServer(async (request) => { |
| 102 | + seen.push(request); |
| 103 | + if (request.method === "built_in_browser.navigate") { |
| 104 | + return { ok: true, url: (request.params as { url: string }).url }; |
| 105 | + } |
| 106 | + throw new Error(`unexpected method: ${request.method}`); |
| 107 | + }); |
| 108 | + const client = createBuiltInBrowserDesktopBridgeClient({ |
| 109 | + socketPath: server.socketPath, |
| 110 | + logger: silentLogger(), |
| 111 | + }); |
| 112 | + const result = await client.navigate({ url: "https://example.com" }); |
| 113 | + expect(result).toEqual({ ok: true, url: "https://example.com" }); |
| 114 | + expect(seen).toHaveLength(1); |
| 115 | + expect(seen[0]?.method).toBe("built_in_browser.navigate"); |
| 116 | + expect(seen[0]?.params).toEqual({ url: "https://example.com" }); |
| 117 | + client.dispose(); |
| 118 | + }); |
| 119 | + |
| 120 | + it("dispatches no-arg methods without params field", async () => { |
| 121 | + const recorded: JsonRpcRequest[] = []; |
| 122 | + server = await startBridgeServer(async (request) => { |
| 123 | + recorded.push(request); |
| 124 | + return { tabs: [] }; |
| 125 | + }); |
| 126 | + const client = createBuiltInBrowserDesktopBridgeClient({ |
| 127 | + socketPath: server.socketPath, |
| 128 | + logger: silentLogger(), |
| 129 | + }); |
| 130 | + await client.getStatus(); |
| 131 | + expect(recorded[0]?.method).toBe("built_in_browser.getStatus"); |
| 132 | + expect(recorded[0]?.params).toBeUndefined(); |
| 133 | + client.dispose(); |
| 134 | + }); |
| 135 | + |
| 136 | + it("surfaces a clear error when the bridge socket does not exist", async () => { |
| 137 | + const missingPath = path.join( |
| 138 | + fs.mkdtempSync(path.join(os.tmpdir(), "ade-bridge-test-missing-")), |
| 139 | + "absent.sock", |
| 140 | + ); |
| 141 | + const client = createBuiltInBrowserDesktopBridgeClient({ |
| 142 | + socketPath: missingPath, |
| 143 | + logger: silentLogger(), |
| 144 | + }); |
| 145 | + await expect(client.getStatus()).rejects.toThrow( |
| 146 | + /Desktop browser bridge not running/, |
| 147 | + ); |
| 148 | + client.dispose(); |
| 149 | + }); |
| 150 | + |
| 151 | + it("propagates JSON-RPC server errors", async () => { |
| 152 | + server = await startBridgeServer(async () => { |
| 153 | + throw new Error("Browser pane is offline"); |
| 154 | + }); |
| 155 | + const client = createBuiltInBrowserDesktopBridgeClient({ |
| 156 | + socketPath: server.socketPath, |
| 157 | + logger: silentLogger(), |
| 158 | + }); |
| 159 | + await expect(client.getStatus()).rejects.toThrow(/Browser pane is offline/); |
| 160 | + client.dispose(); |
| 161 | + }); |
| 162 | + |
| 163 | + it("reconnects after a transient failure on the next call", async () => { |
| 164 | + let callCount = 0; |
| 165 | + server = await startBridgeServer(async () => { |
| 166 | + callCount += 1; |
| 167 | + if (callCount === 1) throw new Error("temporary"); |
| 168 | + return { ok: true }; |
| 169 | + }); |
| 170 | + const client = createBuiltInBrowserDesktopBridgeClient({ |
| 171 | + socketPath: server.socketPath, |
| 172 | + logger: silentLogger(), |
| 173 | + }); |
| 174 | + await expect(client.getStatus()).rejects.toThrow(/temporary/); |
| 175 | + const result = await client.getStatus(); |
| 176 | + expect(result).toEqual({ ok: true }); |
| 177 | + expect(callCount).toBe(2); |
| 178 | + client.dispose(); |
| 179 | + }); |
| 180 | +}); |
0 commit comments