Skip to content

Commit ba459d2

Browse files
arul28claude
andcommitted
Fix CI failures: tests, bootstrap SQL, type error
- App.test.tsx: update loading text assertion to match new splash screen - laneService.test.ts: insert mission rows before FK references - conflictService.test.ts: adjust assertion for lane_base/pr_target dedup - kvDb bootstrap SQL: regenerate iOS artifact for resume_command column - TerminalsPage.tsx: remove unused SANS_FONT reference Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d0c33f0 commit ba459d2

5 files changed

Lines changed: 38 additions & 19 deletions

File tree

apps/desktop/src/main/services/conflicts/conflictService.test.ts

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -940,23 +940,16 @@ describe("conflictService conflict context integrity", () => {
940940
});
941941

942942
const needs = await service.scanRebaseNeeds();
943-
expect(needs).toHaveLength(2);
944-
expect(needs).toEqual(
945-
expect.arrayContaining([
946-
expect.objectContaining({
947-
laneId: "lane-2",
948-
kind: "lane_base",
949-
baseBranch: "main",
950-
groupContext: "Queue A",
951-
}),
952-
expect.objectContaining({
953-
laneId: "lane-2",
954-
kind: "pr_target",
955-
baseBranch: "main",
956-
prId: "pr-2",
957-
groupContext: "Queue A",
958-
}),
959-
]),
943+
// Dedup keeps only the pr_target need when both lane_base and pr_target exist for the same lane
944+
expect(needs).toHaveLength(1);
945+
expect(needs[0]).toEqual(
946+
expect.objectContaining({
947+
laneId: "lane-2",
948+
kind: "pr_target",
949+
baseBranch: "main",
950+
prId: "pr-2",
951+
groupContext: "Queue A",
952+
}),
960953
);
961954
expect(needs.every((need) => need.behindBy > 0)).toBe(true);
962955

apps/desktop/src/main/services/lanes/laneService.test.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1804,6 +1804,14 @@ describe("laneService missionId and laneRole", () => {
18041804
throw new Error(`Unexpected git call: ${args.join(" ")}`);
18051805
});
18061806

1807+
// Insert a mission row so the FK on lanes.mission_id is satisfied
1808+
const now = "2026-03-11T12:00:00.000Z";
1809+
db.run(
1810+
`insert into missions(id, project_id, title, prompt, status, priority, execution_mode, created_at, updated_at)
1811+
values (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
1812+
["mission-abc", "proj-child-mission", "Test mission", "do something", "pending", "normal", "local", now, now],
1813+
);
1814+
18071815
const service = createLaneService({
18081816
db,
18091817
projectRoot: repoRoot,
@@ -1974,6 +1982,14 @@ describe("laneService missionId and laneRole", () => {
19741982
throw new Error(`Unexpected git call: ${args.join(" ")}`);
19751983
});
19761984

1985+
// Insert a mission row so the FK on lanes.mission_id is satisfied
1986+
const now = "2026-03-11T12:00:00.000Z";
1987+
db.run(
1988+
`insert into missions(id, project_id, title, prompt, status, priority, execution_mode, created_at, updated_at)
1989+
values (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
1990+
["mission-xyz", "proj-set-ownership", "Test mission", "do something", "pending", "normal", "local", now, now],
1991+
);
1992+
19771993
const service = createLaneService({
19781994
db,
19791995
projectRoot: repoRoot,
@@ -2004,6 +2020,14 @@ describe("laneService missionId and laneRole", () => {
20042020
const db = await openKvDb(path.join(repoRoot, "kv.sqlite"), createLogger());
20052021
await seedProjectAndStack(db, { projectId: "proj-clear-ownership", repoRoot });
20062022

2023+
// Insert a mission row so the FK on lanes.mission_id is satisfied
2024+
const now = "2026-03-11T12:00:00.000Z";
2025+
db.run(
2026+
`insert into missions(id, project_id, title, prompt, status, priority, execution_mode, created_at, updated_at)
2027+
values (?, ?, ?, ?, ?, ?, ?, ?, ?)`,
2028+
["mission-existing", "proj-clear-ownership", "Test mission", "do something", "pending", "normal", "local", now, now],
2029+
);
2030+
20072031
// Manually set mission_id/lane_role in DB first
20082032
db.run("update lanes set mission_id = ?, lane_role = ? where id = ?", ["mission-existing", "worker", "lane-parent"]);
20092033

apps/desktop/src/renderer/components/app/App.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ describe("RequireProject", () => {
5555
</MemoryRouter>,
5656
);
5757

58-
expect(screen.getByText("Loading...")).toBeTruthy();
58+
expect(screen.getByText("Starting ADE")).toBeTruthy();
5959
expect(screen.queryByText("Run page")).toBeNull();
6060
});
6161

apps/desktop/src/renderer/components/terminals/TerminalsPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export function TerminalsPage() {
184184
);
185185

186186
return (
187-
<div className="flex h-full min-w-0 flex-col" style={{ background: "var(--color-bg)", fontFamily: SANS_FONT }}>
187+
<div className="flex h-full min-w-0 flex-col" style={{ background: "var(--color-bg)" }}>
188188
{renameError ? (
189189
<div
190190
className="shrink-0 border-b border-red-500/25 px-4 py-2 text-[12px] text-red-300/95"

apps/ios/ADE/Resources/DatabaseBootstrap.sql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ create index if not exists idx_terminal_sessions_started_at on terminal_sessions
100100

101101
create index if not exists idx_terminal_sessions_lane_started_at on terminal_sessions(lane_id, started_at desc);
102102

103+
alter table terminal_sessions add column resume_command text;
104+
103105
create table if not exists process_definitions (
104106
id text primary key,
105107
project_id text not null,

0 commit comments

Comments
 (0)