Skip to content

Commit dbb20b3

Browse files
committed
ship: iteration 1 - remove legacy Files tab
1 parent ddf1a83 commit dbb20b3

18 files changed

Lines changed: 226 additions & 5125 deletions

apps/desktop/src/renderer/components/app/App.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ const preloadLanesPage = lanesRoute.preload;
5454
const filesRoute = createPreloadableRoute<{ active?: boolean }>(() =>
5555
import("../files/FilesTab").then((m) => ({ default: m.FilesTab }))
5656
);
57-
const FilesPage = filesRoute.Component;
58-
const preloadFilesPage = filesRoute.preload;
57+
const FilesTab = filesRoute.Component;
58+
const preloadFilesTab = filesRoute.preload;
5959
const workRoute = createPreloadableRoute<{ active?: boolean }>(() =>
6060
import("../terminals/TerminalsPage").then((m) => ({ default: m.TerminalsPage }))
6161
);
@@ -425,7 +425,7 @@ function ProjectRouteContent({ active, route }: { active: boolean; route: string
425425
<Route path="/glossary" element={<PageErrorBoundary><GlossaryPage /></PageErrorBoundary>} />
426426
<Route path="/files" element={
427427
<PageErrorBoundary>
428-
<React.Suspense fallback={LazyFallback}>{React.createElement(FilesPage as React.ComponentType<{ active?: boolean }>, routeProps)}</React.Suspense>
428+
<React.Suspense fallback={LazyFallback}>{React.createElement(FilesTab as React.ComponentType<{ active?: boolean }>, routeProps)}</React.Suspense>
429429
</PageErrorBoundary>
430430
} />
431431
<Route path="/graph" element={
@@ -614,7 +614,7 @@ function ProjectTabHost() {
614614
const preload = () => {
615615
void preloadTerminalsPage().catch(() => undefined);
616616
void preloadLanesPage().catch(() => undefined);
617-
void preloadFilesPage().catch(() => undefined);
617+
void preloadFilesTab().catch(() => undefined);
618618
void preloadCtoPage().catch(() => undefined);
619619
};
620620
const idleWindow = window as Window & {

apps/desktop/src/renderer/components/app/App.workKeepAlive.test.tsx

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -117,23 +117,6 @@ vi.mock("../terminals/TerminalsPage", async () => {
117117
};
118118
});
119119

120-
vi.mock("../files/FilesPage", async () => {
121-
const Router = await vi.importActual("react-router-dom") as typeof RouterNamespace;
122-
123-
return {
124-
FilesPage: () => {
125-
const navigate = Router.useNavigate();
126-
return (
127-
<div data-testid="files-page">
128-
<button type="button" onClick={() => navigate("/work")}>
129-
Open work
130-
</button>
131-
</div>
132-
);
133-
},
134-
};
135-
});
136-
137120
vi.mock("../files/FilesTab", async () => {
138121
const Router = await vi.importActual("react-router-dom") as typeof RouterNamespace;
139122

apps/desktop/src/renderer/components/app/LinearIssueBrowser.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,9 @@ const LINEAR_MARKDOWN_COMPONENTS: Components = buildChatMarkdownComponents("neut
439439
href={href}
440440
onClick={(event) => {
441441
event.preventDefault();
442-
openUrlInAdeBrowser(href);
442+
if (typeof href === "string" && href.trim() !== "") {
443+
openUrlInAdeBrowser(href);
444+
}
443445
}}
444446
className="font-medium text-[color:var(--color-accent,#A78BFA)] underline underline-offset-2 transition-opacity hover:opacity-80"
445447
>
@@ -1184,10 +1186,11 @@ export function LinearIssueBrowser({
11841186
) : pageInfo.hasNextPage && (!canAutoLoadIssues || issues.length >= AUTO_LOAD_MAX_ISSUES) ? (
11851187
<button
11861188
type="button"
1189+
disabled={loadingIssues}
11871190
className="flex w-full items-center justify-center gap-2 px-3 py-2.5 text-[12px] text-muted-fg/70 transition-colors hover:bg-white/[0.04] hover:text-fg"
11881191
onClick={() => searchIssues(true)}
11891192
>
1190-
Load more issues
1193+
Load more
11911194
</button>
11921195
) : null}
11931196
</>

0 commit comments

Comments
 (0)