Clippy cleanup.

Author: arusahni

build.rs

@@ -46,22 +46,26 @@ fn set_args(mut p: Manual, y: &Yaml) -> Manual {
                     .long(parse_str(&arg, "long").as_str())
                     .help(parse_str(&arg, "help").as_str());
                 let short = parse_str(&arg, "short");
-                if short != "" {
+                if !short.is_empty() {
                     f = f.short(short.as_str());
                 }
                 p = p.flag(f);
             } else {
                 let o_val = parse_str(&arg, "value_name");
-                let key = if o_val != "" { o_val.as_str() } else { key };
+                let key = if !o_val.is_empty() {
+                    o_val.as_str()
+                } else {
+                    key
+                };
                 let mut o = Opt::new(key)
                     .long(parse_str(&arg, "long").as_str())
                     .help(parse_str(&arg, "help").as_str());
                 let short = parse_str(&arg, "short");
                 let default_value = parse_str(&arg, "default_value");
-                if short != "" {
+                if !short.is_empty() {
                     o = o.short(short.as_str());
                 }
-                if default_value != "" {
+                if !default_value.is_empty() {
                     o = o.default_value(default_value.as_str());
                 }
                 p = p.option(o);

src/git.rs

@@ -5,7 +5,6 @@ use std::str;
 use duct::cmd;
 use git2::{Config, Error, Repository};
 use log::{debug, trace, warn};
-use shellexpand;
 
 /// Update old `req.key` config format to include remote name, i.e, `req.remote_name.key`
 fn migrate_legacy(field_name: &str, remote_name: &str) {

src/remotes/github.rs

@@ -2,8 +2,6 @@ use crate::remotes::{MergeRequest, Remote};
 use log::{debug, trace};
 use regex::Regex;
 use serde_derive::{Deserialize, Serialize};
-use serde_json;
-use ureq;
 
 #[derive(Debug)]
 pub struct GitHub {

src/remotes/gitlab.rs

@@ -3,8 +3,6 @@ use crate::remotes::{MergeRequest, Remote};
 use log::{debug, error, trace};
 use regex::Regex;
 use serde_derive::{Deserialize, Serialize};
-use serde_json;
-use ureq;
 
 #[derive(Debug)]
 pub struct GitLab {