Appease clippy be removing unnecessary borrows.

Author: arusahni

build.rs

@@ -43,25 +43,25 @@ fn set_args(mut p: Manual, y: &Yaml) -> Manual {
             let takes_value = arg.get(&string_to_yaml("takes_value"));
             if takes_value.is_none() || !takes_value.unwrap().as_bool().unwrap() {
                 let mut f = Flag::new()
-                    .long(format!("--{}", parse_str(&arg, "long")).as_str())
-                    .help(parse_str(&arg, "help").as_str());
-                let short = parse_str(&arg, "short");
+                    .long(format!("--{}", parse_str(arg, "long")).as_str())
+                    .help(parse_str(arg, "help").as_str());
+                let short = parse_str(arg, "short");
                 if !short.is_empty() {
                     f = f.short(format!("-{}", short).as_str());
                 }
                 p = p.flag(f);
             } else {
-                let o_val = parse_str(&arg, "value_name");
+                let o_val = parse_str(arg, "value_name");
                 let key = if !o_val.is_empty() {
                     o_val.as_str()
                 } else {
                     key
                 };
                 let mut o = Opt::new(key)
-                    .long(format!("--{}", parse_str(&arg, "long")).as_str())
-                    .help(parse_str(&arg, "help").as_str());
-                let short = parse_str(&arg, "short");
-                let default_value = parse_str(&arg, "default_value");
+                    .long(format!("--{}", parse_str(arg, "long")).as_str())
+                    .help(parse_str(arg, "help").as_str());
+                let short = parse_str(arg, "short");
+                let default_value = parse_str(arg, "default_value");
                 if !short.is_empty() {
                     o = o.short(format!("-{}", short).as_str());
                 }

src/git.rs

@@ -91,7 +91,7 @@ pub fn set_project_config(field_name: &str, value: &str) {
 /// Get a value for the given global git-req config
 pub fn get_req_config(domain: &str, field: &str) -> Option<String> {
     let slug = slugify_domain(domain);
-    let cfg = Config::open(&Path::new(
+    let cfg = Config::open(Path::new(
         &shellexpand::tilde("~/.gitreqconfig").to_string(),
     ))
     .unwrap();
@@ -101,7 +101,7 @@ pub fn get_req_config(domain: &str, field: &str) -> Option<String> {
 /// Set a value for the global git-req configuration
 pub fn set_req_config(domain: &str, field: &str, value: &str) {
     let slug = slugify_domain(domain);
-    let mut cfg = Config::open(&Path::new(
+    let mut cfg = Config::open(Path::new(
         &shellexpand::tilde("~/.gitreqconfig").to_string(),
     ))
     .unwrap();
@@ -112,7 +112,7 @@ pub fn set_req_config(domain: &str, field: &str, value: &str) {
 /// Clear the value for the lobal git-req configuration
 pub fn delete_req_config(domain: &str, field: &str) -> Result<(), git2::Error> {
     let slug = slugify_domain(domain);
-    let mut cfg = Config::open(&Path::new(
+    let mut cfg = Config::open(Path::new(
         &shellexpand::tilde("~/.gitreqconfig").to_string(),
     ))
     .unwrap();
@@ -215,12 +215,12 @@ pub fn checkout_branch(
         }
         Err(_) => {
             // Fetch the remote branch if there's no local branch with the correct name
-            let mut fetch_args = vec!["fetch", &remote_name];
+            let mut fetch_args = vec!["fetch", remote_name];
             let remote_to_local_binding = format!("{}:{}", remote_branch_name, local_branch_name);
             fetch_args.push(if is_virtual_remote_branch {
                 &remote_to_local_binding
             } else {
-                &remote_branch_name
+                remote_branch_name
             });
             if cmd("git", fetch_args).run().is_err() {
                 return Err(anyhow!(

src/main.rs

@@ -84,7 +84,7 @@ fn checkout_mr(remote_name: &str, mr_id: i64) {
 fn clear_domain_key(remote_name: &str) {
     trace!("Deleting domain key");
     let mut remote = get_remote_hard(remote_name, false);
-    let deleted = match git::delete_req_config(&remote.get_domain(), "apikey") {
+    let deleted = match git::delete_req_config(remote.get_domain(), "apikey") {
         Ok(_) => Ok(true),
         Err(e) => match e.code() {
             ErrorCode::NotFound => Ok(false),
@@ -108,7 +108,7 @@ fn clear_domain_key(remote_name: &str) {
 fn set_domain_key(remote_name: &str, new_key: &str) {
     trace!("Setting domain key: {}", new_key);
     let mut remote = get_remote_hard(remote_name, false);
-    git::set_req_config(&remote.get_domain(), "apikey", new_key);
+    git::set_req_config(remote.get_domain(), "apikey", new_key);
     eprintln!("{}", "Domain key changed!".green());
 }
 
@@ -233,7 +233,7 @@ fn main() {
         set_default_remote(remote_name);
     } else if let Some(shell_name) = matches.value_of("GENERATE_COMPLETIONS") {
         app = build_cli();
-        generate_completion(&mut app, &shell_name);
+        generate_completion(&mut app, shell_name);
     } else {
         let request_id = matches.value_of("REQUEST_ID").unwrap();
         let mr_id = if request_id == "-" {

src/remotes/gitlab.rs

@@ -83,7 +83,7 @@ impl Remote for GitLab {
 
 /// Query the GitLab API
 fn query_gitlab_api(url: &str, token: &str) -> Result<ureq::Response, ureq::Response> {
-    let response = ureq::get(url).set("PRIVATE-TOKEN", &token).call();
+    let response = ureq::get(url).set("PRIVATE-TOKEN", token).call();
     if response.error() {
         return Err(response);
     }

src/remotes/mod.rs

@@ -67,7 +67,7 @@ pub fn get_domain(origin: &str) -> Result<&str> {
 
 /// Get the API key for the given domain. If absent, prompt.
 fn get_api_key(domain: &str) -> String {
-    git::get_req_config(&domain, "apikey").unwrap_or_else(|| {
+    git::get_req_config(domain, "apikey").unwrap_or_else(|| {
         let mut newkey = String::new();
         println!("No API token for {} found. See https://github.com/arusahni/git-req/wiki/API-Keys for instructions.", domain);
         print!("{} API token: ", domain);
@@ -76,7 +76,7 @@ fn get_api_key(domain: &str) -> String {
             .read_line(&mut newkey)
             .expect("Did not input a correct key");
         trace!("New Key: {}", &newkey);
-        git::set_req_config(&domain, "apikey", &newkey.trim());
+        git::set_req_config(domain, "apikey", newkey.trim());
         newkey.trim().to_string()
     })
 }
@@ -127,7 +127,7 @@ pub fn get_remote(remote_name: &str, origin: &str, skip_api_key: bool) -> Result
                 api_key: String::from(""),
             };
             if !skip_api_key {
-                let apikey = get_api_key(&domain);
+                let apikey = get_api_key(domain);
                 info!("API Key: {}", &apikey);
                 remote.api_key = apikey;
             }