set auto for stats module#172
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
===========================================
- Coverage 72.36% 50.00% -22.37%
===========================================
Files 19 19
Lines 1918 1964 +46
===========================================
- Hits 1388 982 -406
- Misses 530 982 +452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@OriolAbril I have implemented the changes required for this PR. |
OriolAbril
left a comment
There was a problem hiding this comment.
this looks good but it will take a bit to merge. The numba option is not thoroughly tested yet so we should first make sure that both arviz-stats and arviz-plots continue to pass after this change.
Thanks for the clarification and reviewing this PR. |
|
I have just tried running the arviz-stats test suite locally with these changes in default and 100 tests out of 2600 failed. We need some work on the numba backend before the change can actually be done. |
@OriolAbril Got it, thanks for testing this. I’ve reverted the default back to "base" and kept the "auto" option available without enabling it by default. |
|
hi @OriolAbril would it be okay if I worked on fixing the |
The best way to go about this is creating an arvizrc file with |
|
thanks @OriolAbril! I'll set up an |
|
i have opened arviz-devs/arviz-stats#350 which fixes the two |
Description
#80
This PR updates the behavior of stats.module when it is set to auto.
If numba is installed, numba will be used as the stats backend, otherwise it will fall back to base.
I also added a small test to ensure that auto resolves to either numba or base depending on whether numba is available.