fix(smartlog) smartlog does not panic when run in a non-git directory#1097
Open
cshinaver wants to merge 2 commits into
Open
fix(smartlog) smartlog does not panic when run in a non-git directory#1097cshinaver wants to merge 2 commits into
cshinaver wants to merge 2 commits into
Conversation
arxanas
requested changes
Oct 21, 2023
Owner
arxanas
left a comment
There was a problem hiding this comment.
Hi @cshinaver, thanks for the PR! As written, this would only handle the panic for the case of git branchless smartlog, and only when failing to open the Repo. I would prefer to see an approach that can handle more panics. The best approach overall might be to replace EyreExitOr with an enum something like this:
enum CommandResult<T> {
Ok(T),
Exit { exit_code: isize, message: String },
Unhandled(eyre::Error),
}
Then we could update the try_exit_code! macro (or create a new macro) that can wrap the result of Repo::from_dir and produce a CommandResult::Exit instead of letting the error propagate normally; and update do_main_and_drop_locals to handle the CommandResult and print the error message from the wrapped function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1069
First time contributing! tackling one of the smaller issues before I look into something more major.