wip: supports gpg signing#1531
Closed
Abhijay wants to merge 4 commits into
Closed
Conversation
feat(record): pass GPG-signing flag to `git commit` feat(rebase): support GPG-signing for all rebase-based commands
forivall
reviewed
Apr 8, 2025
| git-branchless-test = { version = "0.10.0", path = "git-branchless-test" } | ||
| git-branchless-undo = { version = "0.10.0", path = "git-branchless-undo" } | ||
| git2 = { version = "0.20.0", default-features = false } | ||
| git2 = { version = "0.18.0", default-features = false } |
There was a problem hiding this comment.
What was the rationale for the downgrade?
There was a problem hiding this comment.
the signing capabilities come from https://github.com/gitext-rs/git2-ext which locks its git2 dep at 0.18.0 (as does its dependency https://github.com/gitext-rs/git-fixture). but git-fixture already updated the dep and just needs a new release, and from what i can tell git2-ext can upgrade without issue as well
it sounds like 0.20.0 unlocked some functionality in git-branchless so downgrading would be a breaking change
|
i included your i like your addition, by the way! i have been using it at work |
Collaborator
|
Closing in favor of #1538 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works, but I don't plan on writing tests. Feel free to pick it up or close it if you don't want to.