[WIP] Support GPG-signing commits

[tommyip]

This is a work in progress, just wanted to publish it early to gather some feedback.

TODO:

• git record (calls git commit directly so signing already works in master, added new flags to override keyid or disable signing)
• git amend
• git move
  • in-memory
  • on-disk
• git sync
• git restack
• git reword
• git test
  git branchless snapshot create

Also looking in ways to write integration tests for this. Generating keys through gpg and using them in tests seems a bit cumbersome.

Fixes #465

[arxanas]

Thanks for looking into it!

git branchless snapshot create

We shouldn't need/want to sign snapshot commits (although you can if it's easier). These are just meant to store the working copy state to either attach to a real commit later (which would be signed at that time) or to restore the working copy state (which doesn't need to be signed).

Also looking in ways to write integration tests for this. Generating keys through gpg and using them in tests seems a bit cumbersome.

Would you be able to generate a single key ahead of time and commit it to the repo? Although I don't know if that would remove the dependency on gpg at test-time.

[arxanas]

Most likely you can ignore the warning about

using a potentially dangerous silent `as` conversion

here. That's meant for numeric types (like u32 <-> u64), but it looks like git2_ext::ops::Sign is not a numeric type, so I don't know why the warning is triggereing here.

[Abhijay]

@arxanas @tommyip Has this been abandoned? I would like to pick this up and finish this PR.

For anyone else looking into this, here's a utility script I have under git sign-branch to fix any unsigned commits from git restack:

#!/bin/bash

# Default parent branch
PARENT_BRANCH="main"

# Parse options
while getopts "p:" opt; do
  case $opt in
    p)
      PARENT_BRANCH=$OPTARG
      ;;
    *)
      echo "Usage: git sign-branch [-p parent_branch]"
      exit 1
      ;;
  esac
done

# Retrieve the current branch name
CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD)

# Find the base commit
BASE_COMMIT=$(git merge-base "$CURRENT_BRANCH" "$PARENT_BRANCH")

# Rebase and sign commits
git rebase -i "$BASE_COMMIT" --exec "git commit --amend -S --no-edit"

[claytonrcarter]

Closing this in favor of #1538, which is based on this change, I believe.