Skip to content

removendo exit 1 do script #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipeeffting merged 1 commit into from
Dec 17, 2025
Merged

removendo exit 1 do script #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion entrypoint.sh
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 18 in 94fb83f

$includes_arg \

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

codenarc-docker/entrypoint.sh

Line 30 in 94fb83f

${INPUT_REVIEWDOG_FLAGS}

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 18 in 94fb83f

$includes_arg \

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

codenarc-docker/entrypoint.sh

Line 30 in 94fb83f

${INPUT_REVIEWDOG_FLAGS}

Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ check_blocking_rules() {
if [ "$p1_count" -gt 0 ]; then
echo "⛔ Foram encontradas violacoes bloqueantes (priority 1)."
echo "💡 Corrija as violacoes ou use o bypass autorizado pelo coordenador."
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing exit 1 for blocking violations defeats the purpose of having 'bloqueantes' (blocking) rules. The script will now proceed despite critical priority 1 violations, which contradicts the warning message that instructs users to fix violations or use an authorized bypass. Consider implementing proper bypass logic instead of removing the exit altogether.

Suggested change
echo "💡 Corrija as violacoes ou use o bypass autorizado pelo coordenador."
echo "💡 Corrija as violacoes ou use o bypass autorizado pelo coordenador."
if [ "${BYPASS_BLOQUEANTES}" != "true" ]; then
echo "❌ Falha: Violacoes bloqueantes encontradas. Interrompendo o processo."
exit 1
else
echo "⚠️ Bypass autorizado: continuando apesar das violacoes bloqueantes."
fi

Copilot uses AI. Check for mistakes.
exit 1
else
echo "✅ Nenhuma violacao bloqueante (priority 1) encontrada."
fi
Expand Down
Loading