GH-877: Implement Plexus converter that can convert algebraic sealed types#881
Merged
Conversation
ascopes
commented
Nov 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
+ Coverage 92.66% 92.88% +0.22%
==========================================
Files 71 72 +1
Lines 1975 2034 +59
Branches 127 131 +4
==========================================
+ Hits 1830 1889 +59
Misses 104 104
Partials 41 41
🚀 New features to boost your workflow:
|
…types The implementation of this will expect users to take a 'kind' attribute on the marker for a sealed type parameter which is used via reflection to determine the concrete implementation class. Right now, we have to provide this info on each implementation via an annotation such that we can influence the behaviour that will eventually be provided for us by GH-880. This PR also changes the documentation and plugin interface so that users will pass in a <plugins> list containing all plugins now rather than having four distinct parameters for the same information. The exisiting parameters have been kept and still work the same way, but are now undocumented in the plugin guide, and are marked as deprecated-for-removal in v5.0.0. With this change, we will be able to use sealed implementation kinds for the <protoc/> parameter in future changes, further supporting GH-877.
ascopes
force-pushed
the
feature/GH-877-sealed-type-converter
branch
from
December 1, 2025 08:31
ccd9889 to
584f0c7
Compare
ascopes
force-pushed
the
feature/GH-877-sealed-type-converter
branch
from
December 2, 2025 08:37
bcae639 to
3cb4991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of this will expect users to take a 'kind' attribute on the marker for a sealed type parameter which is used via reflection to determine the concrete implementation class. Right now, we have to provide this info on each implementation via an annotation such that we can influence the behaviour that will eventually be provided for us by GH-880.
This PR also changes the documentation and plugin interface so that users will pass in a list containing all plugins now rather than having four distinct parameters for the same information. The exisiting parameters have been kept and still work the same way, but are now undocumented in the plugin guide, and are marked as deprecated-for-removal in v5.0.0.
With this change, we will be able to use sealed implementation kinds for the parameter in future changes, further supporting GH-877.