fix: drop getAsString from HeadContext (#41)

SukkaW · web-flow · commit 407e9b643458 · 2025-10-13T10:31:56.000+01:00
@ascorbic Is Impala still maintained? I happened to have some small projects that `@impala/preact` just perfectly fit the need. I noticed that `preact-render-to-string` is being included in the client bundle, which is weird. I dug around and noticed that this is used in the `HeadContext`'s `getAsString` method, which is not being used at all: https://github.com/search?q=repo%3Aascorbic%2Fimpala%20getAsString&type=code I guess the `getAsString` was added for SSR, but later the SSR for `<head />` has been moved to `entry-server` instead, which made `getAsString` obsolete: - preact - https://github.com/ascorbic/impala/blob/74a4ab04744e8a539a3a7ec1225753c36ac040df/packages/preact/src/entry-server.tsx#L25 - react - https://github.com/ascorbic/impala/blob/74a4ab04744e8a539a3a7ec1225753c36ac040df/packages/react/src/entry-server.tsx#L60 The PR removes the `getAsString` method from `HeadContext`, preventing `preact-render-to-string` and `react-dom/server` from being included in the client bundle (they should only be in the server bundle).
diff --git a/packages/preact/src/head-context.tsx b/packages/preact/src/head-context.tsx
@@ -1,5 +1,4 @@
 import { createContext, VNode } from "preact";
-import render from "preact-render-to-string";
 
 class HeadProvider {
   private head: VNode<any>[] = [];
@@ -30,10 +29,6 @@ class HeadProvider {
   public getHead() {
     return this.head;
   }
-
-  public getAsString() {
-    return render(<>{...this.head}</>);
-  }
 }
 
 const headProvider = new HeadProvider();
diff --git a/packages/react/src/head-context.tsx b/packages/react/src/head-context.tsx
@@ -1,5 +1,4 @@
 import React, { createContext, ReactElement, ReactNode } from "react";
-import { renderToStaticMarkup } from "react-dom/server";
 
 class HeadProvider {
   private head: React.ReactElement[] = [];
@@ -30,10 +29,6 @@ class HeadProvider {
   public getHead() {
     return this.head;
   }
-
-  public getAsString() {
-    return renderToStaticMarkup(<>{...this.head}</>);
-  }
 }
 
 const headProvider = new HeadProvider();

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import { createContext, VNode } from "preact";`
`2`		`-import render from "preact-render-to-string";`
`3`	`2`
`4`	`3`	`class HeadProvider {`
`5`	`4`	`private head: VNode<any>[] = [];`
`@@ -30,10 +29,6 @@ class HeadProvider {`
`30`	`29`	`public getHead() {`
`31`	`30`	`return this.head;`
`32`	`31`	`}`
`33`		`-`
`34`		`- public getAsString() {`
`35`		`- return render(<>{...this.head}</>);`
`36`		`- }`
`37`	`32`	`}`
`38`	`33`
`39`	`34`	`const headProvider = new HeadProvider();`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import React, { createContext, ReactElement, ReactNode } from "react";`
`2`		`-import { renderToStaticMarkup } from "react-dom/server";`
`3`	`2`
`4`	`3`	`class HeadProvider {`
`5`	`4`	`private head: React.ReactElement[] = [];`
`@@ -30,10 +29,6 @@ class HeadProvider {`
`30`	`29`	`public getHead() {`
`31`	`30`	`return this.head;`
`32`	`31`	`}`
`33`		`-`
`34`		`- public getAsString() {`
`35`		`- return renderToStaticMarkup(<>{...this.head}</>);`
`36`		`- }`
`37`	`32`	`}`
`38`	`33`
`39`	`34`	`const headProvider = new HeadProvider();`