Skip to content

ci: remove invalid changeset ignore configuration#3

Merged
ascorbic merged 1 commit into
mainfrom
chore/enable-changeset-demo-packages
Nov 6, 2025
Merged

ci: remove invalid changeset ignore configuration#3
ascorbic merged 1 commit into
mainfrom
chore/enable-changeset-demo-packages

Conversation

@ascorbic

@ascorbic ascorbic commented Nov 6, 2025

Copy link
Copy Markdown
Owner

Summary

  • Removes the ignore: ["@demo/*"] configuration from .changeset/config.json
  • This repository doesn't contain any @demo/* packages, making this configuration invalid and unnecessary

Test plan

  • Verify changeset configuration is valid
  • Ensure changesets continue to work correctly for the packages in this repository

🤖 Generated with Claude Code

The ignore field was set to ignore @demo/* packages, but this repository doesn't have any @demo/* packages, making this configuration invalid and unnecessary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude

claude Bot commented Nov 6, 2025

Copy link
Copy Markdown

PR Review: Remove invalid changeset ignore configuration

Summary

This PR removes the ignore: ["@demo/*"] configuration from .changeset/config.json, changing it to an empty array.

Code Quality ✅

Positive aspects:

  • Clean, focused change that addresses a specific configuration issue
  • Clear PR description explaining the rationale
  • Minimal diff (1 addition, 1 deletion)

Correctness ✅

The change is correct. I verified:

  • The repository currently has no demos directory (referenced in CLAUDE.md but not present)
  • The only package is vitest-browser-astro (not namespaced with @demo/*)
  • Having ignore: ["@demo/*"] would indeed be invalid/unnecessary

Potential Considerations

Minor issue found ⚠️

While reviewing the changeset configuration, I noticed an inconsistency in .changeset/config.json:6:

"repo": "ascorbic/library-template"

This appears to reference a template repository rather than the actual repository (ascorbic/vitest-browser-astro). This should be updated to ensure:

  • Changelog links point to the correct repository
  • Release notes reference the right GitHub repo

Suggested fix:

"repo": "ascorbic/vitest-browser-astro"

This doesn't block the current PR but should be addressed separately or included if you're already modifying the changeset config.

Test Coverage ✅

The PR description mentions:

  • Verify changeset configuration is valid
  • Ensure changesets continue to work correctly

These are appropriate test steps for this configuration change. Consider running:

pnpm changeset status

to verify the configuration is valid after the change.

Security & Performance

No security or performance concerns for this configuration change.

Recommendation

LGTM with minor note - The PR is good to merge as-is. However, I recommend creating a follow-up issue or commit to fix the repo field in the changeset config to point to the correct repository.


🤖 Review generated with Claude Code

@ascorbic ascorbic changed the title Remove invalid changeset ignore configuration ci: remove invalid changeset ignore configuration Nov 6, 2025
@ascorbic ascorbic merged commit 4e325df into main Nov 6, 2025
3 of 4 checks passed
@ascorbic ascorbic deleted the chore/enable-changeset-demo-packages branch November 6, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant