Skip to content

ci: release#6

Merged
ascorbic merged 1 commit into
mainfrom
changeset-release/main
Nov 6, 2025
Merged

ci: release#6
ascorbic merged 1 commit into
mainfrom
changeset-release/main

Conversation

@mixie-bot

@mixie-bot mixie-bot Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

vitest-browser-astro@0.1.0

Minor Changes

  • #4 51d659f Thanks @ascorbic! - Initial release of vitest-browser-astro

    This package provides a Vitest browser mode renderer for Astro components, allowing you to test Astro components in a browser environment using Vitest's browser mode.

    Features:

    • Render Astro components in browser tests
    • Support for React components within Astro
    • Full access to browser APIs during testing
    • Plugin integration for Vitest configuration

astro-test-fixture@0.0.1

Patch Changes

  • Updated dependencies [51d659f]:
    • vitest-browser-astro@0.1.0

@claude

claude Bot commented Nov 6, 2025

Copy link
Copy Markdown

PR Review: Release v0.1.0

This is an automated release PR generated by Changesets. Here's my review:

Summary

This PR releases:

  • vitest-browser-astro@0.1.0 (minor) - Initial public release
  • astro-test-fixture@0.0.1 (patch) - Updated dependency version

Code Quality ✓

The changes are mechanical and follow standard Changesets patterns:

  • Changeset file removed after being consumed
  • CHANGELOG.md files generated with proper formatting
  • Version bumps in package.json files are correct (0.0.0 → 0.1.0 for main package)

Best Practices ✓

Versioning:

  • Correctly uses semantic versioning (minor bump for initial release)
  • Test fixture properly gets a patch version as a private package

Changelog:

  • Well-structured with proper links to PRs and commits
  • Clear feature list in the release notes
  • Follows conventional changelog format

Potential Considerations

  1. NPM Token: Ensure the NPM_TOKEN secret is configured if not already (for publishing)

    • The workflow uses OIDC (id-token: write), which is good for security
  2. Pre-publish validation: The workflow runs pnpm run check before publishing, which is excellent:

    • Runs publint and @arethetypeswrong/cli
    • Catches package configuration issues before they reach npm
  3. Test fixture CHANGELOG: The test fixture gets a CHANGELOG even though it's a private package

    • This is harmless but could be excluded in .changeset/config.json if desired
    • Not a blocker for this release

Security ✓

  • Uses GitHub App tokens (more secure than GITHUB_TOKEN)
  • OIDC for npm publishing (no long-lived tokens)
  • Proper permission scoping in workflow

Test Coverage

The PR doesn't modify test code, which is expected for a release PR. The actual features were tested in PR #4.

Recommendation

✅ Approved for merge

This is a standard, well-formed release PR. Once merged, it will trigger the publish workflow to release vitest-browser-astro@0.1.0 to npm.


Review generated by Claude Code

@ascorbic ascorbic merged commit 98a2ede into main Nov 6, 2025
3 checks passed
@ascorbic ascorbic deleted the changeset-release/main branch November 6, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant