fix: use os.PathListSeparator

Use os.PathListSeparator instead of ":". This removes one blocker for
a Windows port as the path separator on Windows is ";".

Also use filepath.SplitList instead of strings.Split to correctly handle
the (very unepected) case of an empty PATH in RemoveFromPath.

Author: dolmen

internal/cli/cli.go

@@ -545,7 +545,7 @@ func envCommand(logger *log.Logger, shimmedCommand string, args []string) error
 }
 
 func setPath(paths []string) string {
-	return strings.Join(paths, ":") + ":" + os.Getenv("PATH")
+	return strings.Join(paths, string(os.PathListSeparator)) + string(os.PathListSeparator) + os.Getenv("PATH")
 }
 
 func execCommand(logger *log.Logger, command string, args []string) error {

internal/paths/paths.go

@@ -4,18 +4,19 @@
 package paths
 
 import (
+	"path/filepath"
 	"strings"
 )
 
 // RemoveFromPath returns the PATH without asdf shims path
 func RemoveFromPath(currentPath, pathToRemove string) string {
 	var newPaths []string
 
-	for _, fspath := range strings.Split(currentPath, ":") {
+	for _, fspath := range filepath.SplitList(currentPath) {
 		if fspath != pathToRemove {
 			newPaths = append(newPaths, fspath)
 		}
 	}
 
-	return strings.Join(newPaths, ":")
+	return strings.Join(newPaths, string(filepath.ListSeparator))
 }