Skip to content

Commit c49f2f7

Browse files
committed
Merge branch 'mgrechukh-fix-multiword-tools'
2 parents 4161d9d + 2ffb5b8 commit c49f2f7

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

internal/resolve/resolve.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,5 +131,7 @@ func parseVersion(rawVersions string) []string {
131131
}
132132

133133
func variableVersionName(toolName string) string {
134-
return fmt.Sprintf("ASDF_%s_VERSION", strings.ToUpper(toolName))
134+
upper := strings.ToUpper(toolName)
135+
sanitized := strings.ReplaceAll(upper, "-", "_")
136+
return fmt.Sprintf("ASDF_%s_VERSION", sanitized)
135137
}

internal/resolve/resolve_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ func TestVersion(t *testing.T) {
4343

4444
t.Run("returns version from env when env variable set", func(t *testing.T) {
4545
// Set env
46-
t.Setenv(fmt.Sprintf("ASDF_%s_VERSION", strings.ToUpper(testPluginName)), "2.3.4")
46+
versionVariableName := fmt.Sprintf("ASDF_%s_VERSION", strings.ToUpper(strings.ReplaceAll(testPluginName, "-", "_")))
47+
t.Setenv(versionVariableName, "2.3.4")
4748

4849
// write a version file
4950
data := []byte(fmt.Sprintf("%s 1.2.3", testPluginName))
@@ -204,7 +205,7 @@ func TestFindVersionsInEnv(t *testing.T) {
204205
versions, envVariableName, found := findVersionsInEnv("non-existent")
205206
assert.False(t, found)
206207
assert.Empty(t, versions)
207-
assert.Equal(t, envVariableName, "ASDF_NON-EXISTENT_VERSION")
208+
assert.Equal(t, envVariableName, "ASDF_NON_EXISTENT_VERSION")
208209
})
209210

210211
t.Run("when env variable is set returns version", func(t *testing.T) {
@@ -242,7 +243,7 @@ func TestVariableVersionName(t *testing.T) {
242243
},
243244
{
244245
input: "foo-bar",
245-
output: "ASDF_FOO-BAR_VERSION",
246+
output: "ASDF_FOO_BAR_VERSION",
246247
},
247248
}
248249

0 commit comments

Comments
 (0)