feat: Report missing plugins and install plugins in defined order#1970
Open
andrecloutier wants to merge 10 commits into
Open
feat: Report missing plugins and install plugins in defined order#1970andrecloutier wants to merge 10 commits into
andrecloutier wants to merge 10 commits into
Conversation
6c1e051 to
1f7649c
Compare
1f7649c to
554f6f9
Compare
f9f78d7 to
5272a17
Compare
manuraj17
reviewed
Feb 21, 2025
| } | ||
|
|
||
| homeDir, err := homedir.Dir() | ||
| homeDir, err := os.UserHomeDir() |
Contributor
There was a problem hiding this comment.
Since you are replacing the library - it is being used here as well
https://github.com/asdf-vm/asdf/pull/1970/files#diff-54c7c1af5fa8d5db4dc49f0e8e80e93ba2b1183ba4d5c9e2e5729e6deae6a3cdL207
There is a related issue
#1923
Contributor
Author
There was a problem hiding this comment.
I changed it here since it's a fairly safe change. Nothing else appears to be reading from config.Home prior to this change and the current implementation of install was already relying on os.UserHomeDir(). I think removing the other usages merit its own PR. Seems trivial but I'm not confident enough w/ this code base yet to say there aren't edge cases to consider.
Contributor
Author
|
@Stratus3D - Ready for some 👀 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two features:
Other Information
Sample output: