Skip to content

fix: Make plugin test resolve latest version #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maciektr wants to merge 4 commits into from
+16 −3
Closed

fix: Make plugin test resolve latest version #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d7e4d3
fix: Do not accept latest as version name in dummy repo fixture
maciektr Feb 24, 2026
f133ba7
fix: Add test case for plugin test resolving latest version
maciektr Feb 24, 2026
4585b6f
fix: Make plugin test resolve latest version
maciektr Feb 24, 2026
92f016d
Merge branch 'master' into maciektr/fix-2193
Stratus3D Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,10 +1028,18 @@ func pluginTestCommand(l *log.Logger, args []string, toolVersion, ref string) {
failTest(l, "list-all did not return any version")
}

// grab first version returned by list-all callback if no version provided as
// a CLI argument
// Resolve version: if empty use first from list-all; if "latest" or
// "latest:<query>" resolve via the plugin's latest-stable callback.
if toolVersion == "" {
toolVersion = allVersions[0]
} else if toolVersion == "latest" || strings.HasPrefix(toolVersion, "latest:") {
query := strings.TrimPrefix(toolVersion, "latest")
query = strings.TrimPrefix(query, ":")
resolved, err := versions.Latest(plugin, query)
if err != nil || resolved == "" {
Copy link
Copy Markdown
Member

@Stratus3D Stratus3D Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This || resolved == "" check should not be needed.

failTest(l, "could not get latest version")
}
toolVersion = resolved
}

err = versions.InstallOneVersion(conf, plugin, toolVersion, false, os.Stdout, os.Stderr)
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/dummy_plugin/bin/install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# We want certain versions to fail installation for various reasons in the tests
check_dummy_versions() {
local bad_versions=" other-dummy "
local bad_versions=" other-dummy latest "
if [[ "$bad_versions" == *" $ASDF_INSTALL_VERSION "* ]]; then
echo "Dummy couldn't install version: $ASDF_INSTALL_VERSION (on purpose)"
exit 1
Expand Down
5 changes: 5 additions & 0 deletions test/plugin_test_command.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@ teardown() {
run asdf plugin test dummy "${BASE_DIR}/repo-dummy" --asdf-tool-version 1.0.0 --asdf-plugin-gitref master
[ "$status" -eq 0 ]
}

@test "plugin_test_command resolves latest version when --asdf-tool-version latest is provided" {
run asdf plugin test dummy "${BASE_DIR}/repo-dummy" --asdf-tool-version latest
[ "$status" -eq 0 ]
}