Skip to content

Commit 9641282

Browse files
author
Ronen Hilewicz
committed
Shorten topaz readiness probe period to 1s
And disable liveness and startup probes by default. Topaz no longer generates self-signed certs so there's no need for a startup probe. The service starts very quickly.
1 parent d3737d5 commit 9641282

2 files changed

Lines changed: 21 additions & 17 deletions

File tree

charts/topaz/templates/deployment.yaml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,22 @@ spec:
7979
containerPort: {{ (.Values.ports).profiler | default "8686"}}
8080
protocol: TCP
8181
{{- end }}
82-
startupProbe:
83-
grpc:
84-
port: {{ (.Values.ports).health | default "8484" }}
85-
{{- toYaml .Values.startupProbe | nindent 12 }}
86-
livenessProbe:
87-
grpc:
88-
port: {{ (.Values.ports).health | default "8484" }}
89-
{{- toYaml .Values.livenessProbe | nindent 12 }}
9082
readinessProbe:
9183
grpc:
9284
port: {{ (.Values.ports).health | default "8484" }}
9385
{{- toYaml .Values.readinessProbe | nindent 12 }}
86+
{{- with .Values.startupProbe }}
87+
startupProbe:
88+
grpc:
89+
port: {{ ($.Values.ports).health | default "8484" }}
90+
{{- . | toYaml | nindent 12 }}
91+
{{- end }}
92+
{{- with .Values.livenessProbe }}
93+
livenessProbe:
94+
grpc:
95+
port: {{ ($.Values.ports).health | default "8484" }}
96+
{{- . | toYaml | nindent 12 }}
97+
{{- end }}
9498
resources:
9599
{{- toYaml .Values.resources | nindent 12 }}
96100
volumeMounts:

charts/topaz/values.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -432,16 +432,16 @@ resources: {}
432432
# cpu: 100m
433433
# memory: 128Mi
434434

435-
livenessProbe:
436-
failureThreshold: 1
437-
periodSeconds: 10
438-
439435
readinessProbe:
440-
periodSeconds: 5
441-
442-
startupProbe:
443-
failureThreshold: 30
444-
periodSeconds: 10
436+
periodSeconds: 1
437+
438+
# livenessProbe:
439+
# failureThreshold: 1
440+
# periodSeconds: 10
441+
#
442+
# startupProbe:
443+
# failureThreshold: 30
444+
# periodSeconds: 10
445445

446446
autoscaling:
447447
enabled: false

0 commit comments

Comments
 (0)