Skip to content

Commit 899428e

Browse files
committed
Rename MaintenanceOptions to DatabaseRepairOptions
1 parent 7ed1a35 commit 899428e

3 files changed

Lines changed: 19 additions & 19 deletions

File tree

src/fb-cpp/DatabaseManager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ void DatabaseManager::execute(const DatabaseManagerOptions& options)
6767
}
6868

6969

70-
void DatabaseManager::execute(const MaintenanceOptions& options)
70+
void DatabaseManager::execute(const DatabaseRepairOptions& options)
7171
{
7272
StatusWrapper statusWrapper{getClient()};
7373
auto builder =

src/fb-cpp/DatabaseManager.h

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ namespace fbcpp
8484
///
8585
/// Represents options used to run a database maintenance operation through the service manager.
8686
///
87-
class MaintenanceOptions final
87+
class DatabaseRepairOptions final
8888
{
8989
public:
9090
///
@@ -98,7 +98,7 @@ namespace fbcpp
9898
///
9999
/// Sets the database path to be maintained.
100100
///
101-
MaintenanceOptions& setDatabase(const std::string& value)
101+
DatabaseRepairOptions& setDatabase(const std::string& value)
102102
{
103103
database = value;
104104
return *this;
@@ -115,7 +115,7 @@ namespace fbcpp
115115
///
116116
/// Sets the verbose output callback.
117117
///
118-
MaintenanceOptions& setVerboseOutput(ServiceManager::VerboseOutput value)
118+
DatabaseRepairOptions& setVerboseOutput(ServiceManager::VerboseOutput value)
119119
{
120120
verboseOutput = std::move(value);
121121
return *this;
@@ -132,7 +132,7 @@ namespace fbcpp
132132
///
133133
/// Sets the requested number of parallel workers.
134134
///
135-
MaintenanceOptions& setParallelWorkers(std::uint32_t value)
135+
DatabaseRepairOptions& setParallelWorkers(std::uint32_t value)
136136
{
137137
parallelWorkers = value;
138138
return *this;
@@ -149,7 +149,7 @@ namespace fbcpp
149149
///
150150
/// Sets whether database sweep is enabled.
151151
///
152-
MaintenanceOptions& setSweep(bool value)
152+
DatabaseRepairOptions& setSweep(bool value)
153153
{
154154
sweep = value;
155155
return *this;
@@ -166,7 +166,7 @@ namespace fbcpp
166166
///
167167
/// Sets whether database validation is enabled.
168168
///
169-
MaintenanceOptions& setValidate(bool value)
169+
DatabaseRepairOptions& setValidate(bool value)
170170
{
171171
validate = value;
172172
return *this;
@@ -183,7 +183,7 @@ namespace fbcpp
183183
///
184184
/// Sets whether database mending is enabled.
185185
///
186-
MaintenanceOptions& setMend(bool value)
186+
DatabaseRepairOptions& setMend(bool value)
187187
{
188188
mend = value;
189189
return *this;
@@ -200,7 +200,7 @@ namespace fbcpp
200200
///
201201
/// Sets whether checksum verification is ignored.
202202
///
203-
MaintenanceOptions& setIgnoreChecksum(bool value)
203+
DatabaseRepairOptions& setIgnoreChecksum(bool value)
204204
{
205205
ignoreChecksum = value;
206206
return *this;
@@ -217,7 +217,7 @@ namespace fbcpp
217217
///
218218
/// Sets whether killing database shadows is enabled.
219219
///
220-
MaintenanceOptions& setKillShadows(bool value)
220+
DatabaseRepairOptions& setKillShadows(bool value)
221221
{
222222
killShadows = value;
223223
return *this;
@@ -234,7 +234,7 @@ namespace fbcpp
234234
///
235235
/// Sets whether full validation is enabled.
236236
///
237-
MaintenanceOptions& setFull(bool value)
237+
DatabaseRepairOptions& setFull(bool value)
238238
{
239239
full = value;
240240
return *this;
@@ -251,7 +251,7 @@ namespace fbcpp
251251
///
252252
/// Sets whether checking only metadata/structure is enabled.
253253
///
254-
MaintenanceOptions& setCheckDb(bool value)
254+
DatabaseRepairOptions& setCheckDb(bool value)
255255
{
256256
checkDb = value;
257257
return *this;
@@ -268,7 +268,7 @@ namespace fbcpp
268268
///
269269
/// Sets whether recreating ICU indexes is enabled.
270270
///
271-
MaintenanceOptions& setIcu(bool value)
271+
DatabaseRepairOptions& setIcu(bool value)
272272
{
273273
icu = value;
274274
return *this;
@@ -285,7 +285,7 @@ namespace fbcpp
285285
///
286286
/// Sets whether database upgrade is enabled.
287287
///
288-
MaintenanceOptions& setUpgradeDb(bool value)
288+
DatabaseRepairOptions& setUpgradeDb(bool value)
289289
{
290290
upgradeDb = value;
291291
return *this;
@@ -323,7 +323,7 @@ namespace fbcpp
323323
///
324324
/// Runs a maintenance or repair operation using the provided options.
325325
///
326-
void execute(const MaintenanceOptions& options);
326+
void execute(const DatabaseRepairOptions& options);
327327
};
328328
} // namespace fbcpp
329329

src/test/DatabaseManager.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,18 +177,18 @@ BOOST_AUTO_TEST_CASE(databaseSweepAndValidate)
177177
DatabaseManager manager{CLIENT, makeServiceManagerOptions()};
178178

179179
// 1. Run database sweep
180-
BOOST_CHECK_NO_THROW(manager.execute(MaintenanceOptions().setDatabase(databasePath).setSweep(true)));
180+
BOOST_CHECK_NO_THROW(manager.execute(DatabaseRepairOptions().setDatabase(databasePath).setSweep(true)));
181181

182182
// 2. Run multi-threaded database sweep
183183
BOOST_CHECK_NO_THROW(
184-
manager.execute(MaintenanceOptions().setDatabase(databasePath).setSweep(true).setParallelWorkers(4)));
184+
manager.execute(DatabaseRepairOptions().setDatabase(databasePath).setSweep(true).setParallelWorkers(4)));
185185

186186
// 3. Run database validation
187187
BOOST_CHECK_NO_THROW(
188-
manager.execute(MaintenanceOptions().setDatabase(databasePath).setValidate(true).setFull(true)));
188+
manager.execute(DatabaseRepairOptions().setDatabase(databasePath).setValidate(true).setFull(true)));
189189

190190
// 4. Run database upgrade (minor ODS upgrade)
191-
BOOST_CHECK_NO_THROW(manager.execute(MaintenanceOptions().setDatabase(databasePath).setUpgradeDb(true)));
191+
BOOST_CHECK_NO_THROW(manager.execute(DatabaseRepairOptions().setDatabase(databasePath).setUpgradeDb(true)));
192192

193193
Attachment cleanup{CLIENT, databaseUri, attachmentOptions};
194194
cleanup.dropDatabase();

0 commit comments

Comments
 (0)