fix: prevent segfault when input exceeds batch size#21
Open
vlasky wants to merge 1 commit intoasg017:mainfrom
Open
fix: prevent segfault when input exceeds batch size#21vlasky wants to merge 1 commit intoasg017:mainfrom
vlasky wants to merge 1 commit intoasg017:mainfrom
Conversation
The batch was initialized with a fixed capacity of 512 tokens, but the loop populating it had no bounds check. When processing documents with more than 512 tokens, this caused a buffer overflow and segmentation fault. Changes: - Size batch to actual token_count instead of fixed 512 - Add bounds check: error if token_count > context size - Return actionable error message with token count and limit - Fix memory leak: free tokens array after use - Add specific error messages for decode/embedding failures Fixes asg017#20 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The batch was initialized with a fixed capacity of 512 tokens, but the loop populating it had no bounds check. When an input tokenized to more than 512 tokens, this caused a buffer overflow and segmentation fault.
Resolves #20
Test plan