chore: credo

Author: zachdaniel

lib/ash_json_api/request.ex

@@ -1024,13 +1024,14 @@ defmodule AshJsonApi.Request do
        )
        when is_map(attributes) do
     Enum.reduce(attributes, request, fn {key, value}, request ->
-      if arg =
-           Enum.find(action.arguments, fn argument ->
+      case Enum.find(action.arguments, fn argument ->
              to_string(argument.name) == key
            end) do
-        %{request | arguments: Map.put(request.arguments || %{}, arg.name, value)}
-      else
-        request
+        nil ->
+          request
+
+        arg ->
+          %{request | arguments: Map.put(request.arguments || %{}, arg.name, value)}
       end
     end)
   end

test/acceptance/error_validation_test.exs

@@ -87,7 +87,7 @@ defmodule Test.Acceptance.ErrorValidationTest do
 
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       error = Enum.find(errors, &(&1["code"] == "invalid_filter"))
       assert error, "Expected to find an 'invalid_filter' error"
@@ -107,7 +107,7 @@ defmodule Test.Acceptance.ErrorValidationTest do
 
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       error = Enum.find(errors, &(&1["code"] == "invalid_sort"))
       assert error, "Expected to find an 'invalid_sort' error"
@@ -124,7 +124,7 @@ defmodule Test.Acceptance.ErrorValidationTest do
 
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       error = Enum.find(errors, &(&1["code"] == "invalid_sort"))
       assert error, "Expected to find an 'invalid_sort' error"

test/acceptance/forbidden_field_test.exs

@@ -382,7 +382,7 @@ defmodule Test.Acceptance.ForbiddenFieldTest do
       result = AshJsonApi.Error.to_json_api_errors(Domain, Dashboard, forbidden_error, :read)
 
       assert is_list(result)
-      assert length(result) >= 1
+      assert result != []
 
       json_error = hd(result)
       assert json_error.status_code == 403

test/acceptance/generic_action_index_test.exs

@@ -134,7 +134,7 @@ defmodule Test.Acceptance.GenericActionIndexTest do
 
     assert %{"errors" => errors} = response.resp_body
     assert is_list(errors)
-    assert length(errors) > 0
+    assert errors != []
 
     required_error =
       Enum.find(

test/acceptance/get_related_test.exs

@@ -186,7 +186,7 @@ defmodule Test.Acceptance.GetRelatedTest do
       assert Map.has_key?(response.resp_body, "errors")
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       # Verify the error has proper JSON:API structure
       error = hd(errors)
@@ -214,7 +214,7 @@ defmodule Test.Acceptance.GetRelatedTest do
       assert Map.has_key?(response.resp_body, "errors")
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       error = hd(errors)
       assert error["status"] == "404"
@@ -237,7 +237,7 @@ defmodule Test.Acceptance.GetRelatedTest do
       assert Map.has_key?(response.resp_body, "errors")
       errors = response.resp_body["errors"]
       assert is_list(errors)
-      assert length(errors) > 0
+      assert errors != []
 
       error = hd(errors)
       assert error["status"] == "404"

test/acceptance/paginated_relationships_test.exs

@@ -297,7 +297,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
 
       # Should get an error because 'private_comments' is not public
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       # Error should indicate the relationship is invalid/not included
       assert List.first(errors)["code"] in ["invalid_includes", "invalid_relationship"]
     end
@@ -324,14 +324,14 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
 
       # Multiple posts in the response
       assert is_list(response.resp_body["data"])
-      assert length(response.resp_body["data"]) > 0
+      assert response.resp_body["data"] != []
 
       # Each post that has comments should have pagination metadata
       Enum.each(response.resp_body["data"], fn post_data ->
         comments_rel = post_data["relationships"]["comments"]
 
         # If there are comments, check for pagination metadata
-        if length(comments_rel["data"]) > 0 do
+        if comments_rel["data"] != [] do
           assert comments_rel["meta"]["limit"] == 3
         end
       end)
@@ -411,7 +411,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "limit must be an integer"
     end
@@ -425,7 +425,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "limit must be a positive integer"
     end
@@ -439,7 +439,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "limit must be a positive integer"
     end
@@ -453,7 +453,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "offset must be an integer"
     end
@@ -467,7 +467,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "offset must be a non-negative integer"
     end
@@ -481,7 +481,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "count must be 'true' or 'false'"
     end
@@ -495,7 +495,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "unknown pagination parameter"
     end
@@ -545,7 +545,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "invalid JSON"
     end
@@ -562,7 +562,7 @@ defmodule Test.Acceptance.PaginatedRelationshipsTest do
         )
 
       errors = response.resp_body["errors"]
-      assert length(errors) > 0
+      assert errors != []
       assert List.first(errors)["code"] == "invalid_pagination"
       assert List.first(errors)["detail"] =~ "must be a JSON object"
     end

test/acceptance/route_test.exs

@@ -123,7 +123,7 @@ defmodule Test.Acceptance.RouteTest do
 
     assert %{"errors" => errors} = response.resp_body
     assert is_list(errors)
-    assert length(errors) > 0
+    assert errors != []
 
     # Find the "required" error for the missing "from" argument
     required_error = Enum.find(errors, &(&1["code"] == "required"))
@@ -146,7 +146,7 @@ defmodule Test.Acceptance.RouteTest do
 
     assert %{"errors" => errors} = response.resp_body
     assert is_list(errors)
-    assert length(errors) > 0
+    assert errors != []
 
     # Find the conflict error
     conflict_error = Enum.find(errors, &(&1["code"] == "invalid_query"))