Skip to content

Commit 67b4d2f

Browse files
committed
style(delta): align @impl with ash_postgres.migrate.ex convention
Review pass: codebase precedent for the `run/1` annotation on a Mix.Task with logic (not a pure delegation shim) is `@impl true` in ash_postgres.migrate.ex. Match that in migrate_snapshots and squash_snapshots, replacing `@impl Mix.Task` which I'd reached for on autopilot. Remaining convention divergence — shim-style tasks like ash_postgres.create.ex use `@doc false` instead of `@impl`, which is its own established pattern for a different class of task. Neither task here fits that class.
1 parent 9082e68 commit 67b4d2f

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/mix/tasks/ash_postgres.migrate_snapshots.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ defmodule Mix.Tasks.AshPostgres.MigrateSnapshots do
4646
quiet: :boolean
4747
]
4848

49-
@impl Mix.Task
49+
@impl true
5050
def run(args) do
5151
{opts, _} = OptionParser.parse!(args, strict: @switches)
5252

lib/mix/tasks/ash_postgres.squash_snapshots.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ defmodule Mix.Tasks.AshPostgres.SquashSnapshots do
5555
* `--include-dev` - include `*_dev.json` files in the squash (default: skip them). Delta-mode squash aborts if dev files are present and this flag is not set.
5656
"""
5757

58-
@impl Mix.Task
58+
@impl true
5959
def run(args) do
6060
{opts, []} = OptionParser.parse!(args, strict: @switches)
6161

0 commit comments

Comments
 (0)