chore: make migraiton tests faster

Author: zachdaniel

.gitignore

@@ -5,6 +5,8 @@
 # The directory Mix will write compiled artifacts to.
 /_build/
 
+/tmp/
+
 # If you run "mix test --cover", coverage assets end up here.
 /cover/
 

lib/migration_generator/migration_generator.ex

@@ -238,14 +238,14 @@ defmodule AshSqlite.MigrationGenerator do
           case to_install do
             [{ext_name, version, _up_fn, _down_fn}] ->
               {"install_#{ext_name}_v#{version}",
-               "#{timestamp(true)}_install_#{ext_name}_v#{version}_extension"}
+               "#{timestamp()}_install_#{ext_name}_v#{version}_extension"}
 
             [single] ->
-              {"install_#{single}", "#{timestamp(true)}_install_#{single}_extension"}
+              {"install_#{single}", "#{timestamp()}_install_#{single}_extension"}
 
             multiple ->
               {"install_#{Enum.count(multiple)}_extensions",
-               "#{timestamp(true)}_install_#{Enum.count(multiple)}_extensions"}
+               "#{timestamp()}_install_#{Enum.count(multiple)}_extensions"}
           end
 
         migration_file =
@@ -855,7 +855,7 @@ defmodule AshSqlite.MigrationGenerator do
 
     {migration_name, last_part} =
       if opts.name do
-        {"#{timestamp(true)}_#{opts.name}", "#{opts.name}"}
+        {"#{timestamp()}_#{opts.name}", "#{opts.name}"}
       else
         count =
           migration_path
@@ -878,7 +878,7 @@ defmodule AshSqlite.MigrationGenerator do
           |> Enum.max(fn -> 0 end)
           |> Kernel.+(1)
 
-        {"#{timestamp(true)}_migrate_resources#{count}", "migrate_resources#{count}"}
+        {"#{timestamp()}_migrate_resources#{count}", "migrate_resources#{count}"}
       end
 
     migration_file =
@@ -2115,12 +2115,34 @@ defmodule AshSqlite.MigrationGenerator do
     end
   end
 
-  defp timestamp(require_unique? \\ false) do
-    # Alright, this is silly I know. But migration ids need to be unique
-    # and "synthesizing" that behavior is significantly more annoying than
-    # just waiting a bit, ensuring the migration versions are unique.
-    if require_unique?, do: :timer.sleep(1500)
+  defp timestamp do
     {{y, m, d}, {hh, mm, ss}} = :calendar.universal_time()
+    current = "#{y}#{pad(m)}#{pad(d)}#{pad(hh)}#{pad(mm)}#{pad(ss)}"
+
+    last = Process.get(:ash_sqlite_last_migration_timestamp)
+
+    result =
+      if last && current <= last do
+        increment_timestamp(last)
+      else
+        current
+      end
+
+    Process.put(:ash_sqlite_last_migration_timestamp, result)
+    result
+  end
+
+  defp increment_timestamp(timestamp) do
+    <<y::binary-4, m::binary-2, d::binary-2, hh::binary-2, mm::binary-2, ss::binary-2>> =
+      timestamp
+
+    seconds =
+      :calendar.datetime_to_gregorian_seconds({
+        {String.to_integer(y), String.to_integer(m), String.to_integer(d)},
+        {String.to_integer(hh), String.to_integer(mm), String.to_integer(ss)}
+      })
+
+    {{y, m, d}, {hh, mm, ss}} = :calendar.gregorian_seconds_to_datetime(seconds + 1)
     "#{y}#{pad(m)}#{pad(d)}#{pad(hh)}#{pad(mm)}#{pad(ss)}"
   end
 

test/dev_migrations_test.exs

@@ -5,10 +5,11 @@
 defmodule AshSqlite.DevMigrationsTest do
   use AshSqlite.RepoCase, async: false
   @moduletag :migration
+  @moduletag :tmp_dir
 
   alias Ecto.Adapters.SQL.Sandbox
 
-  setup do
+  setup %{tmp_dir: tmp_dir} do
     current_shell = Mix.shell()
 
     :ok = Mix.shell(Mix.Shell.Process)
@@ -19,6 +20,11 @@ defmodule AshSqlite.DevMigrationsTest do
 
     Sandbox.checkout(AshSqlite.DevTestRepo)
     Sandbox.mode(AshSqlite.DevTestRepo, {:shared, self()})
+
+    %{
+      snapshot_path: Path.join(tmp_dir, "snapshots"),
+      migration_path: Path.join(tmp_dir, "migrations")
+    }
   end
 
   defmacrop defresource(mod, do: body) do
@@ -103,20 +109,19 @@ defmodule AshSqlite.DevMigrationsTest do
         Enum.each(new_migration_files, &File.rm!(Path.join(migrations_dev_path, &1)))
       end
 
-      # Clean up test directories
-      File.rm_rf!("test_snapshots_path")
-      File.rm_rf!("test_migration_path")
-
       try do
         AshSqlite.DevTestRepo.query!("DROP TABLE IF EXISTS posts")
-      rescue
-        _ -> :ok
+      catch
+        _, _ -> :ok
       end
     end)
   end
 
   describe "--dev option" do
-    test "generates dev migration" do
+    test "generates dev migration", %{
+      snapshot_path: snapshot_path,
+      migration_path: migration_path
+    } do
       defposts do
         attributes do
           uuid_primary_key(:id)
@@ -127,32 +132,35 @@ defmodule AshSqlite.DevMigrationsTest do
       defdomain([Post])
 
       AshSqlite.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        migration_path: "test_migration_path",
+        snapshot_path: snapshot_path,
+        migration_path: migration_path,
         dev: true
       )
 
       assert [dev_file] =
-               Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
+               Path.wildcard("#{migration_path}/**/*_migrate_resources*.exs")
 
       assert String.contains?(dev_file, "_dev.exs")
       contents = File.read!(dev_file)
 
       AshSqlite.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        migration_path: "test_migration_path",
+        snapshot_path: snapshot_path,
+        migration_path: migration_path,
         auto_name: true
       )
 
       assert [file] =
-               Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
+               Path.wildcard("#{migration_path}/**/*_migrate_resources*.exs")
 
       refute String.contains?(file, "_dev.exs")
 
       assert contents == File.read!(file)
     end
 
-    test "removes dev migrations when generating regular migrations" do
+    test "removes dev migrations when generating regular migrations", %{
+      snapshot_path: snapshot_path,
+      migration_path: migration_path
+    } do
       defposts do
         attributes do
           uuid_primary_key(:id)
@@ -164,31 +172,34 @@ defmodule AshSqlite.DevMigrationsTest do
 
       # Generate dev migration first
       AshSqlite.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        migration_path: "test_migration_path",
+        snapshot_path: snapshot_path,
+        migration_path: migration_path,
         dev: true
       )
 
       assert [dev_file] =
-               Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
+               Path.wildcard("#{migration_path}/**/*_migrate_resources*.exs")
 
       assert String.contains?(dev_file, "_dev.exs")
 
       # Generate regular migration - should remove dev migration
       AshSqlite.MigrationGenerator.generate(Domain,
-        snapshot_path: "test_snapshots_path",
-        migration_path: "test_migration_path",
+        snapshot_path: snapshot_path,
+        migration_path: migration_path,
         auto_name: true
       )
 
       # Should only have regular migration now
-      files = Path.wildcard("test_migration_path/**/*_migrate_resources*.exs")
+      files = Path.wildcard("#{migration_path}/**/*_migrate_resources*.exs")
       assert length(files) == 1
       assert [regular_file] = files
       refute String.contains?(regular_file, "_dev.exs")
     end
 
-    test "requires name when not using dev option" do
+    test "requires name when not using dev option", %{
+      snapshot_path: snapshot_path,
+      migration_path: migration_path
+    } do
       defposts do
         attributes do
           uuid_primary_key(:id)
@@ -200,8 +211,8 @@ defmodule AshSqlite.DevMigrationsTest do
 
       assert_raise RuntimeError, ~r/Name must be provided/, fn ->
         AshSqlite.MigrationGenerator.generate(Domain,
-          snapshot_path: "test_snapshots_path",
-          migration_path: "test_migration_path"
+          snapshot_path: snapshot_path,
+          migration_path: migration_path
         )
       end
     end