-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] Review API design for reasonableness #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -62,6 +62,53 @@ pub fn parse_expression(expr: &str) -> Result<ExprAST> { | |||||
| parser::Parser::new(expr)?.parse_stmt() | ||||||
| } | ||||||
|
|
||||||
| /// ## Usage | ||||||
| /// | ||||||
| /// Parse an expression and compile it directly to bytecode without keeping the AST. | ||||||
| /// This is useful when you want to cache the compiled bytecode and execute it multiple times | ||||||
| /// with different contexts, avoiding the parsing and compilation overhead. | ||||||
| /// | ||||||
| /// ``` rust | ||||||
| /// use expression_engine::{parse_expression_to_bytecode, execute_program, create_context, Value}; | ||||||
| /// let input = "a + b * 2"; | ||||||
| /// let program = parse_expression_to_bytecode(input).unwrap(); | ||||||
| /// | ||||||
| /// // Execute the same bytecode program multiple times with different contexts | ||||||
| /// let mut ctx1 = create_context!("a" => 10, "b" => 5); | ||||||
| /// let result1 = execute_program(&program, &mut ctx1).unwrap(); | ||||||
| /// assert_eq!(result1, Value::from(20)); | ||||||
| /// | ||||||
| /// let mut ctx2 = create_context!("a" => 1, "b" => 2); | ||||||
| /// let result2 = execute_program(&program, &mut ctx2).unwrap(); | ||||||
| /// assert_eq!(result2, Value::from(5)); | ||||||
| /// ``` | ||||||
| pub fn parse_expression_to_bytecode(expr: &str) -> Result<bytecode::Program> { | ||||||
| init(); | ||||||
| let ast = parser::Parser::new(expr)?.parse_stmt()?; | ||||||
| bytecode::compile_expression(&ast) | ||||||
| } | ||||||
|
|
||||||
| /// ## Usage | ||||||
| /// | ||||||
| /// Execute a pre-compiled bytecode program with a given context. | ||||||
| /// This function should be used together with `parse_expression_to_bytecode` when you need | ||||||
| /// to execute the same expression multiple times with different contexts, which is more | ||||||
| /// efficient than calling `execute` repeatedly. | ||||||
| /// | ||||||
| /// ``` rust | ||||||
| /// use expression_engine::{parse_expression_to_bytecode, execute_program, create_context, Value}; | ||||||
| /// let input = "x * 2 + y"; | ||||||
| /// let program = parse_expression_to_bytecode(input).unwrap(); | ||||||
| /// | ||||||
| /// let mut ctx = create_context!("x" => 5, "y" => 3); | ||||||
| /// let result = execute_program(&program, &mut ctx).unwrap(); | ||||||
| /// assert_eq!(result, Value::from(13)); | ||||||
| /// ``` | ||||||
| pub fn execute_program(program: &bytecode::Program, ctx: &mut Context) -> Result<value::Value> { | ||||||
|
||||||
| pub fn execute_program(program: &bytecode::Program, ctx: &mut Context) -> Result<value::Value> { | |
| pub fn execute_program(program: &bytecode::Program, ctx: &mut Context) -> Result<Value> { |
ashyanSpada marked this conversation as resolved.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parse_expression_to_bytecodere-implements parsing (Parser::new(...).parse_stmt()) instead of delegating to the existingparse_expressionhelper. This duplicates logic and can drift if parsing behavior or initialization changes. Consider callingparse_expression(expr)?here and then compiling that AST.