fix: TocContoller.jumpToIndex stop working if MarkdoThewnWidget instance is replaced#259
Open
heyteacher wants to merge 5 commits into
Open
fix: TocContoller.jumpToIndex stop working if MarkdoThewnWidget instance is replaced#259heyteacher wants to merge 5 commits into
heyteacher wants to merge 5 commits into
Conversation
…State.dispose and add isDisposed check on jumpToWidgetIndexCallback implementation
…etIndexCallback-unset-on-MarkdownWidgetState.dispose fix: TocContoller.jumpToIndex stop working if MarkdoThewnWidget instance is replaced
…ller Support custom auto scroll controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
TocContoller.jumpToWidgetIndexCallbackunset onMarkdownWidgetState.disposeand addisDisposedcheck onjumpToWidgetIndexCallbackimplementation.This avoid
TocContollerstop working ifMarkdownWidgetis replaced by a new instance and old instance is disposed.This happens for example in adaptive layouts implementation or multi language support, when
MarkdoThewnWidgetis replaced butTocContollerremain the same.The
isDisposedcheck preserve jumpToWidgetIndexCallback invocation after theMarkdoThewnWidgetis disposed,