Skip to content

Commit 24de514

Browse files
Revert "feat: capture unhandled errors in reporter"
This reverts commit 7bd98be.
1 parent 7bd98be commit 24de514

1 file changed

Lines changed: 3 additions & 21 deletions

File tree

src/askui/agent_base.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import logging
22
import time
3-
import traceback as _traceback
43
import types
54
from pathlib import Path
65
from typing import Annotated, Literal, Optional, Type, overload
@@ -872,11 +871,9 @@ def _wait_for_disappear(
872871

873872
@telemetry.record_call()
874873
def close(self) -> None:
875-
try:
876-
self._reporter.generate()
877-
finally:
878-
if self._agent_os is not None:
879-
self._agent_os.disconnect()
874+
if self._agent_os is not None:
875+
self._agent_os.disconnect()
876+
self._reporter.generate()
880877

881878
@telemetry.record_call()
882879
def open(self) -> None:
@@ -895,23 +892,8 @@ def __exit__(
895892
exc_value: BaseException | None,
896893
traceback: types.TracebackType | None,
897894
) -> None:
898-
if exc_value is not None:
899-
self._report_unhandled_error(exc_value, traceback)
900895
self.close()
901896

902-
def _report_unhandled_error(
903-
self,
904-
exc_value: BaseException,
905-
tb: types.TracebackType | None,
906-
) -> None:
907-
try:
908-
formatted = "".join(
909-
_traceback.format_exception(type(exc_value), exc_value, tb)
910-
)
911-
self._reporter.add_message("Error", formatted)
912-
except Exception: # noqa: BLE001
913-
logger.exception("Failed to add unhandled error to reporter")
914-
915897
@staticmethod
916898
def get_default_tools() -> list[Tool]:
917899
return []

0 commit comments

Comments
 (0)