Skip to content

Commit 4445a4c

Browse files
implement review remarks
1 parent fcf2884 commit 4445a4c

4 files changed

Lines changed: 8 additions & 14 deletions

File tree

src/askui/tools/askui/askui_controller.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,11 @@ def connect(self) -> None:
225225
self._start_execution()
226226
self.set_display(self._display)
227227
if self._settings.clean_virtual_displays:
228+
logger.info(
229+
"clean_virtual_displays is enabled. Removing all virtual displays ... "
230+
)
228231
self.remove_virtual_displays()
232+
logger.info("Virtual displays removed.")
229233

230234
def _get_stub(self) -> controller_v1.ControllerAPIStub:
231235
assert isinstance(self._stub, controller_v1.ControllerAPIStub), (
@@ -1395,14 +1399,6 @@ def remove_virtual_displays(self) -> None:
13951399
self._send_command(command)
13961400
self._reporter.add_message("AgentOS", "remove_virtual_displays() -> done")
13971401

1398-
logger.debug(
1399-
(
1400-
"Setting display to 1 to ensure that the "
1401-
"controller is using the real display"
1402-
)
1403-
)
1404-
self.set_display(1)
1405-
14061402
@staticmethod
14071403
def _decode_file_payload(base64_data: str) -> Image.Image | str:
14081404
try:

src/askui/tools/askui/askui_ui_controller_grpc/generated/AgentOS_Send_Request_2501.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,7 @@ class GetFileCommand(BaseModel):
406406

407407
class RemoveVirtualDisplaysCommand(BaseModel):
408408
name: Literal['RemoveVirtualDisplays'] = 'RemoveVirtualDisplays'
409-
parameters: List[Any] = []
409+
parameters: List[str] = Field(default=[], max_length=0)
410410

411411
Command =Union[
412412
GetSystemInfoCommand,

src/askui/tools/store/computer/experimental/get_file.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def __init__(self, agent_os: AgentOs | None = None) -> None:
4949
agent_os=agent_os,
5050
required_tags=[ToolTags.SCALED_AGENT_OS.value],
5151
)
52+
self.is_cacheable = True
5253

5354
def __call__(self, absolute_file_path: str) -> Image.Image | str:
5455
return self.agent_os.get_file(absolute_file_path)

src/askui/tools/store/computer/experimental/remove_virtual_displays.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,11 @@ def __init__(self, agent_os: AgentOs | None = None) -> None:
3434
"add_window_as_virtual_display_tool) to restore a normal setup before "
3535
"continuing automation."
3636
),
37-
input_schema={
38-
"type": "object",
39-
"properties": {},
40-
"required": [],
41-
},
4237
agent_os=agent_os,
4338
)
4439

40+
self.is_cacheable = True
41+
4542
def __call__(self) -> str:
4643
self.agent_os.remove_virtual_displays()
4744
return "Removed virtual displays; only physical displays remain active."

0 commit comments

Comments
 (0)