Skip to content

Commit 8bb72f9

Browse files
implement review remarks
1 parent 198381c commit 8bb72f9

4 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/askui/tools/store/universal/get_current_time.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def __init__(self) -> None:
3131
name="get_current_time_tool",
3232
description=(
3333
"Returns the current date and time in the local timezone. "
34-
"Use when you need to know the current time for scheduling, "
34+
"Use this tool when you need to know the current time for scheduling, "
3535
"logging, or time-dependent decisions."
3636
),
3737
input_schema={

src/askui/tools/store/universal/wait_tool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class WaitTool(Tool):
3030
```
3131
"""
3232

33-
def __init__(self, max_wait_time: int = 60 * 60) -> None:
33+
def __init__(self, max_wait_time: int = 10 * 60) -> None:
3434
if max_wait_time < 1:
3535
msg = "Max wait time must be at least 1 second"
3636
raise ValueError(msg)

src/askui/tools/store/universal/wait_until_condition_tool.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def __init__(
4949
self,
5050
condition_check: Callable[[], bool],
5151
description: str,
52-
max_wait_time: float = 60 * 60,
52+
max_wait_time: int = 60 * 60,
5353
) -> None:
5454
if max_wait_time < 1:
5555
msg = "Max wait time must be at least 1 second"
@@ -69,6 +69,7 @@ def __init__(
6969
"description": (
7070
"Maximum time to wait in seconds before giving up."
7171
),
72+
"minimum": 1,
7273
"maximum": int(max_wait_time),
7374
},
7475
"check_interval": {
@@ -78,6 +79,7 @@ def __init__(
7879
"(e.g. 5 for every 5 seconds). Must be at least 1."
7980
),
8081
"minimum": 1,
82+
"maximum": int(max_wait_time),
8183
},
8284
},
8385
"required": ["max_wait_time"],

src/askui/tools/store/universal/wait_with_progress_tool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class WaitWithProgressTool(Tool):
2929
```
3030
"""
3131

32-
def __init__(self, max_wait_time: int = 60 * 60) -> None:
32+
def __init__(self, max_wait_time: int = 10 * 60) -> None:
3333
if max_wait_time < 1:
3434
msg = "Max wait time must be at least 1 second"
3535
raise ValueError(msg)

0 commit comments

Comments
 (0)