Skip to content

Commit f3ca227

Browse files
fix: make tracing span names consistent with function names
1 parent efe0624 commit f3ca227

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/askui/models/shared/conversation.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def _on_tool_execution_end(self, tool_names: list[str]) -> None:
141141
for callback in self._callbacks:
142142
callback.on_tool_execution_end(self, tool_names)
143143

144-
@tracer.start_as_current_span("conversation")
144+
@tracer.start_as_current_span("execute_conversation")
145145
def execute_conversation(
146146
self,
147147
messages: list[MessageParam],
@@ -171,7 +171,7 @@ def execute_conversation(
171171

172172
self._conclude_control_loop()
173173

174-
@tracer.start_as_current_span("setup_control_loop")
174+
@tracer.start_as_current_span("_setup_control_loop")
175175
def _setup_control_loop(
176176
self,
177177
messages: list[MessageParam],
@@ -201,7 +201,7 @@ def _setup_control_loop(
201201
)
202202
)
203203

204-
@tracer.start_as_current_span("control_loop")
204+
@tracer.start_as_current_span("_execute_control_loop")
205205
def _execute_control_loop(self) -> None:
206206
self._on_control_loop_start()
207207
self._step_index = 0
@@ -210,7 +210,7 @@ def _execute_control_loop(self) -> None:
210210
continue_execution = self._execute_step()
211211
self._on_control_loop_end()
212212

213-
@tracer.start_as_current_span("finish_control_loop")
213+
@tracer.start_as_current_span("_conclude_control_loop")
214214
def _conclude_control_loop(self) -> None:
215215
# Finish recording if cache_manager is active and not executing from cache
216216
if self.cache_manager is not None and not self._executed_from_cache:
@@ -261,7 +261,7 @@ def _build_speaker_descriptions(self) -> str:
261261
descriptions.append(f"### {speaker.get_name()}\n{description}")
262262
return "\n\n".join(descriptions)
263263

264-
@tracer.start_as_current_span("step")
264+
@tracer.start_as_current_span("_execute_step")
265265
def _execute_step(self) -> bool:
266266
"""Execute one step of the conversation loop with speakers.
267267
@@ -313,7 +313,7 @@ def _execute_step(self) -> bool:
313313

314314
return continue_loop
315315

316-
@tracer.start_as_current_span("execute_tool_call")
316+
@tracer.start_as_current_span("_execute_tools_if_present")
317317
def _execute_tools_if_present(self, message: MessageParam) -> MessageParam | None:
318318
"""Execute tools if the message contains tool use blocks.
319319
@@ -370,7 +370,7 @@ def _add_message(self, message: MessageParam) -> None:
370370
self.current_speaker.get_name(), message.model_dump(mode="json")
371371
)
372372

373-
@tracer.start_as_current_span("handle_result_status")
373+
@tracer.start_as_current_span("_handle_result_status")
374374
def _handle_result_status(self, result: SpeakerResult) -> bool:
375375
"""Handle speaker result status and determine if loop should continue.
376376

0 commit comments

Comments
 (0)