Skip to content

Fix: Add messages to reporter if crashing during truncation #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipph-askui merged 3 commits into from
May 12, 2026
Merged

Fix: Add messages to reporter if crashing during truncation #274

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc32427
fix: make sure we report to reporter before adding messages to trunca…
philipph-askui May 11, 2026
f1e8ec0
fix: report truncation errors to reporter before re-raising
philipph-askui May 12, 2026
9589a61
feat: add logging message if truncation fails
philipph-askui May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/askui/models/shared/conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,18 +371,18 @@ def _add_message(self, message: MessageParam) -> None:
Args:
message: Message to add
"""
# Report to reporter
self._reporter.add_message(
self.current_speaker.name, message.model_dump(mode="json")
)

if not self._truncation_strategy:
logger.error("No truncation strategy, cannot add message")
return

# Add to truncation strategy
self._truncation_strategy.append_message(message)

# Report to reporter
self._reporter.add_message(
self.current_speaker.name, message.model_dump(mode="json")
)

@tracer.start_as_current_span("_handle_continue_conversation")
def _handle_continue_conversation(self, result: SpeakerResult) -> bool:
"""Handle speaker result status and determine if loop should continue.
Expand Down
Loading