Skip to content

Commit b93c374

Browse files
authored
Fix renovates config, root package.json commands (dotansimha#10835)
* Clean up renovate.json * Correctly name dev-tests to distinguish against example tests * Remove watch-build as it brings in an untracked devDep tsc-watch. If anyone uses this command, lets review the modern way to do this
1 parent 2cb0f21 commit b93c374

3 files changed

Lines changed: 13 additions & 17 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ jobs:
2222
name: Linting Check
2323
uses: the-guild-org/shared-config/.github/workflows/lint.yml@f4eea983237a44bb0ca19c3348dacbfdfcdbec23 # main
2424
with:
25-
script: pnpm ci:lint
25+
script: pnpm lint:ci
2626
packageManager: pnpm
2727
secrets:
2828
githubToken: ${{ secrets.GITHUB_TOKEN }}
29+
2930
prettier-check:
3031
name: 🧹 Prettier Check
3132
runs-on: ubuntu-latest
@@ -47,7 +48,7 @@ jobs:
4748
- name: Prettier Check
4849
run: pnpm prettier:check
4950

50-
dev-tests-old:
51+
dev-tests:
5152
name: Validating dev-tests
5253
runs-on: ubuntu-latest
5354
strategy:
@@ -76,10 +77,10 @@ jobs:
7677
CI: true
7778
- name: Test dev-tests ${{matrix.method}}
7879
run: |
79-
pnpm run generate:examples:${{matrix.method}}
80+
pnpm run dev-test:generate:${{matrix.method}}
8081
git diff --exit-code -- dev-test/
8182
82-
dev-tests:
83+
examples-tests:
8384
name: Examples - Normal
8485
runs-on: ubuntu-latest
8586
steps:

package.json

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,27 @@
1010
"prebuild": "rimraf dist/ .bob/ tsconfig.tsbuildinfo",
1111
"build": "bob build",
1212
"postbuild": "pnpm fix-bins",
13-
"ci:lint": "eslint --cache --output-file eslint_report.json --format json .",
1413
"clean": "rimraf node_modules/",
14+
"dev-test:generate": "pnpm generate:examples:esm",
15+
"dev-test:generate:cjs": "node packages/graphql-codegen-cli/dist/cjs/bin.js --require dotenv/config --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
16+
"dev-test:generate:esm": "node packages/graphql-codegen-cli/dist/esm/bin.js --require dotenv/config --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
17+
"dev-test:watch": "pnpm watch:examples:esm",
18+
"dev-test:watch:cjs": "node packages/graphql-codegen-cli/dist/cjs/bin.js --require dotenv/config --watch --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
19+
"dev-test:watch:esm": "node packages/graphql-codegen-cli/dist/esm/bin.js --require dotenv/config --watch --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
1520
"examples:build": "set -o xtrace && eval $(node scripts/print-example-ci-command.js build)",
1621
"examples:codegen": "set -o xtrace && eval $(node scripts/print-example-ci-command.js codegen)",
1722
"examples:test:end2end": "set -o xtrace && eval $(node scripts/print-example-ci-command.js test:end2end)",
1823
"fix-bins": "node scripts/fix-bin.js",
19-
"generate:examples": "pnpm generate:examples:esm",
20-
"generate:examples:cjs": "node packages/graphql-codegen-cli/dist/cjs/bin.js --require dotenv/config --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
21-
"generate:examples:esm": "node packages/graphql-codegen-cli/dist/esm/bin.js --require dotenv/config --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
2224
"postinstall": "husky install",
2325
"lint": "eslint --cache .",
26+
"lint:ci": "eslint --cache --output-file eslint_report.json --format json .",
2427
"prettier": "prettier --cache --write --list-different .",
2528
"prettier:check": "prettier --cache --check .",
2629
"rebuild": "bob build --incremental",
2730
"prerelease": "pnpm build",
2831
"release": "changeset publish",
2932
"test": "vitest",
30-
"types:check": "tsc --noEmit",
31-
"watch-build": "npx tsc-watch --project tsconfig.json --onSuccess \"bob build\"",
32-
"watch:examples": "pnpm watch:examples:esm",
33-
"watch:examples:cjs": "node packages/graphql-codegen-cli/dist/cjs/bin.js --require dotenv/config --watch --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env",
34-
"watch:examples:esm": "node packages/graphql-codegen-cli/dist/esm/bin.js --require dotenv/config --watch --config ./dev-test/codegen.ts dotenv_config_path=dev-test/.env"
33+
"types:check": "tsc --noEmit"
3534
},
3635
"devDependencies": {
3736
"@babel/core": "7.29.0",

renovate.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
"enabled": true,
99
"automerge": true
1010
},
11-
"lockFileMaintenance": {
12-
"enabled": true,
13-
"automerge": true
14-
},
1511
"packageRules": [
1612
{
1713
"excludePackagePatterns": [

0 commit comments

Comments
 (0)