Revert "fix: produce starlark_doc_extract rules for public API" (#2710)

Reverts #2703

It didn't work because this repo relies on private/ bzl files to give
documentation on npm_translate_lock, among others.

Also we don't want the examples to have documentation generated. See
https://registry.bazel.build/docs/aspect_rules_js/3.0.0-rc3 which was
wrong 😓

Author: alexeagle

contrib/nextjs/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -18,3 +18,9 @@ bzl_library(
         "@bazel_lib//lib:directory_path",
     ],
 )
+
+starlark_doc_extract(
+    name = "defs.doc_extract",
+    src = "defs.bzl",
+    deps = [":defs"],
+)

docs/README.md

@@ -331,7 +331,7 @@ Continuing our example, where we wrote a macro in `tsc.bzl`, we'd write this to
 
 ```starlark
 load("@bazel_lib//lib:docs.bzl", "stardoc_with_diff_test", "update_docs")
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 bzl_library(
     name = "tsc",

examples/js_library/two/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@aspect_rules_js//js:defs.bzl", "js_test")
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load(":tsc.bzl", "tsc")
 
 tsc(

examples/macro/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 load("//examples/macro:mocha.bzl", "mocha_test")
 

js/BUILD.bazel

@@ -1,6 +1,6 @@
 "Public API"
 
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 exports_files(
     glob(["*.bzl"]),

js/private/BUILD.bazel

@@ -1,6 +1,6 @@
 "Internal implementation details"
 
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -24,6 +24,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "js_info_files.doc_extract",
+    src = "js_info_files.bzl",
+    deps = [":js_info_files"],
+)
+
 bzl_library(
     name = "js_binary",
     srcs = ["js_binary.bzl"],
@@ -40,6 +46,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "js_binary.doc_extract",
+    src = "js_binary.bzl",
+    deps = [":js_binary"],
+)
+
 bzl_library(
     name = "js_helpers",
     srcs = ["js_helpers.bzl"],
@@ -62,6 +74,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "js_library.doc_extract",
+    src = "js_library.bzl",
+    deps = [":js_library"],
+)
+
 bzl_library(
     name = "js_run_binary",
     srcs = ["js_run_binary.bzl"],
@@ -75,6 +93,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "js_run_binary.doc_extract",
+    src = "js_run_binary.bzl",
+    deps = [":js_run_binary"],
+)
+
 bzl_library(
     name = "js_run_devserver",
     srcs = ["js_run_devserver.bzl"],
@@ -86,6 +110,13 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "js_run_devserver.doc_extract",
+    src = "js_run_devserver.bzl",
+    symbol_names = ["js_run_devserver"],
+    deps = [":js_run_devserver"],
+)
+
 bzl_library(
     name = "js_info",
     srcs = ["js_info.bzl"],
@@ -107,3 +138,9 @@ bzl_library(
         "@tar.bzl//tar",
     ],
 )
+
+starlark_doc_extract(
+    name = "js_image_layer.doc_extract",
+    src = "js_image_layer.bzl",
+    deps = [":js_image_layer"],
+)

npm/BUILD.bazel

@@ -1,6 +1,6 @@
 "Public API"
 
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 exports_files(
     glob(["*.bzl"]),

npm/private/BUILD.bazel

@@ -1,8 +1,8 @@
 "Internal implementation details"
 
 load("@aspect_rules_js//js:defs.bzl", "js_library")
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
 load("@bazel_lib//lib:testing.bzl", "assert_contains")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -47,6 +47,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "npm_package.doc_extract",
+    src = "npm_package.bzl",
+    deps = [":npm_package"],
+)
+
 bzl_library(
     name = "npm_link_package",
     srcs = ["npm_link_package.bzl"],
@@ -57,6 +63,12 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "npm_link_package.doc_extract",
+    src = "npm_link_package.bzl",
+    deps = [":npm_link_package"],
+)
+
 bzl_library(
     name = "npm_link_package_store",
     srcs = ["npm_link_package_store.bzl"],
@@ -103,6 +115,13 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "npm_import.doc_extract",
+    src = "npm_import.bzl",
+    symbol_names = ["npm_import"],
+    deps = [":npm_import"],
+)
+
 bzl_library(
     name = "npm_translate_lock_generate",
     srcs = ["npm_translate_lock_generate.bzl"],
@@ -173,6 +192,16 @@ bzl_library(
     ],
 )
 
+starlark_doc_extract(
+    name = "npm_translate_lock.doc_extract",
+    src = "npm_translate_lock.bzl",
+    symbol_names = [
+        "list_patches",
+        "npm_translate_lock",
+    ],
+    deps = [":npm_translate_lock"],
+)
+
 bzl_library(
     name = "utils",
     srcs = ["utils.bzl"],

platforms/pnpm/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@bazel_lib//:bzl_library.bzl", "bzl_library")
+load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
 load(":index.bzl", "PNPM_ARCHS", "PNPM_PLATFORMS")
 
 # Constraints representing the pnpm [os] and [cpu] fields.