docs: emphasize use of js_library over npm_package

Author: jbedard

docs/migrate_2.md

@@ -31,7 +31,7 @@ def npm_link_package(
         root_package: the root package where the node_modules package store is linked to
         link: whether or not to link in this package
             If false, only the npm_package_store target will be created _if_ this is called in the `root_package`.
-        src: the npm_package target to link; may only to be specified when linking in the root package
+        src: the target to link; may only to be specified when linking in the root package
         deps: list of npm_package_store; may only to be specified when linking in the root package
         fail_if_no_link: whether or not to fail if this is called in a package that is not the root package and `link` is False
         auto_manual: whether or not to automatically add a manual tag to the generated targets

docs/npm_link_package.md

@@ -180,9 +180,9 @@ def _npm_package_store_impl(ctx):
         version = ctx.attr.version
 
     if not package:
-        fail("No package name specified to link to. Package name must either be specified explicitly via 'package' attribute or come from the 'src' 'NpmPackageInfo', typically a 'npm_package' target")
+        fail("No package name specified to link to. Package name must either be specified explicitly via 'package' attribute or come from the 'src' 'JsInfo|NpmPackageInfo', typically a 'js_library|npm_package' target")
     if not version:
-        fail("No package version specified to link to. Package version must either be specified explicitly via 'version' attribute or come from the 'src' 'NpmPackageInfo', typically a 'npm_package' target")
+        fail("No package version specified to link to. Package version must either be specified explicitly via 'version' attribute or come from the 'src' 'JsInfo|NpmPackageInfo', typically a 'js_library|npm_package' target")
 
     package_store_name = utils.package_store_name(package, version)
     package_store_directory = None

docs/npm_translate_lock.md

@@ -445,18 +445,20 @@ def npm_translate_lock(
 
             Read more: [lifecycles](/docs/pnpm.md#lifecycles)
 
-        replace_packages: A dict of package names to npm_package targets to link instead of the sources specified in the pnpm lock file for the corresponding packages.
+        replace_packages: A dict of package names to targets to link instead of the sources specified in the pnpm lock file for the corresponding packages.
 
-            The injected npm_package targets may optionally contribute transitive npm package dependencies on top
+            Targets must produce `JsInfo` or `NpmPackageInfo` providers such as `js_library` or `npm_package` targets.
+
+            The injected package targets may optionally contribute transitive npm package dependencies on top
             of the transitive dependencies specified in the pnpm lock file for their respective packages, however, these
             transitive dependencies must not collide with pnpm lock specified transitive dependencies.
 
-            Any patches specified for the packages will be not applied to the injected npm_package targets. They
+            Any patches specified for the packages will be not applied to the injected package targets. They
             will be applied, however, to the fetches sources for their respecitve packages so they can still be useful
             for patching the fetched `package.json` files, which are used to determine the generated bin entries for packages.
 
             NB: lifecycle hooks and custom_postinstall scripts, if implicitly or explicitly enabled, will be run on
-            the injected npm_package targets. These may be disabled explicitly using the `lifecycle_hooks` attribute.
+            the injected package targets. These may be disabled explicitly using the `lifecycle_hooks` attribute.
 
         bins: Binary files to create in `node_modules/.bin` for packages in this lock file.
 
@@ -553,7 +555,7 @@ def npm_translate_lock(
 
         use_pnpm: label of the pnpm entry point to use.
 
-        npm_package_target_name: The name of linked `npm_package`, `js_library` or `JsInfo` producing targets.
+        npm_package_target_name: The name of linked `js_library`, `npm_package` or `JsInfo` producing targets.
 
             When targets are linked as pnpm workspace packages, the name of the target must align with this value.