Skip to content

Commit f62a25e

Browse files
authored
feat: add package exclusion presets, enable default exclusion list (#2652)
This allows us to define multiple "exclude presets" such as the existing `yarn_autoclean` list, but also a less aggressive one that we can enable by default and possibly others for different use cases or strictness. ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): yes - Suggested release notes appear below: yes The default package content exclusion via `npm_exclude_package_contents(use_defaults=True)` is now done using `npm_exclude_package_contents(presets = ["yarn_autoclean"])`. A simpler `"basic"` preset is available and enabled by default for all packages unless overridden by a custom `npm_exclude_package_contents(patterns|presets)`. ### Test plan - Covered by existing test cases - New test cases added
1 parent 22d81a7 commit f62a25e

34 files changed

Lines changed: 209 additions & 140 deletions

MODULE.bazel

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,12 +287,6 @@ npm.npm_translate_lock(
287287
npmrc = "//:.npmrc",
288288
pnpm_lock = "//:pnpm-lock.yaml",
289289
)
290-
291-
# Configure package exclusions using tag class
292-
npm.npm_exclude_package_contents(
293-
package = "chalk",
294-
patterns = ["**/README*"],
295-
)
296290
use_repo(
297291
npm,
298292
"npm",

e2e/gyp_no_install_script/snapshots/segfault-handler_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/npm_translate_lock_disable_hooks/snapshots/aspect_test_c_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/npm_translate_lock_exclude_package_contents/MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ npm.npm_translate_lock(
2323
)
2424
npm.npm_exclude_package_contents(
2525
package = "*",
26-
use_defaults = True,
26+
presets = ["yarn_autoclean"],
2727
)
2828
npm.npm_exclude_package_contents(
2929
package = "is-odd@3.0.1",
3030
patterns = [
3131
"**/README*",
3232
"**/LICENSE*",
3333
],
34-
use_defaults = True,
34+
presets = ["yarn_autoclean"],
3535
)
3636
use_repo(npm, "npm")

e2e/pnpm_lockfiles/v101/snapshots/aspect_test_a_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/aspect_test_b_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/aspect_test_c_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/esbuild_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/lodash-4.17.21_tgz_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/rollup_links_defs.bzl

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)