fix: symlinks in js_image_layer sources by jbedard · Pull Request #2851 · aspect-build/rules_js

jbedard · 2026-05-20T00:38:29Z

Source symlinks were being skipped and mapped as regular files.

Changes are visible to end-users: no

Test plan

Covered by existing test cases
New test cases added

aspect-workflows · 2026-05-20T00:38:37Z

Bazel 7 (Test)

262 test targets passed

Targets

//:npm_link_targets_test [k8-fastbuild]                                                                 98ms
//js/private/devserver:watch_checked_test [k8-fastbuild]                                                46ms
//js/private/test/create_launcher:test [k8-fastbuild]                                                   138ms
//js/private/test/data:chdir-source-data-relative [k8-fastbuild]                                        186ms
//js/private/test/data:extract-write-generated [k8-fastbuild]                                           25ms
//js/private/test/data:extract-write-js_library-data [k8-fastbuild]                                     29ms
//js/private/test/data:from-data [k8-fastbuild]                                                         179ms
//js/private/test/data:from-filegroup-srcs [k8-fastbuild]                                               227ms
//js/private/test/data:from-genrule [k8-fastbuild]                                                      191ms
//js/private/test/data:from-js_run_binary-srcs [k8-fastbuild]                                           103ms
//js/private/test/data:from-parent-genrule [k8-fastbuild]                                               234ms
//js/private/test/data:from-parent-js_library-data [k8-fastbuild]                                       138ms
//js/private/test/data:source-data-rootpath [k8-fastbuild]                                              155ms
//js/private/test/fixed_args:args_test [k8-fastbuild]                                                   65ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_just_the_fs_patch_test [k8-fastbuild] 33ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_node_modules_test [k8-fastbuild]      52ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_node_test [k8-fastbuild]              46ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_package_store_1p_test [k8-fastbuild]  33ms
//js/private/test/image/non_ascii:assert_custom_layer_groups_test_package_store_3p_test [k8-fastbuild]  46ms
//js/private/test/image:assert_custom_layers_nomatch_test_app_test [k8-fastbuild]                       72ms
//js/private/test/image:assert_custom_layers_nomatch_test_package_store_3p_test [k8-fastbuild]          56ms
//js/private/test/image:assert_custom_owner_test_node_test [k8-fastbuild]                               49ms
//js/private/test/image:assert_default_test_app_test [k8-fastbuild]                                     46ms
//js/private/test/image:assert_default_test_node_test [k8-fastbuild]                                    37ms
//js/private/test/image:assert_default_test_package_store_3p_test [k8-fastbuild]                        44ms
//js/private/test/image:assert_regex_edge_cases_test_node_modules_test [k8-fastbuild]                   50ms
//js/private/test/image:assert_regex_edge_cases_test_node_test [k8-fastbuild]                           65ms
//js/private/test/image:assert_symlinks_test_app_test [k8-fastbuild]                                    61ms
//js/private/test/image:assert_symlinks_test_node_test [k8-fastbuild]                                   39ms
//js/private/test/image:assert_symlinks_test_package_store_1p_test [k8-fastbuild]                       71ms
//js/private/test/js_binary_sh:BAZEL_BINDIR_change_directory_test [k8-fastbuild]                        76ms
//js/private/test/js_binary_sh:BAZEL_TARGET_NAME_test [k8-fastbuild]                                    115ms
//js/private/test/js_binary_sh:BAZEL_WORKSPACE_test [k8-fastbuild]                                      87ms
//js/private/test/js_binary_sh:JS_BINARY__WORKSPACE_test [k8-fastbuild]                                 96ms
//js/private/test/js_binary_sh:env_json_encode_launcher_escaped [k8-fastbuild]                          117ms
//js/private/test/js_binary_sh:env_json_obj_launcher_escaped [k8-fastbuild]                             72ms
//js/private/test/js_binary_sh:env_json_obj_value [k8-fastbuild]                                        77ms
//js/private/test/js_binary_sh:env_json_value [k8-fastbuild]                                            81ms
//js/private/test/js_binary_sh:regexy-args-1 [k8-fastbuild]                                             66ms
//js/private/test/js_run_devserver:js_run_devserver_test [k8-fastbuild]                                 144ms
//js/private/test/node-patches:escape_nodejs_test [k8-fastbuild]                                        105ms
//js/private/test/node-patches:lstat_node20_cjs_test [k8-fastbuild]                                     185ms
//js/private/test/node-patches:lstat_node24_cjs_test [k8-fastbuild]                                     135ms
//js/private/test/node-patches:opendir_node20_cjs_test [k8-fastbuild]                                   207ms
//js/private/test/node-patches:opendir_node22_cjs_test [k8-fastbuild]                                   184ms
//js/private/test/node-patches:opendir_nodejs_test [k8-fastbuild]                                       165ms
//js/private/test/node-patches:readdir_node24_cjs_test [k8-fastbuild]                                   172ms
//js/private/test/node-patches:readdir_nodejs_test [k8-fastbuild]                                       171ms
//js/private/test/node-patches:readlink_node20_cjs_test [k8-fastbuild]                                  152ms
//js/private/test/node-patches:readlink_nodejs_cjs_test [k8-fastbuild]                                  139ms
//js/private/test/node-patches:realpath_node20_cjs_test [k8-fastbuild]                                  201ms
//js/private/test/node-patches:realpath_node22_cjs_test [k8-fastbuild]                                  149ms
//js/private/test:main_toolchain_20 [k8-fastbuild]                                                      120ms
//js/private/test:run_environment_info_tests_test_both_subject [k8-fastbuild]                           120ms
//js/private/test:run_environment_info_tests_test_inherit_only_subject [k8-fastbuild]                   120ms
//js/private/test:run_environment_info_tests_test_inherit_only_test [k8-fastbuild]                      72ms
//js/private/test:srcs_not_in_runfiles_test [k8-fastbuild]                                              41ms
//js/private/test:transitive_type_deps_empty_srcs_test [k8-fastbuild]                                   64ms
//js/private/test:transitive_type_deps_test [k8-fastbuild]                                              28ms
//js/private/watch:watch_checked_1_test [k8-fastbuild]                                                  43ms
//npm/private/lifecycle/min:write_min_test [k8-fastbuild]                                               29ms
//npm/private/test/npm_package:test_pkg_2 [k8-fastbuild]                                                55ms
//npm/private/test/npm_package:test_pkg_4 [k8-fastbuild]                                                59ms
//npm/private/test/npm_package:test_pkg_5 [k8-fastbuild]                                                56ms
//npm/private/test/npm_package:test_pkg_6 [k8-fastbuild]                                                43ms
//npm/private/test/subs:require_non-importers_test [k8-fastbuild]                                       95ms
//npm/private/test/subs:subs_test [k8-fastbuild]                                                        40ms
//npm/private/test:npm_auth_tests_test_1 [k8-fastbuild]                                                 73ms
//npm/private/test:npm_auth_tests_test_3 [k8-fastbuild]                                                 88ms
//npm/private/test:test_generated_pkg_json___rollup-binary__entry_point_tagged_manual [k8-fastbuild]    92ms
//npm/private/test:test_generated_pkg_json___rollup-target__js_binary_tagged_manual [k8-fastbuild]      90ms
//npm/private/test:test_generated_pkg_json___rollup-target_js_info_files_tagged_manual [k8-fastbuild]   60ms
//npm/private/test:test_generated_pkg_json___rollup-target_runfiles_lib_tagged_manual [k8-fastbuild]    86ms
//npm/private/test:test_npm_package_visibility_test_10 [k8-fastbuild]                                   97ms
//npm/private/test:test_npm_package_visibility_test_13 [k8-fastbuild]                                   88ms
//npm/private/test:test_npm_package_visibility_test_3 [k8-fastbuild]                                    91ms
//npm/private/test:test_npm_package_visibility_test_4 [k8-fastbuild]                                    77ms
//npm/private/test:test_npm_package_visibility_test_5 [k8-fastbuild]                                    87ms
//npm/private/test:test_npm_package_visibility_test_7 [k8-fastbuild]                                    90ms
//npm/private/test:test_npm_package_visibility_test_9 [k8-fastbuild]                                    103ms
//npm/private/test:test_npmrc_test_2 [k8-fastbuild]                                                     73ms
//npm/private/test:test_npmrc_test_4 [k8-fastbuild]                                                     75ms
//npm/private/test:test_npmrc_test_6 [k8-fastbuild]                                                     58ms
//npm/private/test:test_parse_pnpm_lock_test_0 [k8-fastbuild]                                           63ms
//npm/private/test:test_pnpm_test_2 [k8-fastbuild]                                                      74ms
//npm/private/test:test_pnpm_test_6 [k8-fastbuild]                                                      226ms
//npm/private/test:test_pnpm_test_7 [k8-fastbuild]                                                      103ms
//npm/private/test:test_transitive_closure_test_1 [k8-fastbuild]                                        65ms
//npm/private/test:test_translate_lock_test_0 [k8-fastbuild]                                            71ms
//npm/private/test:test_translate_lock_test_2 [k8-fastbuild]                                            80ms
//npm/private/test:test_translate_lock_test_4 [k8-fastbuild]                                            66ms
//npm/private/test:test_utils_test_0 [k8-fastbuild]                                                     86ms
//npm/private/test:test_utils_test_1 [k8-fastbuild]                                                     88ms
//npm/private/test:test_utils_test_3 [k8-fastbuild]                                                     68ms
//npm/private/test:test_utils_test_5 [k8-fastbuild]                                                     70ms
//npm/private/test:test_utils_test_6 [k8-fastbuild]                                                     186ms
//npm/private/test:write_npm_translate_lock_3_test [k8-fastbuild]                                       144ms
//npm/private/test:write_npm_translate_lock_7_test [k8-fastbuild]                                       154ms
//npm/private/test:write_npm_translate_lock_9_test [k8-fastbuild]                                       78ms
//tools:preset.update_test [k8-fastbuild]                                                               145ms
+ 162 other targets

Bazel 8 (Test)

All tests were cache hits

217 tests (100.0%) were fully cached saving 27s.

Bazel 9 (Test)

All tests were cache hits

217 tests (100.0%) were fully cached saving 30s.

Bazel 7 (Test)

e2e/bzlmod

7 test targets passed

Targets

//:check_styles [k8-fastbuild]                                                                          174ms
//:jasmine_test [k8-fastbuild]                                                                          143ms
//:node_modules_test [k8-fastbuild]                                                                     33ms
//:other_module_binary_test [k8-fastbuild]                                                              62ms
//:other_module_linked_packages [k8-fastbuild]                                                          53ms
//:other_module_run_binary_test [k8-fastbuild]                                                          62ms
//:test [k8-fastbuild]                                                                                  87ms

Bazel 8 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 642ms.

Bazel 9 (Test)

e2e/bzlmod

All tests were cache hits

7 tests (100.0%) were fully cached saving 596ms.

Bazel 7 (Test)

e2e/git_dep_metadata

1 test target passed

Targets

//:no_git_metadata_test                                                                                 24ms

Bazel 8 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Bazel 9 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 7 (Test)

e2e/gyp_no_install_script

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                  75ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                  87ms

Bazel 8 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Bazel 9 (Test)

e2e/gyp_no_install_script

All tests were cache hits

1 test (100.0%) was fully cached saving 46ms.

Bazel 7 (Test)

e2e/js_binary_workspace

4 test targets passed

Targets

//:js_run_binary_chdir_test [k8-fastbuild]                                                              50ms
//:test [k8-fastbuild]                                                                                  49ms
@@workspace~//:js_binary_chdir_test [k8-fastbuild]                                                      78ms
@@workspace~//:js_test_chdir_test [k8-fastbuild]                                                        191ms

Bazel 8 (Test)

e2e/js_binary_workspace

All tests were cache hits

4 tests (100.0%) were fully cached saving 226ms.

Bazel 9 (Test)

e2e/js_binary_workspace

All tests were cache hits

4 tests (100.0%) were fully cached saving 238ms.

Bazel 8 (Test)

e2e/js_image_oci

Waiting for runner...

Bazel 9 (Test)

e2e/js_image_oci

Waiting for runner...

Bazel-7

e2e/js_image_oci

⚠️ Buildkite build #12741 failed.

@@protobuf~//build_defs:config_msvc failed to build

errors encountered resolving select() keys for @@protobuf~//build_defs:config_msvc

@@protobuf~//:protoc failed to build

errors encountered resolving select() keys for @@protobuf~//:protoc

💡 To reproduce the build failures, run

bazel build @@protobuf~//build_defs:config_msvc @@protobuf~//:protoc

Bazel 7 (Test)

e2e/nextjs

3 test targets passed

Targets

//v15/cjs:test [k8-fastbuild]                                                                           40ms
//v15/esm:test [k8-fastbuild]                                                                           33ms
//v15/mjs:test [k8-fastbuild]                                                                           43ms

Bazel 8 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 94ms.

Bazel 9 (Test)

e2e/nextjs

All tests were cache hits

3 tests (100.0%) were fully cached saving 112ms.

Bazel 7 (Test)

e2e/npm_link_package

4 test targets passed

Targets

//cjs/src:test [k8-fastbuild]                                                                           160ms
//cjs:package_store_targets_test [k8-fastbuild]                                                         60ms
//esm/src:test [k8-fastbuild]                                                                           180ms
//esm:package_store_targets_test [k8-fastbuild]                                                         57ms

Bazel 8 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 363ms.

Bazel 9 (Test)

e2e/npm_link_package

All tests were cache hits

4 tests (100.0%) were fully cached saving 415ms.

Bazel 7 (Test)

e2e/npm_link_package-rerooted

2 test targets passed

Targets

//root/src:test [k8-fastbuild]                                                                          119ms
//root:package_store_targets_test [k8-fastbuild]                                                        27ms

Bazel 8 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 139ms.

Bazel 9 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 186ms.

Bazel 7 (Test)

e2e/npm_translate_lock

3 test targets passed

Targets

//:test                                                                                                 47ms
//:test_dev_filtering                                                                                   140ms
//:test_prod_filtering                                                                                  156ms

Bazel 8 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 287ms.

Bazel 9 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 289ms.

Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

3 test targets passed

Targets

//:test [k8-fastbuild]                                                                                  31ms
//:write_npm_translate_lock_defs_0_test [k8-fastbuild]                                                  91ms
//:write_npm_translate_lock_defs_1_test [k8-fastbuild]                                                  84ms

Bazel 8 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/npm_translate_lock_empty

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                  20ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                  73ms

Bazel 8 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 114ms.

Bazel 9 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 105ms.

Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

1 test target passed

Targets

//:test_sh                                                                                              27ms

Bazel 8 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 21ms.

Bazel 9 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 86ms.

Bazel 7 (Test)

e2e/npm_translate_lock_multi

2 test targets passed

Targets

//app1:test                                                                                             55ms
//app2:test                                                                                             49ms

Bazel 8 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 54ms.

Bazel 9 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 113ms.

Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

1 test target passed

Targets

//root:test                                                                                             23ms

Bazel 8 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 30ms.

Bazel 9 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 38ms.

Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

4 test targets passed

Targets

//:node_modules_test [k8-fastbuild]                                                                     58ms
//:test [k8-fastbuild]                                                                                  92ms
//:utils_test [k8-fastbuild]                                                                            74ms
//:write_npm_translate_lock_bzlmod_test [k8-fastbuild]                                                  96ms

Bazel 8 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 249ms.

Bazel 9 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 320ms.

Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

1 test target passed

Targets

//subdir:test                                                                                           59ms

Bazel 8 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 67ms.

Bazel 9 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 50ms.

Bazel 7 (Test)

e2e/npm_translate_package_lock

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Bazel 7 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 62ms.

Bazel 9 (Test)

e2e/npm_translate_yarn_lock

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/output_paths

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/output_paths

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/output_paths

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/patch_from_repo

1 test target passed

Targets

//:test                                                                                                 21ms

Bazel 7 (Test)

e2e/pnpm_lockfiles

59 test targets passed

Targets

//cases/docusaurus-direct-peer-v9:docusaurus_direct_with_peers [k8-fastbuild]                           51ms
//cases/isaacs-cliui-v90:isaacs_cliui [k8-fastbuild]                                                    35ms
//cases/multi-document-v11:multi_document_v11 [k8-fastbuild]                                            53ms
//cases/nested-peer-v9:nested_peers_targets [k8-fastbuild]                                              30ms
//cases/override-with-alias-url-v9:override-with-alias-url-v9 [k8-fastbuild]                            77ms
//cases/versionless-patch-v9:versionless_patch_targets [k8-fastbuild]                                   30ms
//cases/versionless-patch-v9:versionless_patch_test [k8-fastbuild]                                      119ms
//cases/workspace-peer-v9:optional_peers_targets [k8-fastbuild]                                         31ms
//v101:aliases-test [k8-fastbuild]                                                                      140ms
//v101:patch-test [k8-fastbuild]                                                                        88ms
//v101:repos_0_test [k8-fastbuild]                                                                      55ms
//v101:repos_10_test [k8-fastbuild]                                                                     62ms
//v101:repos_11_test [k8-fastbuild]                                                                     72ms
//v101:repos_12_test [k8-fastbuild]                                                                     81ms
//v101:repos_13_test [k8-fastbuild]                                                                     55ms
//v101:repos_1_test [k8-fastbuild]                                                                      50ms
//v101:repos_2_test [k8-fastbuild]                                                                      54ms
//v101:repos_3_test [k8-fastbuild]                                                                      37ms
//v101:repos_4_test [k8-fastbuild]                                                                      62ms
//v101:repos_5_test [k8-fastbuild]                                                                      42ms
//v101:repos_6_test [k8-fastbuild]                                                                      50ms
//v101:repos_7_test [k8-fastbuild]                                                                      27ms
//v101:repos_8_test [k8-fastbuild]                                                                      53ms
//v101:repos_9_test [k8-fastbuild]                                                                      89ms
//v101:targets [k8-fastbuild]                                                                           24ms
//v110:aliases-test [k8-fastbuild]                                                                      168ms
//v110:patch-test [k8-fastbuild]                                                                        107ms
//v110:repos_0_test [k8-fastbuild]                                                                      104ms
//v110:repos_10_test [k8-fastbuild]                                                                     92ms
//v110:repos_11_test [k8-fastbuild]                                                                     88ms
//v110:repos_12_test [k8-fastbuild]                                                                     89ms
//v110:repos_13_test [k8-fastbuild]                                                                     85ms
//v110:repos_1_test [k8-fastbuild]                                                                      99ms
//v110:repos_2_test [k8-fastbuild]                                                                      97ms
//v110:repos_3_test [k8-fastbuild]                                                                      86ms
//v110:repos_4_test [k8-fastbuild]                                                                      83ms
//v110:repos_5_test [k8-fastbuild]                                                                      83ms
//v110:repos_6_test [k8-fastbuild]                                                                      75ms
//v110:repos_7_test [k8-fastbuild]                                                                      72ms
//v110:repos_8_test [k8-fastbuild]                                                                      110ms
//v110:repos_9_test [k8-fastbuild]                                                                      74ms
//v110:targets [k8-fastbuild]                                                                           17ms
//v90:aliases-test [k8-fastbuild]                                                                       166ms
//v90:patch-test [k8-fastbuild]                                                                         90ms
//v90:repos_0_test [k8-fastbuild]                                                                       71ms
//v90:repos_10_test [k8-fastbuild]                                                                      67ms
//v90:repos_11_test [k8-fastbuild]                                                                      71ms
//v90:repos_12_test [k8-fastbuild]                                                                      93ms
//v90:repos_13_test [k8-fastbuild]                                                                      73ms
//v90:repos_1_test [k8-fastbuild]                                                                       50ms
//v90:repos_2_test [k8-fastbuild]                                                                       57ms
//v90:repos_3_test [k8-fastbuild]                                                                       52ms
//v90:repos_4_test [k8-fastbuild]                                                                       60ms
//v90:repos_5_test [k8-fastbuild]                                                                       78ms
//v90:repos_6_test [k8-fastbuild]                                                                       34ms
//v90:repos_7_test [k8-fastbuild]                                                                       78ms
//v90:repos_8_test [k8-fastbuild]                                                                       74ms
//v90:repos_9_test [k8-fastbuild]                                                                       97ms
//v90:targets [k8-fastbuild]                                                                            17ms

Bazel 8 (Test)

e2e/pnpm_lockfiles

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/pnpm_lockfiles

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/pnpm_repo_install

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/pnpm_repo_install

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/pnpm_repo_install

All tests were cache hits

4 tests (100.0%) were fully cached saving 4s.

Bazel 7 (Test)

e2e/pnpm_version

Waiting for runner...

Bazel 8 (Test)

e2e/pnpm_version

Waiting for runner...

Bazel 9 (Test)

e2e/pnpm_version

Waiting for runner...

Bazel 7 (Test)

e2e/pnpm_workspace

15 test targets passed

Targets

//:node_test [k8-fastbuild]                                                                             318ms
//:repos_test [k8-fastbuild]                                                                            84ms
//:vendored [k8-fastbuild]                                                                              33ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                           152ms
//app/a:npm_link_targets_node_modules_build_test [k8-fastbuild]                                         67ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                            88ms
//app/a:test [k8-fastbuild]                                                                             248ms
//app/b:aliases [k8-fastbuild]                                                                          74ms
//app/b:test [k8-fastbuild]                                                                             183ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                           133ms
//app/c:test [k8-fastbuild]                                                                             122ms
//app/d:test [k8-fastbuild]                                                                             155ms
//lib/a:vendored [k8-fastbuild]                                                                         67ms
//lib/b:aliases [k8-fastbuild]                                                                          91ms
//lib/d:aliases [k8-fastbuild]                                                                          34ms

Bazel 8 (Test)

e2e/pnpm_workspace

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/pnpm_workspace

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

Bazel 7 (Test)

e2e/pnpm_workspace_deps

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 278ms.

Bazel 9 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 237ms.

Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

15 test targets passed

Targets

//:node_test [k8-fastbuild]                                                                             313ms
//:repos_test [k8-fastbuild]                                                                            106ms
//:vendored [k8-fastbuild]                                                                              51ms
//app/a:aspect_test_a_bin_test [k8-fastbuild]                                                           150ms
//app/a:npm_link_targets_node_modules_build_test [k8-fastbuild]                                         79ms
//app/a:npm_link_targets_test [k8-fastbuild]                                                            108ms
//app/a:test [k8-fastbuild]                                                                             197ms
//app/b:aliases [k8-fastbuild]                                                                          64ms
//app/b:test [k8-fastbuild]                                                                             140ms
//app/c:aspect_test_a_bin_test [k8-fastbuild]                                                           156ms
//app/c:test [k8-fastbuild]                                                                             124ms
//app/d:test [k8-fastbuild]                                                                             172ms
//lib/a:vendored [k8-fastbuild]                                                                         72ms
//lib/b:aliases [k8-fastbuild]                                                                          59ms
//lib/d:aliases [k8-fastbuild]                                                                          76ms

Bazel 8 (Test)

e2e/pnpm_workspace_rerooted

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

14 tests (100.0%) were fully cached saving 2s.

Bazel 7 (Test)

e2e/protobuf-es

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/protobuf-es

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/protobuf-es

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/protobuf-google

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/protobuf-google

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/protobuf-google

All tests were cache hits

2 tests (100.0%) were fully cached saving 245ms.

Bazel 7 (Test)

e2e/repo_mapping

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/repo_mapping

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/repo_mapping

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/vendored_node

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/vendored_node

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/vendored_node

Buildkite build #12741 is running...

Bazel 7 (Test)

e2e/vendored_tarfile

Buildkite build #12741 is running...

Bazel 8 (Test)

e2e/vendored_tarfile

Buildkite build #12741 is running...

Bazel 9 (Test)

e2e/vendored_tarfile

Waiting for runner...

Bazel 7 (Test)

e2e/verify_patches

2 test targets passed

Targets

//:test [k8-fastbuild]                                                                                  17ms
//patches:patches_update_test [k8-fastbuild]                                                            67ms

Bazel 8 (Test)

e2e/verify_patches

Waiting for runner...

Bazel 9 (Test)

e2e/verify_patches

Buildkite build #12741 is running...

Bazel 7 (Test)

examples

83 test targets passed

Targets

//:linked_packages_build_test [k8-fastbuild]                                                            49ms
//coverage:coverage [k8-fastbuild]                                                                      100ms
//genrule:test_acorn [k8-fastbuild]                                                                     35ms
//genrule:test_require_acorn [k8-fastbuild]                                                             58ms
//js_binary:aspect_bin_a_test [k8-fastbuild]                                                            109ms
//js_binary:case7_test [k8-fastbuild]                                                                   113ms
//js_binary:npm_version_test [k8-fastbuild]                                                             242ms
//js_binary:test13-1_cjs [k8-fastbuild]                                                                 63ms
//js_binary:test13-1_mjs [k8-fastbuild]                                                                 46ms
//js_binary:test13-2_cjs [k8-fastbuild]                                                                 50ms
//js_binary:test13-2_mjs [k8-fastbuild]                                                                 74ms
//js_binary:test4-b_cjs [k8-fastbuild]                                                                  49ms
//js_binary:test4-b_mjs [k8-fastbuild]                                                                  62ms
//js_binary:test4-cjs-a [k8-fastbuild]                                                                  44ms
//js_binary:test4-mjs-a [k8-fastbuild]                                                                  65ms
//js_binary:test5_cjs [k8-fastbuild]                                                                    71ms
//js_binary:test5_mjs [k8-fastbuild]                                                                    33ms
//js_binary:test6 [k8-fastbuild]                                                                        48ms
//js_binary:test6_alt [k8-fastbuild]                                                                    35ms
//js_binary:test8 [k8-fastbuild]                                                                        38ms
//js_binary:test_cjs [k8-fastbuild]                                                                     103ms
//js_binary:test_exitcode [k8-fastbuild]                                                                59ms
//js_binary:test_js_binary_under_custom_rule [k8-fastbuild]                                             59ms
//js_binary:test_js_binary_under_custom_rule_local [k8-fastbuild]                                       47ms
//js_binary:test_js_binary_under_genrule_cjs [k8-fastbuild]                                             46ms
//js_binary:test_js_binary_under_genrule_mjs [k8-fastbuild]                                             63ms
//js_binary:test_js_binary_under_js_run_binary_cjs [k8-fastbuild]                                       115ms
//js_binary:test_js_binary_under_js_run_binary_local_cjs [k8-fastbuild]                                 57ms
//js_binary:test_js_binary_under_js_run_binary_local_mjs [k8-fastbuild]                                 48ms
//js_binary:test_js_binary_under_js_run_binary_mjs [k8-fastbuild]                                       57ms
//js_binary:test_js_binary_under_js_run_binary_no_copy_data_to_bin [k8-fastbuild]                       42ms
//js_binary:test_mjs [k8-fastbuild]                                                                     160ms
//js_binary:test_stderr [k8-fastbuild]                                                                  55ms
//js_binary:test_stdout [k8-fastbuild]                                                                  38ms
//js_lib_pkg/b:test_each_target [k8-fastbuild]                                                          112ms
//js_lib_pkg/b:test_parent_target [k8-fastbuild]                                                        144ms
//js_library/two:two_test [k8-fastbuild]                                                                94ms
//linked_consumer:direct [k8-fastbuild]                                                                 126ms
//linked_consumer:pkg [k8-fastbuild]                                                                    130ms
//linked_consumer:sources_test [k8-fastbuild]                                                           80ms
//linked_consumer:types_test [k8-fastbuild]                                                             61ms
//linked_empty_node_modules:test [k8-fastbuild]                                                         36ms
//macro:test_all [k8-fastbuild]                                                                         534ms
//macro:test_cjs [k8-fastbuild]                                                                         636ms
//macro:test_esm [k8-fastbuild]                                                                         494ms
//macro:test_js [k8-fastbuild]                                                                          524ms
//nextjs:next_build_test [k8-fastbuild]                                                                 40ms
//nextjs:write_next_links_defs_test [k8-fastbuild]                                                      81ms
//npm_deps/patches:patches_update_test [k8-fastbuild]                                                   76ms
//npm_deps:circular_deps_build_test [k8-fastbuild]                                                      48ms
//npm_deps:rollup_version_test [k8-fastbuild]                                                           179ms
//npm_deps:test1 [k8-fastbuild]                                                                         58ms
//npm_deps:test10_cjs [k8-fastbuild]                                                                    139ms
//npm_deps:test10_mjs [k8-fastbuild]                                                                    130ms
//npm_deps:test11_cjs [k8-fastbuild]                                                                    137ms
//npm_deps:test11_mjs [k8-fastbuild]                                                                    192ms
//npm_deps:test3 [k8-fastbuild]                                                                         98ms
//npm_deps:test4 [k8-fastbuild]                                                                         96ms
//npm_deps:test5 [k8-fastbuild]                                                                         79ms
//npm_deps:test5_alt [k8-fastbuild]                                                                     69ms
//npm_deps:test6 [k8-fastbuild]                                                                         152ms
//npm_deps:test7_a [k8-fastbuild]                                                                       161ms
//npm_deps:test7_b_cjs [k8-fastbuild]                                                                   136ms
//npm_deps:test7_b_mjs [k8-fastbuild]                                                                   154ms
//npm_deps:test8 [k8-fastbuild]                                                                         84ms
//npm_deps:test9_cjs [k8-fastbuild]                                                                     155ms
//npm_deps:test9_mjs [k8-fastbuild]                                                                     142ms
//npm_deps:test_peer [k8-fastbuild]                                                                     145ms
//npm_deps:test_uvu_version [k8-fastbuild]                                                              197ms
//package_json_module:test [k8-fastbuild]                                                               526ms
//runfiles:module_name_runfiles [k8-fastbuild]                                                          151ms
//runfiles:outer_runfiles [k8-fastbuild]                                                                184ms
//runfiles:run_outer_binary_asserts__direct_srcs [k8-fastbuild]                                         81ms
//runfiles:run_outer_binary_asserts__transitive_data [k8-fastbuild]                                     77ms
//runfiles:run_test_binary_asserts__direct_srcs [k8-fastbuild]                                          94ms
//runfiles:run_test_binary_asserts__transitive_data [k8-fastbuild]                                      99ms
//runfiles:runfiles [k8-fastbuild]                                                                      127ms
//stack_traces:stack_traces [k8-fastbuild]                                                              119ms
//stamped_package_json:stamp_test [k8-fastbuild]                                                        57ms
//vite3:build_test [k8-fastbuild]                                                                       39ms
//vite6:build_test [k8-fastbuild]                                                                       32ms
//webpack_cli:test [k8-fastbuild]                                                                       497ms
//worker:test_pi [k8-fastbuild]                                                                         71ms

Bazel 8 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 11s.

Bazel 9 (Test)

examples

All tests were cache hits

81 tests (100.0%) were fully cached saving 12s.

Buildifier Format

jbedard added 2 commits May 19, 2026 16:06

test: symlinks within oci images

8ced937

fix: symlinks in js_image_layer sources

5b20597

jbedard changed the title ~~fix: symlinks in js_image_layer sources~~ fix: symlinks in js_image_layer sources May 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: symlinks in js_image_layer sources #2851

fix: symlinks in js_image_layer sources #2851
jbedard wants to merge 2 commits into
aspect-build:mainfrom
jbedard:oci-layer-symlinks

jbedard commented May 20, 2026

Uh oh!

aspect-workflows Bot commented May 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jbedard commented May 20, 2026

Changes are visible to end-users: no

Test plan

Uh oh!

aspect-workflows Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

e2e/bzlmod

e2e/bzlmod

e2e/bzlmod

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/git_dep_metadata

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/gyp_no_install_script

e2e/js_binary_workspace

e2e/js_binary_workspace

e2e/js_binary_workspace

Bazel 8 (Test)

e2e/js_image_oci

Bazel 9 (Test)

e2e/js_image_oci

e2e/js_image_oci

e2e/nextjs

e2e/nextjs

e2e/nextjs

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_link_package-rerooted

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_disable_hooks

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_empty

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_exclude_package_contents

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_multi

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_partial_clone

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_replace_packages

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_lock_subdir_patch

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_package_lock

e2e/npm_translate_yarn_lock

e2e/npm_translate_yarn_lock

e2e/npm_translate_yarn_lock

e2e/output_paths

e2e/output_paths

e2e/output_paths

e2e/patch_from_repo

e2e/pnpm_lockfiles

e2e/pnpm_lockfiles

e2e/pnpm_lockfiles

e2e/pnpm_repo_install

e2e/pnpm_repo_install

e2e/pnpm_repo_install

Bazel 7 (Test)

e2e/pnpm_version

Bazel 8 (Test)

e2e/pnpm_version

aspect-workflows Bot commented May 20, 2026 •

edited

Loading