Skip to content

fix(npm): correct package_store_prefix_len for links in external-repo sub-packages #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ma-oli wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(npm): correct package_store_prefix_len for links in external-repo sub-packages #2896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions npm/private/npm_package_store.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,9 @@ def _npm_package_store_impl(ctx):

package_store_prefix_len = _PACKAGE_STORE_PREFIX_LEN
if ctx.label.package:
package_store_prefix_len += len(ctx.label.package)
package_store_prefix_len += len(ctx.label.package) + 1 # +1 for the "/" after the package path
if ctx.label.repo_name:
package_store_prefix_len += len(ctx.label.repo_name) + 3 # +3 for ../
package_store_prefix_len += len(ctx.label.repo_name) + 3 + 1 # +3 for "../", +1 for the "/" after the repo name

package_key = "{}@{}".format(package, version)
package_store_name = utils.package_store_name(package_key)
Expand Down
Loading