perf: reduce per-action overhead registering NpmPackageExtract#2910
Open
jbedard wants to merge 1 commit into
Open
perf: reduce per-action overhead registering NpmPackageExtract#2910jbedard wants to merge 1 commit into
jbedard wants to merge 1 commit into
Conversation
dzbarsky
approved these changes
Jul 9, 2026
dzbarsky
left a comment
dzbarsky
left a comment
Collaborator
There was a problem hiding this comment.
curious how you measured an improvement?
acozzette
approved these changes
Jul 9, 2026
Member
Author
|
A robot measured it somehow. In this case I'll blindly accept that since it's literally converting 7 invocations and 1 array creation into 1-2 invocations and 1 array creation. I think that's a win no matter what? But any changes you think are questionable please flag them and I'll analyze them individually... These were all robot suggestions after analyzing |
Build the tar argument list with a single add_all call, hoist the constant execution_requirements dict, and skip the --exclude pass when exclude_package_contents is empty. The rendered command line is unchanged.
jbedard
force-pushed
the
perf-extract-action-args
branch
from
543fa75 to
a0bce6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the tar argument list with a single add_all call, hoist the constant execution_requirements dict, and skip the --exclude pass when exclude_package_contents is empty. The rendered command line is unchanged.
Changes are visible to end-users: no
Test plan