test: add py_pex_binary scenarios (#1343)

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

Author: jbedard

e2e/cases/pex-interpreter-exclusion/BUILD.bazel

@@ -11,9 +11,28 @@ py_pex_binary(
     python_interpreter_constraints = [],
 )
 
+# The interpreter is excluded from the PEX by the binary's *own* toolchain, not
+# the pex rule's. 3.13 differs from this workspace's default (3.11), so a leak
+# here would mean the exclusion tracked the wrong version.
+py_binary(
+    name = "app_mismatch",
+    srcs = ["app.py"],
+    main = "app.py",
+    python_version = "3.13",
+)
+
+py_pex_binary(
+    name = "app_mismatch_pex",
+    binary = ":app_mismatch",
+    python_interpreter_constraints = [],
+)
+
 py_test(
     name = "test_pex_excludes_interpreter",
     srcs = ["test_pex_excludes_interpreter.py"],
-    data = [":app_pex"],
+    data = [
+        ":app_mismatch_pex",
+        ":app_pex",
+    ],
     main = "test_pex_excludes_interpreter.py",
 )

e2e/cases/pex-interpreter-exclusion/test_pex_excludes_interpreter.py

@@ -2,18 +2,24 @@
 import zipfile
 from pathlib import Path
 
-PEX = "_main/pex-interpreter-exclusion/app_pex.pex"
+# app_pex uses the default toolchain; app_mismatch_pex pins python_version 3.13
+# (!= the workspace default) so both the same-version and cross-version
+# interpreter-exclusion paths are covered.
+PEXES = (
+    "_main/pex-interpreter-exclusion/app_pex.pex",
+    "_main/pex-interpreter-exclusion/app_mismatch_pex.pex",
+)
 INTERPRETER_REPO_MARKERS = (
     "aspect_rules_py++python_interpreters+",
     "aspect_rules_py~~python_interpreters~",
 )
 
-pex = Path(os.environ["RUNFILES_DIR"]) / PEX
-with zipfile.ZipFile(pex) as zf:
-    leaked = [
-        name
-        for name in zf.namelist()
-        if any(marker in name for marker in INTERPRETER_REPO_MARKERS)
-    ]
-
-assert not leaked, leaked[:10]
+for rel in PEXES:
+    pex = Path(os.environ["RUNFILES_DIR"]) / rel
+    with zipfile.ZipFile(pex) as zf:
+        leaked = [
+            name
+            for name in zf.namelist()
+            if any(marker in name for marker in INTERPRETER_REPO_MARKERS)
+        ]
+    assert not leaked, (rel, leaked[:10])

e2e/cases/uv-sdist-fallback/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@aspect_rules_py//py:defs.bzl", "py_binary", "py_image_layer", "py_test")
+load("@aspect_rules_py//py:defs.bzl", "py_binary", "py_image_layer", "py_pex_binary", "py_test")
 load("@bazel_skylib//rules:build_test.bzl", "build_test")
 
 # Regression coverage for the sdist-fallback behavior preserved by the
@@ -35,6 +35,23 @@ py_image_layer(
     binary = ":image_bin",
 )
 
+# py_pex_binary must discover the source-built cowsay's install tree through
+# PyWheelsInfo (its analysis-time metadata is empty), the same path image
+# layering exercises above.
+py_pex_binary(
+    name = "sdist_pex",
+    testonly = True,
+    binary = ":image_bin",
+    python_interpreter_constraints = [],
+)
+
+py_test(
+    name = "sdist_pex_test",
+    srcs = ["sdist_pex_test.py"],
+    data = [":sdist_pex"],
+    main = "sdist_pex_test.py",
+)
+
 filegroup(
     name = "image_dependency_layers",
     testonly = True,

e2e/cases/uv-sdist-fallback/sdist_pex_test.py

@@ -0,0 +1,28 @@
+"""py_pex_binary must package a source-built (sdist) wheel.
+
+cowsay 6.0 is forced to build from source (no-binary-package), so its
+PyWheelsInfo record carries an install_tree but empty analysis-time metadata.
+The refactored py_pex_binary discovers deps through PyWheelsInfo, so it must
+still emit cowsay as a `--dependency` even without that metadata, while keeping
+the interpreter and venv plumbing out.
+"""
+
+import os
+import zipfile
+from pathlib import Path
+
+pex = Path(os.environ["RUNFILES_DIR"]) / "_main/uv-sdist-fallback/sdist_pex.pex"
+with zipfile.ZipFile(pex) as zf:
+    names = zf.namelist()
+
+assert any(
+    n.endswith("cowsay/__init__.py") for n in names
+), "source-built cowsay missing from pex: {}".format(names[:20])
+
+interpreter = [n for n in names if "python_interpreters" in n]
+assert not interpreter, interpreter[:10]
+
+venv_plumbing = [
+    n for n in names if n.endswith("pyvenv.cfg") or n.endswith(".pth") or ".venv/" in n
+]
+assert not venv_plumbing, venv_plumbing

py/tests/py-pex-binary/BUILD.bazel

@@ -78,6 +78,7 @@ py_test(
         ":defaults_pex",
         ":inherit_fallback_pex",
         ":inherit_false_pex",
+        ":print_modules_pex",
     ],
     main = "pex_info_test.py",
     deps = ["@pypi//bazel_runfiles"],

py/tests/py-pex-binary/pex_info_test.py

@@ -59,4 +59,32 @@ def read_pex(name):
 _, info = read_pex("inherit_false_pex")
 assert info.get("inherit_path", "false") == "false", info
 
+
+# print_modules_pex has real deps (a venv + wheels), so it exercises the
+# structural exclusions: the sibling venv's `.pth`/`pyvenv.cfg` plumbing and the
+# interpreter must be filtered out, while first-party `data` files are kept.
+def pex_names(name):
+    path = r.Rlocation("{}/{}.pex".format(PKG, name))
+    with zipfile.ZipFile(path) as zf:
+        return zf.namelist()
+
+
+names = pex_names("print_modules_pex")
+
+venv_plumbing = [
+    n
+    for n in names
+    if n.endswith("pyvenv.cfg") or n.endswith(".pth") or ".venv/" in n
+]
+assert not venv_plumbing, venv_plumbing
+
+interpreter = [n for n in names if "python_interpreters" in n]
+assert not interpreter, interpreter[:10]
+
+# The wheels arrive as `--dependency` under `.deps/`, not as loose sources.
+assert any("cowsay" in n for n in names), "cowsay missing from pex"
+
+# Plain data files travel with the sources (transitive_sources is .py-only).
+assert any(n.endswith("/data.txt") for n in names), "data.txt missing from pex"
+
 print("PASS")