-
-
Notifications
You must be signed in to change notification settings - Fork 96
feat: Support tool.uv.extra-build-dependencies in annotation loading
#1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
77a8de6
556e226
8821117
1396370
55f1540
1a689f4
e793a95
2812d43
0ffa4bd
6d19e66
a0b4ab1
07d3809
31d50c8
46fdfe9
c4b6971
a6f5976
a6aaf44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,6 @@ conflicts = [ | |
| { group = "ambig-b" }, | ||
| ], | ||
| ] | ||
|
|
||
| [tool.uv.extra-build-dependencies] | ||
| packaging = ["pyparsing"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| import cowsay | ||
| import six | ||
|
|
||
| assert "git build dependency" in cowsay.get_output_string("cow", "git build dependency") | ||
| assert six.__version__ == "1.17.0", six.__version__ | ||
| assert six.ensure_str(b"git-source") == "git-source" | ||
|
|
||
| print("six", six.__version__, "imported from git source") | ||
| print("six", six.__version__, "and cowsay imported from source builds") |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # Fixture data is consumed by this module's extension. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| module(name = "missing_extra_build_dep_fixture") | ||
|
|
||
| bazel_dep(name = "aspect_rules_py") | ||
| local_path_override( | ||
| module_name = "aspect_rules_py", | ||
| path = "../../../..", | ||
| ) | ||
|
|
||
| uv = use_extension("@aspect_rules_py//uv:extensions.bzl", "uv") | ||
| uv.declare_hub(hub_name = "missing_extra_build_dep") | ||
| uv.project( | ||
| default_build_dependencies = [], | ||
| hub_name = "missing_extra_build_dep", | ||
| lock = "//:uv.lock", | ||
| pyproject = "//:pyproject.toml", | ||
| ) | ||
| use_repo(uv, "missing_extra_build_dep") |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [project] | ||
| name = "missing-extra-build-dep" | ||
| version = "0.0.0" | ||
| requires-python = ">=3.11" | ||
| dependencies = ["cchardet==2.1.7"] | ||
|
|
||
| [tool.uv.extra-build-dependencies] | ||
| cchardet = ["cython"] |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still be testing both though? Or is this old/deprecated enough we can just delete it (instead of commenting it out like this)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it there to not confuse user who come across the old format. imho it's fine to keep both format around and avoid breaking users, the comment should help users to understand what they should use and why they may see something different in existing code.